Features/DebugPythonStacks

From FedoraProject

< Features(Difference between revisions)
Jump to: navigation, search
(Comments and Discussion)
(Scope: start adding status table)
 
(5 intermediate revisions by 2 users not shown)
Line 17: Line 17:
  
 
== Current status ==
 
== Current status ==
* Targeted release: [[Releases/14 | Fedora 14 ]]  
+
* Targeted release: [[Releases/? | Fedora ? ]]  
* Last updated: 2010-07-07
+
* Last updated: 2010-08-03
 
* Percentage of completion: 20%
 
* Percentage of completion: 20%
  
 
<!-- CHANGE THE "FedoraVersion" TEMPLATES ABOVE TO PLAIN NUMBERS WHEN YOU COMPLETE YOUR PAGE. -->
 
<!-- CHANGE THE "FedoraVersion" TEMPLATES ABOVE TO PLAIN NUMBERS WHEN YOU COMPLETE YOUR PAGE. -->
 +
 +
Summary: python and python3 packages support this, but no debug stack has been built "on top".  Usable for debugging if purely using "noarch" modules.
  
 
Initial notes on this: [[DaveMalcolm/PythonIdeas]]
 
Initial notes on this: [[DaveMalcolm/PythonIdeas]]
Line 32: Line 34:
 
  ! Package !! Latest build !! Debug flags
 
  ! Package !! Latest build !! Debug flags
 
|-
 
|-
| python || [http://koji.fedoraproject.org/koji/buildinfo?buildID=175053 python-2.6.5-10.fc14] || <code>--with-py-debug</code> (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), <code>WITH_TSC</code>, with <code>COUNT_ALLOCS</code>, with <code>CALL_PROFILE</code>; noise at stdout from COUNT_ALLOCS
+
| python || python-2.7-7.fc14 || <code>--with-py-debug</code> (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), <code>WITH_TSC</code>, with <code>COUNT_ALLOCS</code>, with <code>CALL_PROFILE</code>; noise at stdout from COUNT_ALLOCS
 
|-
 
|-
 
| python3 || [http://koji.fedoraproject.org/koji/buildinfo?buildID=175057  python3-3.1.2-7.fc14] ||  <code>--with-py-debug</code> (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), <code>WITH_TSC</code>, with <code>COUNT_ALLOCS</code>, with <code>CALL_PROFILE</code>; noise at stdout from COUNT_ALLOCS
 
| python3 || [http://koji.fedoraproject.org/koji/buildinfo?buildID=175057  python3-3.1.2-7.fc14] ||  <code>--with-py-debug</code> (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), <code>WITH_TSC</code>, with <code>COUNT_ALLOCS</code>, with <code>CALL_PROFILE</code>; noise at stdout from COUNT_ALLOCS
Line 48: Line 50:
 
* Package debug builds of important extension modules
 
* Package debug builds of important extension modules
 
* Consider turning  down the gcc optimization level of the debug build from -O2 to something less.
 
* Consider turning  down the gcc optimization level of the debug build from -O2 to something less.
* This will (hopefully) all be for 2.7, not 2.6; see [[Features/Python_2.7]].  This page will need updating to reflect that when 2.7 lands.
 
  
 
== Detailed Description ==
 
== Detailed Description ==
Line 58: Line 59:
 
Typically these are of use to people working on Python C extensions, for example, for tracking down awkward reference-counting mistakes.
 
Typically these are of use to people working on Python C extensions, for example, for tracking down awkward reference-counting mistakes.
  
In Fedora 14 we now supply <code>python-debug</code> and <code>python3-debug</code> packages containing debug builds of Python 2 and 3 with these settings turned on.
+
In Fedora ___ we now supply <code>python-debug</code> and <code>python3-debug</code> packages containing debug builds of Python 2 and 3 with these settings turned on.
  
 
It is intended for use by advanced Python users, and is installable on top of the normal (optimized) build.  The builds share the same .py and .pyc files, but have their own compiled libraries and extension modules.
 
It is intended for use by advanced Python users, and is installable on top of the normal (optimized) build.  The builds share the same .py and .pyc files, but have their own compiled libraries and extension modules.
Line 64: Line 65:
 
=== Technical notes ===
 
=== Technical notes ===
  
The Fedora 14 python.src.rpm now configures and builds, and installs the python sources twice, once with the regular optimized settings, and again with debug settings. (in most cases the files are identical between the two installs, and for the files that are different, they get separate paths)
+
The Fedora ____ python.src.rpm now configures and builds, and installs the python sources twice, once with the regular optimized settings, and again with debug settings. (in most cases the files are identical between the two installs, and for the files that are different, they get separate paths)
  
 
The builds are set up so that they can share the same .py and .pyc files - they have the same bytecode format.
 
The builds are set up so that they can share the same .py and .pyc files - they have the same bytecode format.
Line 72: Line 73:
 
The key to keeping the different module ABIs separate is that module "foo.so" for the standard optimized build will instead be "foo_d.so i.e. gaining a "_d" suffix to the filename, and this is what the "import" routine will look for.  This convention ultimately comes from the way the Windows build is set up in the upstream build process, via a similar patch that Debian apply.
 
The key to keeping the different module ABIs separate is that module "foo.so" for the standard optimized build will instead be "foo_d.so i.e. gaining a "_d" suffix to the filename, and this is what the "import" routine will look for.  This convention ultimately comes from the way the Windows build is set up in the upstream build process, via a similar patch that Debian apply.
  
Similarly, the optimized libpython2.6.so.1.0 now has a libpython2.6_d.so.1.0 cousin for the debug build: all of the extension modules are linked against the appropriate libpython, and there's a /usr/include/python2.6-debug directory, parallel with the /usr/include/python2.6 directory.  There's a new "sys.pydebug"
+
Similarly, the optimized libpython2.7.so.1.0 now has a libpython2.7_d.so.1.0 cousin for the debug build: all of the extension modules are linked against the appropriate libpython, and there's a /usr/include/python2.7-debug directory, parallel with the /usr/include/python2.7 directory.  There's a new "sys.pydebug"
 
boolean to distinguish the two configurations, and the distutils module uses this to supply the appropriate header paths ,and linker flags when building C extension modules.
 
boolean to distinguish the two configurations, and the distutils module uses this to supply the appropriate header paths ,and linker flags when building C extension modules.
  
The debug build's python binary is /usr/bin/python2.6-debug, hardlinked as /usr/bin/python-debug (as opposed to /usr/bin/python2.6 and /usr/bin/python)
+
The debug build's python binary is /usr/bin/python2.7-debug, hardlinked as /usr/bin/python-debug (as opposed to /usr/bin/python2.7 and /usr/bin/python)
  
 
Finally, we do all of the above for the python3.src.rpm as well.
 
Finally, we do all of the above for the python3.src.rpm as well.
Line 94: Line 95:
 
* pygtk2
 
* pygtk2
  
A more ambitious goal would be to do to this for all compiled extension modules; it may be too late to do this for Fedora 14.
+
A more ambitious goal would be to do to this for all compiled extension modules.
  
 
By comparison, Ubuntu does this for all "desktop" python modules:
 
By comparison, Ubuntu does this for all "desktop" python modules:
 
https://wiki.ubuntu.com/PyDbgBuilds
 
https://wiki.ubuntu.com/PyDbgBuilds
 +
 +
(keep this this sorted alphabetically by python module name)
 +
{|
 +
! Python Module !! Fedora Python package !! Status
 +
|-
 +
| psycopg2 || python-psycopg2 || Awaiting review from packager: {{bz|676748}} (also adds python 3 support)
 +
|}
  
 
== How To Test ==
 
== How To Test ==
Line 295: Line 303:
 
== User Experience ==
 
== User Experience ==
 
<!-- If this feature is noticeable by its target audience, how will their experiences change as a result?  Describe what they will see or notice. -->
 
<!-- If this feature is noticeable by its target audience, how will their experiences change as a result?  Describe what they will see or notice. -->
Fedora 14 now has a <code>python-debug</code> package containing debug versions of all of the content of the regular subpackages emitted by the python build (as opposed to the <code>python-debuginfo</code> package, which contains data for use by gdb (and thus is of use by the optimized stack).
+
Fedora ____ now has a <code>python-debug</code> package containing debug versions of all of the content of the regular subpackages emitted by the python build (as opposed to the <code>python-debuginfo</code> package, which contains data for use by gdb (and thus is of use by the optimized stack).
  
 
The optimized build should be unaffected by the presence (or availability) of the debug build: all of the paths and the ELF metadata for the standard build
 
The optimized build should be unaffected by the presence (or availability) of the debug build: all of the paths and the ELF metadata for the standard build
Line 305: Line 313:
 
<pre>
 
<pre>
 
[david@fedora14 devel]$ python-debug
 
[david@fedora14 devel]$ python-debug
Python 2.6.5 (r265:79063, May 19 2010, 18:20:14)  
+
Python 2.7 (r27:82500, Jul 28 2010, 18:07:22)  
[GCC 4.4.3 20100422 (Red Hat 4.4.3-18)] on linux2
+
[GCC 4.5.0 20100716 (Red Hat 4.5.0-3)] on linux2
 
Type "help", "copyright", "credits" or "license" for more information.
 
Type "help", "copyright", "credits" or "license" for more information.
 
>>> print "hello world"
 
>>> print "hello world"
Line 345: Line 353:
 
* See [[Talk:Features/DebugPythonStacks]]  <!-- This adds a link to the "discussion" tab associated with your page.  This provides the ability to have ongoing comments or conversation without bogging down the main feature page -->
 
* See [[Talk:Features/DebugPythonStacks]]  <!-- This adds a link to the "discussion" tab associated with your page.  This provides the ability to have ongoing comments or conversation without bogging down the main feature page -->
  
[[Category:FeatureReadyForFesco]]
+
[[Category:FeaturePageIncomplete]]
 
<!-- When your feature page is completed and ready for review -->
 
<!-- When your feature page is completed and ready for review -->
 
<!-- remove Category:FeaturePageIncomplete and change it to Category:FeatureReadyForWrangler -->
 
<!-- remove Category:FeaturePageIncomplete and change it to Category:FeatureReadyForWrangler -->
 
<!-- After review, the feature wrangler will move your page to Category:FeatureReadyForFesco... if it still needs more work it will move back to Category:FeaturePageIncomplete-->
 
<!-- After review, the feature wrangler will move your page to Category:FeatureReadyForFesco... if it still needs more work it will move back to Category:FeaturePageIncomplete-->
 
<!-- A pretty picture of the page category usage is at: https://fedoraproject.org/wiki/Features/Policy/Process -->
 
<!-- A pretty picture of the page category usage is at: https://fedoraproject.org/wiki/Features/Policy/Process -->
 +
[[Category:Python]]

Latest revision as of 23:13, 14 February 2011


Contents

[edit] Debug Python stacks

[edit] Summary

Fedora now ships debug versions of Python 2 and Python 3 in addition to the traditional optimized builds. This will be of use to advanced Python users, such as developers of extension modules.

[edit] Owner

  • Email: <dmalcolm@redhat.com>

[edit] Current status

  • Targeted release: Fedora ?
  • Last updated: 2010-08-03
  • Percentage of completion: 20%


Summary: python and python3 packages support this, but no debug stack has been built "on top". Usable for debugging if purely using "noarch" modules.

Initial notes on this: DaveMalcolm/PythonIdeas

See email

See the upstream notes on what all the flags do

Package Latest build Debug flags
python python-2.7-7.fc14 --with-py-debug (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), WITH_TSC, with COUNT_ALLOCS, with CALL_PROFILE; noise at stdout from COUNT_ALLOCS
python3 python3-3.1.2-7.fc14 --with-py-debug (implies Py_DEBUG, which implies LLTRACE, Py_REF_DEBUG, Py_TRACE_REFS, and PYMALLOC_DEBUG), WITH_TSC, with COUNT_ALLOCS, with CALL_PROFILE; noise at stdout from COUNT_ALLOCS
  • Noise from COUNT_ALLOCS: Outputs counts to stdout on exit; this may be too much, making it impossible to write some scripted usage of the interpreter. Nice to have sys.getcounts(), so perhaps we should talk with upstream and instead emit counts to stderr instead, make this only happen if an envvar is set, or simply omit it?
CodecInfo alloc'd: 1, freed: 0, max in use: 1
exceptions.ImportError alloc'd: 2, freed: 2, max in use: 1
_Helper alloc'd: 1, freed: 1, max in use: 1
_Printer alloc'd: 3, freed: 3, max in use: 3
(etc)
  • Figure out sane RPM conventions for packaging debug builds of extension modules
  • Package debug builds of important extension modules
  • Consider turning down the gcc optimization level of the debug build from -O2 to something less.

[edit] Detailed Description

In previous releases we have configured our build of Python for the typical use-case: as much optimization as reasonable.

However, upstream Python supports a number of useful debug options which use more RAM and CPU cycles, but make it easier to track down bugs [2]

Typically these are of use to people working on Python C extensions, for example, for tracking down awkward reference-counting mistakes.

In Fedora ___ we now supply python-debug and python3-debug packages containing debug builds of Python 2 and 3 with these settings turned on.

It is intended for use by advanced Python users, and is installable on top of the normal (optimized) build. The builds share the same .py and .pyc files, but have their own compiled libraries and extension modules.

[edit] Technical notes

The Fedora ____ python.src.rpm now configures and builds, and installs the python sources twice, once with the regular optimized settings, and again with debug settings. (in most cases the files are identical between the two installs, and for the files that are different, they get separate paths)

The builds are set up so that they can share the same .py and .pyc files - they have the same bytecode format.

However, they are incompatible at the machine-code level: the extra debug-checking options change the layout of Python objects in memory, so the configurations have different shared library ABIs. A compiled C extension built for one will not work with the other.

The key to keeping the different module ABIs separate is that module "foo.so" for the standard optimized build will instead be "foo_d.so i.e. gaining a "_d" suffix to the filename, and this is what the "import" routine will look for. This convention ultimately comes from the way the Windows build is set up in the upstream build process, via a similar patch that Debian apply.

Similarly, the optimized libpython2.7.so.1.0 now has a libpython2.7_d.so.1.0 cousin for the debug build: all of the extension modules are linked against the appropriate libpython, and there's a /usr/include/python2.7-debug directory, parallel with the /usr/include/python2.7 directory. There's a new "sys.pydebug" boolean to distinguish the two configurations, and the distutils module uses this to supply the appropriate header paths ,and linker flags when building C extension modules.

The debug build's python binary is /usr/bin/python2.7-debug, hardlinked as /usr/bin/python-debug (as opposed to /usr/bin/python2.7 and /usr/bin/python)

Finally, we do all of the above for the python3.src.rpm as well.

[edit] Benefit to Fedora

By shipping pre-built debug Python 2 and 3 stacks we make it easier to write and debug Python extension modules on Fedora: we make it easier for developers to track down various kinds of bugs in their code.

[edit] Scope

Requires rebuild of "python" and "python3" rpms (already done).

Beyond that, it's somewhat arbitrary in scope: any python- RPMs that contain arch-specific code are potential candidates for gaining a -debug subpackage. Will need to work with package maintainers. In some ways it's similar to the python3 split.

My aim is to cover "high-value" python compiled extension modules

  • coverage
  • numpy
  • pygtk2

A more ambitious goal would be to do to this for all compiled extension modules.

By comparison, Ubuntu does this for all "desktop" python modules: https://wiki.ubuntu.com/PyDbgBuilds

(keep this this sorted alphabetically by python module name)

Python Module Fedora Python package Status
psycopg2 python-psycopg2 Awaiting review from packager: RHBZ #676748 (also adds python 3 support)

[edit] How To Test

[edit] Verify optimized python stacks

Here's my own test plan for this:

  • Smoketest of the interpreter
  • Run the upstream regression test suite
  • Ensure that yum still works
  • Ensure that anaconda still works
  • Verify that a python extension with some .c code can be rebuilt and works (python-coverage)

[edit] Verify debug python stacks

Here's my own test plan for python-debug:

  • Smoketest of the interpreter
  • Run the upstream regression test suite
  • Verify that a python extension with some .c code can be rebuilt and works (python-coverage)

[edit] Verify Py_REF_DEBUG

Install python-debug and python3-debug

$ python-debug -c "import sys; print(sys.gettotalrefcount())"
28564
[15039 refs]

$ python3-debug -c "import sys; print(sys.gettotalrefcount())"
28564
[15039 refs]

and ensure that each prints a number to stdout (and a refcount to stderr)

[edit] Verify Py_TRACE_REFS

Verify that python-debug can print all live objects:

$ python-debug -c "import sys; print(sys.getobjects(0))" | less
[<frame object at 0x1181eb0>, <code object <module> at 0x7f379227f970, file "<string>", line 1>, (-1, None, 0), 
(snip)
$ python3-debug -c "import sys; print(sys.getobjects(0))" | less
[b'<string>', <frame object at 0xd78060>, <code object <module> at 0x7f84cc5ddbf0, file "<string>", line 1>, (0, None),
(snip)

In both cases there ought to be a large amount of debug information sent to stdout

Verify that python-debug can print all live objects of a given type (e.g. "int"):

$ python-debug -c "import sys; print(sys.getobjects(0, int))" |less
[8000, 512, 2147483647, 590923713, 907133923, (snip)
$ python3-debug -c "import sys; print(sys.getobjects(0, int))"
[131180, 327681, 327680, 131119, 131121, 131120, 131118, 131116, (snip)

Verify that setting the PYTHONDUMPREFS environment variable causes lots of info to be dumped to stderr on exit:

$ PYTHONDUMPREFS=1 python-debug -c "pass"
[15039 refs]
Remaining objects:
0x7fba34c1ac08 [1] 'last_traceback'
0x7fba34c1aba0 [1] 'last_value'
0x7fba34c1a860 [1] 'last_type'
(etc)

$ PYTHONDUMPREFS=1 python3-debug -c "pass"
[35078 refs]
Remaining objects:
0x20c4148 [1] b'flush'
0x1bf1640 [1] b'OverflowError'
0x1c55860 [1] b'UnboundLocalError'
(etc)

[edit] Verify PYMALLOC_DEBUG

Verify the PYTHONMALLOCSTATS environment variable.

Ensure that running with the env var set causes debugging information to be logged to stderr at exit:

$ PYTHONMALLOCSTATS=1 python-debug -c "pass"
Small block threshold = 256, in 32 size classes.

class   size   num pools   blocks in use  avail blocks
-----   ----   ---------   -------------  ------------
    4     40           1               1           100
    6     56           1               1            71
    7     64           1              30            33
    9     80           1               1            49
   10     88           1               2            44
   11     96          29             560           658
   12    104          21             394           404
   13    112          21             418           338
   14    120          45            1032           453
   15    128          37             943           204
   16    136          10             182           108
   17    144           5              82            58
   18    152           3              37            41
   19    160           3              21            54
   20    168          26             313           311
   21    176           2              14            32
   22    184           1               5            17
   23    192           2               5            37
   24    200           2               4            36
   25    208           1               6            13
   26    216           1               1            17
   27    224           1               2            16
   28    232           2               6            28
   29    240           1               2            14
   30    248           1               2            14
   31    256           1               1            14

# times object malloc called       =               58,737
# arenas allocated total           =                    5
# arenas reclaimed                 =                    0
# arenas highwater mark            =                    5
# arenas allocated current         =                    5
5 arenas * 262144 bytes/arena      =            1,310,720

# bytes in allocated blocks        =              496,176
# bytes in available blocks        =              381,488
95 unused pools * 4096 bytes       =              389,120
# bytes lost to pool headers       =               10,560
# bytes lost to quantization       =               12,896
# bytes lost to arena alignment    =               20,480
Total                              =            1,310,720

$ PYTHONMALLOCSTATS=1 python3-debug -c "pass"

FIXME: can we verify the buffer overrun code?

[edit] Verify COUNT_ALLOCS

$ python-debug -c "import sys; from pprint import pprint ; pprint(sys.getcounts())"
[('CodecInfo', 1, 0, 1),
 ('exceptions.ImportError', 2, 2, 1),
 ('_Helper', 1, 0, 1),
 ('_Printer', 3, 0, 3),
(snip)
$ python3-debug -c "import sys; from pprint import pprint ; pprint(sys.getcounts())"

In both cases, a list of 4-tuples, one per type, should be printed to stdout:

  • the name of the type
  • the number of times an object of this type was allocated
  • the number of times an object of this type was deallocated
  • the highwater mark: the largest number of objects of this type alive at the same time during the lifetime of the process

[edit] Verify LLTRACE

python-debug -c "__lltrace__ = True ; import site"

python3-debug -c "__lltrace__ = True ; import site"

If __lltrace__ is defined within a Python frame, huge amounts of debug information should get dumped to stdout about what the bytecode interpreter is doing.

[edit] Verify CALL_PROFILE

$ python-debug -c "import sys; print(sys.callstats())"
(snip)
$ python3-debug -c "import sys; print(sys.callstats()"
(snip)

In both cases there ought to be a tuple of 11 integers sent to stdout (rather than "None")

[edit] Verify WITH_TSC

$ python-debug -c "import sys ; sys.settscdump(True) ; print(42)"

$ python3-debug -c "import sys ; sys.settscdump(True) ; print(42)"
opcode=131 t=0 inst=001725 loop=001923
opcode=101 t=0 inst=001513 loop=001979
42
opcode=131 t=0 inst=001371 loop=001715

Setting sys.settscdump(True) will make Python emit detailed timings about its bytecode interpreter to stderr, using the CPU's time-stamp counter.

Specifically, stderr will contain a line about each bytecode executed, of the form:

 opcode=XXX t=X inst=XXXXXX loop=XXXXXX

where:

  • opcode gives the numeric opcode being executed (see the list opcode.opname in the opcode module)
  • t : did the periodic ticker fire? (e.g. for switching threads; normally every 1000 bytecodes; changable with sys.setcheckinterval)
  • inst : time taken within switch statement, not including "interruptions" where work is being done by a Python function
  • loop : time taken between the top and bottom of the main bytecode dispatch loop, again not including "interruptions"

[edit] User Experience

Fedora ____ now has a python-debug package containing debug versions of all of the content of the regular subpackages emitted by the python build (as opposed to the python-debuginfo package, which contains data for use by gdb (and thus is of use by the optimized stack).

The optimized build should be unaffected by the presence (or availability) of the debug build: all of the paths and the ELF metadata for the standard build should be unchanged compared to how they were before adding the debug configuration.

Installing the debug package gives you a /usr/bin/python-debug, analogous to the regular /usr/bin/python

The interactive mode of this version tells you the total reference count of all live Python objects after each command:

[david@fedora14 devel]$ python-debug
Python 2.7 (r27:82500, Jul 28 2010, 18:07:22) 
[GCC 4.5.0 20100716 (Red Hat 4.5.0-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> print "hello world"
hello world
[28748 refs]
>>> 
[28748 refs]
[15041 refs]

The debug build shares most of the files with the regular build (.py/.pyc/.pyo files; directories; support data; documentation); the only differences are the ELF files (binaries/shared libraries), and infrastructure relating to configuration (Include files, Makefile, python-config => python-debug-config, etc) that are different.

[edit] Dependencies

None

[edit] Contingency Plan

If there are major unfixable problems, we can disable the debug build in the python src.rpm and any other src.rpms that use it. The extent of this would depend on how many packages we had built with -debug subpackages. All such packages should have a with_debug_build macro, to give us an easy "off" switch for this eventuality.

Having said that, I've been testing with this feature with local builds and it works.

[edit] Documentation

[edit] Release Notes

Fedora now ships debug versions of Python 2 and Python 3 in addition to the traditional optimized builds. This will be of use to advanced Python users, such as developers of extension modules.

The debug versions are in the python-debug and python3-debug packages, and can be invoked using python-debug (for Python 2) and python3-debug (for Python 3).

Details on how to use these packages can be seen at Features/DebugPythonStacks

FIXME: Obviously this can be updated based on exactly how many src.rpms we build out with -debug subpackages.

[edit] Comments and Discussion