Systemd unit cleanup and enhancement
Bringing shipped units closer to upstream with various cleanups along with introducing new documentation systemd feature to them.
- Name: Jóhann B. Guðmundsson
- Email: johannbg AT gmail DOT com
Benefit to Fedora
Documentation= Field will bring more informational status output to our users base which links to the relevant
- Add Documentation= field which will contain relevant man pages to already existing units
- Change PIDFile=/var/run/foo fields to point to PIDFile=/run/foo instead
- Drop any EnvironmentalFile= field in units that points to /etc/sysconfig/foo files
How To Test
- Install/update to the package that contains the new native systemd unit file.
- Check if the update process happened cleanly
- Check if the old sysvinit init script did get removed after install
- Check if the service starts cleanly after install
- check if the service stops cleanly after and install
- Check if the service reloads cleanly correctly if applicable
- Enable the service then restart
- check if the shutdown process happened cleanly with the service enabled
- check if the service started cleanly at startup
Other than the added documentation field in the units status output
Depends on legacy sysv initscript to have been converted to native systemd units.
Continue to ship the systemd units as is.
- It's recommended that documentation for relevant applications that contained and used EnvironmentFile reference points users to [ https://fedoraproject.org/wiki/Systemd#How_do_I_customize_a_unit_file.2F_add_a_custom_unit_file.3F | How_do I customize a unit file ]
There shouldn't be anything we need to specifically say other than highlighting the change.
Comments and Discussion