ReviewTool

From FedoraProject

(Difference between revisions)
Jump to: navigation, search
(add initial close section; update status with new output layout)
Line 8: Line 8:
  
 
<pre>
 
<pre>
[cweyl@athena bin]$ ./reviewtool status
+
[cweyl@athena bin]$ time ./reviewtool status
 
Retrieving status from bugzilla....
 
Retrieving status from bugzilla....
  
Fetching bugzilla data: 100% [=======================================]D 0h00m05s
+
Fetching bugzilla data: 100% [===================================]D 0h00m05s
  
.--------+---+---+--------------------------------------+----------------------.
+
.--------+---+---+---------------------------------------------------------.
| Bug    | R | C | Name                                 | Last Update          |
+
| Bug    | R | C | Name                                                   |
+--------+---+---+--------------------------------------+----------------------+
+
+--------+---+---+---------------------------------------------------------+
| 473723 | * | * | perl-Eval-Context                    | 2008-12-10T15:36:19  |
+
| 479218 | * | * | perl-DateTime-Format-Flexible                          |
|        |  |  | R: cweyl@alumni.drew.edu           |  NEW                |
+
|        |  |  |  NEW; last changed: 2009-01-08T00:57:33                |
|        |  |  | A: nobody@fedoraproject.org         |                      |
+
|        |  |  |   R: cweyl@alumni.drew.edu                             |
| 473718 | + | + | perl-Directory-Scratch-Structured    | 2009-01-04T15:31:53  |
+
|        |  |  |   A: nobody@fedoraproject.org                           |
|        |  |  | R: cweyl@alumni.drew.edu           |  ASSIGNED          |
+
| 479223 | * | * | perl-DateTime-Format-DateParse                          |
|        |  |  | A: panemade@gmail.com              |                     |
+
|        |  |  |  NEW; last changed: 2009-01-08T00:59:54                |
| 478780 | + | ? | perl-MooseX-Traits-Attribute-Cascad- | 2009-01-07T01:47:39  |
+
|        |  |  |   R: cweyl@alumni.drew.edu                             |
|        |  |  | eClear                              |  ASSIGNED          |
+
|        |  |  |  A: nobody@fedoraproject.org                          |
|        |  |  | R: cweyl@alumni.drew.edu           |                      |
+
| 473723 | ? | * | perl-Eval-Context                                      |
|        |  |  | A: panemade@gmail.com               |                      |
+
|        |  |  |  ASSIGNED; last changed: 2009-01-09T00:00:11           |
'--------+---+---+--------------------------------------+----------------------'
+
|        |  |  |   R: cweyl@alumni.drew.edu                              |
 +
|        |  |  |  A: wolfy@nobugconsulting.ro                          |
 +
| 478780 | + | + | perl-MooseX-Traits-Attribute-CascadeClear              |
 +
|        |  |  |  ASSIGNED; last changed: 2009-01-09T00:58:15           |
 +
|        |  |  |   R: cweyl@alumni.drew.edu                             |
 +
|        |  |  |   A: panemade@gmail.com                                 |
 +
'--------+---+---+---------------------------------------------------------'
 
</pre>
 
</pre>
  
Line 69: Line 75:
 
Review bug for perl-DateTime-Format-DateParse is: 479223
 
Review bug for perl-DateTime-Format-DateParse is: 479223
 
</pre>
 
</pre>
 +
 +
== Closing a completed review ==
 +
 +
<pre>
 +
[cweyl@athena bin]$ ./reviewtool close
 +
Finding our submitted bugs...
 +
Found bugs 479218, 479223, 473723, 478780.
 +
 +
Checking 479218 (perl-DateTime-Format-Flexible)...
 +
479218 not ready to close.
 +
 +
Checking 479223 (perl-DateTime-Format-DateParse)...
 +
479223 not ready to close.
 +
 +
Checking 473723 (perl-Eval-Context)...
 +
473723 not ready to close.
 +
 +
Checking 478780 (perl-MooseX-Traits-Attribute-CascadeClear)...
 +
478780 has been approved, branched, and is ready to close.
 +
Close 478780? y
 +
478780 closed.
 +
</pre>
 +
 +
The ''close'' command searches for your submitted review tix that are ready to close (fedora-review and fedora-cvs are both '+'); it then asks if you want to close.
  
 
= Reviewing Packages =
 
= Reviewing Packages =
  
 
[[Category:Perl]]
 
[[Category:Perl]]

Revision as of 15:40, 9 January 2009

Cog.png
This page needs some love
This page should be revised or reconstructed to be more helpful. Problems may include being out of step with current team or project status or process.

ReviewTool is a script designed to help with submitting and reviewing packages... It leverages the standard infrastructure tools (e.g., Koji, Bugzilla, fedorapeople.org) completely from one's own laptop, using no different or additional access to any to any tool than your id has.

Contents

Submitting Packages for Review

Status

[cweyl@athena bin]$ time ./reviewtool status
Retrieving status from bugzilla....

Fetching bugzilla data: 100% [===================================]D 0h00m05s

.--------+---+---+---------------------------------------------------------.
| Bug    | R | C | Name                                                    |
+--------+---+---+---------------------------------------------------------+
| 479218 | * | * | perl-DateTime-Format-Flexible                           |
|        |   |   |   NEW; last changed: 2009-01-08T00:57:33                |
|        |   |   |   R: cweyl@alumni.drew.edu                              |
|        |   |   |   A: nobody@fedoraproject.org                           |
| 479223 | * | * | perl-DateTime-Format-DateParse                          |
|        |   |   |   NEW; last changed: 2009-01-08T00:59:54                |
|        |   |   |   R: cweyl@alumni.drew.edu                              |
|        |   |   |   A: nobody@fedoraproject.org                           |
| 473723 | ? | * | perl-Eval-Context                                       |
|        |   |   |   ASSIGNED; last changed: 2009-01-09T00:00:11           |
|        |   |   |   R: cweyl@alumni.drew.edu                              |
|        |   |   |   A: wolfy@nobugconsulting.ro                           |
| 478780 | + | + | perl-MooseX-Traits-Attribute-CascadeClear               |
|        |   |   |   ASSIGNED; last changed: 2009-01-09T00:58:15           |
|        |   |   |   R: cweyl@alumni.drew.edu                              |
|        |   |   |   A: panemade@gmail.com                                 |
'--------+---+---+---------------------------------------------------------'

Submitting

[cweyl@athena bin]$ ./reviewtool submit ~/rpms/perl-DateTime-Format-DateParse/perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm 
Working on: (1 of 1) perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm
Searching bugzilla; this may take some time...
No existing review bug for perl-DateTime-Format-DateParse.
Starting koji scratch build.
...this may take some time.  We started at 2009-01-08T05:56:44
Running koji build -- this may take some time
Koji build done; we took 2 minutes, 46 seconds.

Pushing package and spec to fedorapeople...
perl-DateTime-Format-DateParse-0.04-1.fc10.sr 100%   17KB  17.4KB/s   00:00    
perl-DateTime-Format-DateParse.spec           100% 1627     1.6KB/s   00:00    
...done.

#!#!#!#!#!#!#!#!#!!#!#!!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#
Pkg:      perl-DateTime-Format-DateParse
Summary:  Parse Date::Parse compatible formats
SRPM:     perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm

// Begin request tix body //////////////////////////////////////////////
Spec URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-DateParse.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm

Description:
This module is a DateTime compatibility wrapper around Date::Parse; it allows
one to easily parse formats Date::Parse recognises for DateTime.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1039635

// End request tix body ////////////////////////////////////////////////

Post for review? y
Creating bug...
...done.

Review bug for perl-DateTime-Format-DateParse is: 479223

Closing a completed review

[cweyl@athena bin]$ ./reviewtool close
Finding our submitted bugs...
Found bugs 479218, 479223, 473723, 478780.

Checking 479218 (perl-DateTime-Format-Flexible)...
479218 not ready to close.

Checking 479223 (perl-DateTime-Format-DateParse)...
479223 not ready to close.

Checking 473723 (perl-Eval-Context)...
473723 not ready to close.

Checking 478780 (perl-MooseX-Traits-Attribute-CascadeClear)...
478780 has been approved, branched, and is ready to close.
Close 478780? y
478780 closed.

The close command searches for your submitted review tix that are ready to close (fedora-review and fedora-cvs are both '+'); it then asks if you want to close.

Reviewing Packages