Spots Review Cheat Sheet

From FedoraProject

Jump to: navigation, search

This is spot's Review cheat sheet. Basically, its something I can cut and paste, then edit as needed.

What can I say? I'm a lazy bum.

NO DEVEL

=

Good:

- rpmlint checks return:

- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

EXTRA STUFF FOR PACKAGES WITH DEVEL

==========================

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r