From Fedora Project Wiki
Line 109: Line 109:


== Benefit to Fedora ==
== Benefit to Fedora ==
<!-- What is the benefit to the distribution?  Will the software we generate be improved? How will the process of creating Fedora releases be improved?
 
      Be sure to include the following areas if relevant:
      If this is a major capability update, what has changed?
          For example: This change introduces Python 5 that runs without the Global Interpreter Lock and is fully multithreaded.
      If this is a new functionality, what capabilities does it bring?
          For example: This change allows package upgrades to be performed automatically and rolled-back at will.
      Does this improve some specific package or set of packages?
          For example: This change modifies a package to use a different language stack that reduces install size by removing dependencies.
      Does this improve specific Spins or Editions?
          For example: This change modifies the default install of Fedora Workstation to be more in line with the base install of Fedora Server.
      Does this make the distribution more efficient?
          For example: This change replaces thousands of individual %post scriptlets in packages with one script that runs at the end.
      Is this an improvement to maintainer processes?
          For example: Gating Fedora packages on automatic QA tests will make rawhide more stable and allow changes to be implemented more smoothly.
      Is this an improvement targeted as specific contributors?
          For example: Ensuring that a minimal set of tools required for contribution to Fedora are installed by default eases the onboarding of new contributors.


    When a Change has multiple benefits, it's better to list them all.
This change allows Fedora cloud instances to behave in the same way that Debian-based instances already behave. When users request package updates with a reboot now, `cloud-init` performs the update but never reboots the system. This is an unexpected and confusing result for users who come to Fedora from other distributions.


    Consider these Change pages from previous editions as inspiration:
Rebooting automatically could also reduce the attack surface of an instance that just came online since it would immediately reboot to put all package updates into effect on the system. This reduces the time that an unpatched instance is online prior to being fully patched.
    https://fedoraproject.org/wiki/Changes/Annobin (low-level and technical, invisible to users)
    https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo (low-level, but visible to advanced users)
    https://fedoraproject.org/wiki/Changes/VirtualBox_Guest_Integration (primarily a UX change)
    https://fedoraproject.org/wiki/Changes/NoMoreAlpha (an improvement to distro processes)
    https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack)
-->


== Scope ==
== Scope ==

Revision as of 14:16, 18 May 2023

Automatic Cloud Reboot On Updates

This is a proposed Change for Fedora Linux.
This document represents a proposed Change. As part of the Changes process, proposals are publicly announced in order to receive community feedback. This proposal will only be implemented if approved by the Fedora Engineering Steering Committee.

Summary

Cloud users can provide cloud-init metadata when creating a Fedora cloud instance and that metadata can contain instructions to update all packages on the system and reboot the system if any of those updated packages need a reboot to go into effect. Fedora cloud instances should write the /var/run/reboot-required file if a reboot is needed after a dnf update so that cloud-init can reboot the instance.

This issue originally surfaced in RHBZ 1275409.

Owner

Current status

  • Targeted release: Fedora Linux 39
  • Last updated: 2023-05-18
  • [<will be assigned by the Wrangler> devel thread]
  • FESCo issue: <will be assigned by the Wrangler>
  • Tracker bug: <will be assigned by the Wrangler>
  • Release notes tracker: <will be assigned by the Wrangler>

Detailed Description

Fedora cloud instances use cloud-init to do the initial configuration of the instance. This includes setting up networking, assigning a hostname, adding users/groups, and arbitrary scripts. There are also two options that you can pass to cloud-init that are important for this change:

  • package_update: If set to true, all installed packages are immediately updated on first boot
  • package_reboot_if_required: If set to true, and the package_update step wrote to /var/run/reboot-required, reboot the system immediately after updating packages

📚 For more details, see cloud-init's module reference for package_update.

Where does this /var/run/reboot-required file come from? On Debian and Ubuntu systems, apt automatically writes to /var/run/reboot-required if a reboot is needed after a package update. From there, cloud-init looks for the file (relevant cloud-init code) and if present, reboots the system immediately.

How do we write this file on Fedora? Fedora systems have a package called tracer and a corresponding dnf plugin, python3-dnf-plugin-tracer, that analyzes dnf updates and provides recommendations on reboots or user logouts to bring updates into effect on the system. A recent pull request added support for writing the /var/run/reboot-required file when a system reboot is recommended. The cloud-init tool can read this file after a package update and reboot if needed.

What does tracer's output look like?

   [root@tracer-testing ~]# tracer 
   You should restart:
   * Some applications using:
       sudo systemctl restart NetworkManager
       sudo systemctl restart auditd
       sudo systemctl restart chronyd
       sudo systemctl restart dbus-broker
       sudo systemctl restart qemu-guest-agent
       sudo systemctl restart sshd
       sudo systemctl restart systemd-journald
       sudo systemctl restart systemd-logind
       sudo systemctl restart systemd-oomd
       sudo systemctl restart systemd-resolved
       sudo systemctl restart systemd-udevd
       sudo systemctl restart systemd-userdbd
   
   * These applications manually:
       (sd-pam)
   
   Additionally, there are:
   - 3 processes requiring restart of your session (i.e. Logging out & Logging in again)
   - 1 processes requiring reboot
   [root@tracer-testing ~]# cat /var/run/reboot-required 
   Tracer says reboot is required

What do we need to do? Add the python3-dnf-plugin-tracer plugin to Fedora cloud images. No additional configuration is necessary. This action pulls in five packages that are about 2.1MB after installation:

   =======================================================================================
   Package                               Arch       Version             Repository  Size
   =======================================================================================
   Installing:
   python3-dnf-plugin-tracer             noarch     4.1.0-1.fc38        fedora      14 k
   Installing dependencies:
   python3-dnf-plugins-extras-common     noarch     4.1.0-1.fc38        fedora      69 k
   python3-psutil                        x86_64     5.9.2-2.fc38        fedora     271 k
   python3-tracer                        noarch     0.7.8-5.fc38        fedora     172 k
   tracer-common                         noarch     0.7.8-5.fc38        fedora      22 k
   
   Transaction Summary
   =======================================================================================
   Install  5 Packages
   
   Total download size: 547 k
   Installed size: 2.1 M

Feedback

One of the other ideas was to patch cloud-init to run tracer directly and avoid the /var/run/reboot-required file altogether. That would require a lot of work upstream in cloud-init to enable the functionality and we would still need the same set of packages installed in Fedora anyway.

Benefit to Fedora

This change allows Fedora cloud instances to behave in the same way that Debian-based instances already behave. When users request package updates with a reboot now, cloud-init performs the update but never reboots the system. This is an unexpected and confusing result for users who come to Fedora from other distributions.

Rebooting automatically could also reduce the attack surface of an instance that just came online since it would immediately reboot to put all package updates into effect on the system. This reduces the time that an unpatched instance is online prior to being fully patched.

Scope

  • Proposal owners:
  • Other developers:
  • Policies and guidelines: N/A (not needed for this Change)
  • Trademark approval: N/A (not needed for this Change)
  • Alignment with Community Initiatives:

Upgrade/compatibility impact

How To Test

User Experience

Dependencies

Contingency Plan

  • Contingency mechanism: (What to do? Who will do it?) N/A (not a System Wide Change)
  • Contingency deadline: N/A (not a System Wide Change)
  • Blocks release? N/A (not a System Wide Change), Yes/No


Documentation

N/A (not a System Wide Change)

Release Notes