From Fedora Project Wiki

(daemon finish)
(Progress: comps)
 
(19 intermediate revisions by 2 users not shown)
Line 3: Line 3:




{{admon/important|This is important|THIS CHANGE SHOULD HAPPEN IN RAWHIDE FOR FEDORA 14 ONLY.}}
{{admon/important|This is important|THIS CHANGE SHOULD HAPPEN IN RAWHIDE ONLY.}}


== How ==
== How ==
Line 37: Line 37:
!Package !! Owner !! Dependencies !! Status
!Package !! Owner !! Dependencies !! Status
|-
|-
| commons-collections || devrim || None || '''<span style="color:red">TODO</span> '''
| commons-collections || devrim/carl || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=628280]</span> '''
|-
|-
| commons-compress || [[User:Red|Red]] || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=589504]</span> '''
| commons-compress || [[User:Red|Red]] || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=589504]</span> '''
Line 45: Line 45:
| commons-codec || [[User:mbooth|mbooth]] || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=591298]</span> '''
| commons-codec || [[User:mbooth|mbooth]] || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=591298]</span> '''
|-
|-
| commons-launcher || [[User:mbooth|mbooth]] || None || '''<span style="color:blue">ON REVIEW [https://bugzilla.redhat.com/show_bug.cgi?id=592614]</span> '''
| commons-launcher || [[User:mbooth|mbooth]] || None || '''<span style="color:green">DONE [https://bugzilla.redhat.com/show_bug.cgi?id=592614]</span> '''
|-
|-
| commons-pool || [[User:mbooth|mbooth]] || None || '''<span style="color:red">TODO</span> '''
| commons-pool || [[User:spike|spike]] || None || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=639529]</span> '''
|-
|-
| commons-logging || sochotni || None || '''<span style="color:green">DONE [https://bugzilla.redhat.com/show_bug.cgi?id=589168]</span> '''  
| commons-logging || sochotni || None || '''<span style="color:green">DONE [https://bugzilla.redhat.com/show_bug.cgi?id=589168]</span> '''  
Line 65: Line 65:
| commons-beanutils || sochotni || collections, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=594756]</span> '''
| commons-beanutils || sochotni || collections, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=594756]</span> '''
|-
|-
| commons-cli || jmrodri || lang, logging || '''<span style="color:red">TODO</span> '''
| commons-cli || [[User:spike|spike]] || lang, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=639719]</span> '''
|-
|-
| commons-jxpath || sochotni || beanutils, collections, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=595749]</span> '''
| commons-jxpath || sochotni || beanutils, collections, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=595749]</span> '''
|-
|-
| commons-dbcp || [[User:mbooth|mbooth]] || collections, pool || '''<span style="color:red">TODO</span> '''
| commons-dbcp || [[User:spike|spike]] || collections, pool || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=640215]</span> '''
|-
|-
| commons-digester || [[User:mbooth|mbooth]] || beanutils, logging || '''<span style="color:green">DONE [https://bugzilla.redhat.com/show_bug.cgi?id=591305]</span> '''
| commons-digester || [[User:mbooth|mbooth]] || beanutils, logging || '''<span style="color:green">DONE [https://bugzilla.redhat.com/show_bug.cgi?id=591305]</span> '''
|-
|-
| commons-modeler || [[User:mbooth|mbooth]] || beanutils, collections, digester, logging || '''<span style="color:red">TODO</span> '''
| commons-modeler || [[User:mbooth|mbooth]] || beanutils, collections, digester, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=639678] '''
|-
|-
| commons-validator || [[User:mbooth|mbooth]] || beanutils, collections, digester, logging || '''<span style="color:red">TODO</span> '''
| commons-validator || [[User:mbooth|mbooth]] || beanutils, collections, digester, logging || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=639671]</span> '''
|-
|-
| commons-configuration || sochotni || beanutils, codec, collections, dbcp, digester, jxpath, lang, logging, pool || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=596866]</span> '''
| commons-configuration || sochotni || beanutils, codec, collections, dbcp, digester, jxpath, lang, logging, pool || '''<span style="color:green">DONE[https://bugzilla.redhat.com/show_bug.cgi?id=596866]</span> '''
Line 82: Line 82:


* jakarta-commons-httpclient - It is not part of apache commons but a top-level project. As a result we will leave jakarta-commons-httpclient package for now and package the new one allowing the 2 to coexist.
* jakarta-commons-httpclient - It is not part of apache commons but a top-level project. As a result we will leave jakarta-commons-httpclient package for now and package the new one allowing the 2 to coexist.
== Progress details ==
{| class="wikitable sortable" border="1"
|-
! scope="col" | Package
! scope="col" | rawhide build
! scope="col" | bug closed
! scope="col" | dead.package
! scope="col" | comps
! scope="col" | retired in pkgdb
! scope="col" | rel-eng ticket
|-
|commons-beanutils    || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10390] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=594756] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-beanutils.git;a=tree;]      || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-beanutils]    || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4037]
|-
|commons-cli          || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=11063] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=639719] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-cli.git;a=tree;]            || {{result|warn}} not present || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-cli]          || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|-
|commons-codec        || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10356] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=591298] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-codec.git;a=tree;]          || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-codec]        || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/3750]
|-
|commons-collections  || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10877] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=628280] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-collections.git;a=tree;]    || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-collections]  || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|-
|commons-compress      || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10319] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=589504] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-compress.git;a=tree;]        || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-compress]      || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/3747]
|-
|commons-configuration || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10418] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=596866] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-configuration.git;a=tree;]  || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-configuration] || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-daemon        || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10447] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=592208] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-daemon.git;a=tree;]          || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-daemon]        || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-dbcp          || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=11064] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=640215] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-dbcp.git;a=tree;]            || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-dbcp]          || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|-
|commons-digester      || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10399] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=591305] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-digester.git;a=tree;]        || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-digester]      || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/3766]
|-
|commons-discovery    || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10320] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=589617] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-discovery.git;a=tree;]      || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-discovery]    || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4217]
|-
|commons-el            || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10391] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=595676] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-el.git;a=tree;]              || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-el]            || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-fileupload    || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10384] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=594040] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-fileupload.git;a=tree;]      || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-fileupload]    || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-io            || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10335] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=591024] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-io.git;a=tree;]              || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-io]            || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-jxpath        || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10392] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=595749] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-jxpath.git;a=tree;]          || {{result|warn}} not present || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-jxpath]        || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-lang          || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10336] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=590660] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-lang.git;a=tree;]            || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-lang]          || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-launcher      || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10450] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=592614] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-launcher.git;a=tree;]        || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-launcher]      || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/3784]
|-
|commons-logging      || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10304] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=589168] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-logging.git;a=tree;]        || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-logging]      || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/3739]
|-
|commons-modeler      || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=11110] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=639678] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-modeler.git;a=tree;]        || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-modeler]      || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|-
|commons-net          || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=10357] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=591545] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-net.git;a=tree;]            || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-net]          || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4128]
|-
|commons-pool          || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=11065] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=639529] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-pool.git;a=tree;]            || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-pool]          || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|-
|commons-validator    || {{result|pass}} [http://koji.fedoraproject.org/koji/packageinfo?packageID=11074] || {{result|pass}} [http://bugzilla.redhat.com/show_bug.cgi?id=639671] || {{result|pass}} [http://pkgs.fedoraproject.org/gitweb/?p=jakarta-commons-validator.git;a=tree;]      || {{result|pass}}            || {{result|pass}} [http://admin.fedoraproject.org/pkgdb/acls/name/jakarta-commons-validator]    || {{result|pass}} [http://fedorahosted.org/rel-eng/ticket/4244]
|}

Latest revision as of 19:33, 3 November 2010

Jakarta-commons rename to apache-commons

This page hosts information about the next rename of jakarta-commons packages[1] to apache-commons[2].


This is important
THIS CHANGE SHOULD HAPPEN IN RAWHIDE ONLY.

How

This part should give you information how to rename and rebase your jakarta package to create a new apache one.

  • check if new upstream version exists, if so...use it
  • rename spec file (pretty obvious eh?)
  • add BuildArch: noarch
  • replace %define with %global (this policy is newer then jakarta spec files) and define substitute names. For example
    • %global base_name logging
    • %global short_name commons-%{base_name}
  • make sure Source0 URL, project URL etc all use macros for name/version of the package
  • strip changelog (and create your own stating that this is rename of jakarta- package)
  • add Provides/Obsoletes for package (! also for javadoc sub-packages)
    • you might need to add new Epoch so that package can replace jakarta-commons version with same version
    • for javadoc sub-packages it is enough to obsolete
  • be sure to add java-devel to BR/R, otherwise things can fail because normally gcj devel version is pulled in
  • build package with maven if there is usable pom.xml file
    • you will need additional R/BR in specfile.
    • in special cases depmap might need to be created (see apache-commons-logging for example)
    • in some cases tests can fail due to various reason. Until maven is updated this can be worked around by adding -Dmaven.test.skip=true to mvn-jpp
    • if the pom file depends on maven-release-plugin you will have to patch it out of pom. This is provided by maven2 package for now (review bug open for separate plugin as of now)
    • call %add_to_maven_depmap GROUP_ID ARTIFACT_ID %{version} JPP %{name}
      • GROUP_ID/ARTIFACT_ID are in maven repositories. You should leave also older calls to add_maven_depmap if it uses wrong GROUP_ID/ARTIFACT_ID to ensure backward compatibility
      • if original jakarta-commons package didn't provide pom file, make sure that entry for this package is removed from maven2-common-poms and include backward compatible add_to_maven_depmap
  • make sure you are creating all needed symlinks in _javadocdir/javadir
  • standard packaging guidelines apply of course

Progress

Following table lists packages in jakarta-commons, their cross-dependencies and owners responsible for them. Packages with no dependencies can be renamed immediately. Others should wait for their dependencies to rename first.

Package Owner Dependencies Status
commons-collections devrim/carl None DONE[3]
commons-compress Red None DONE[4]
commons-el sochotni None DONE[5]
commons-codec mbooth None DONE[6]
commons-launcher mbooth None DONE [7]
commons-pool spike None DONE[8]
commons-logging sochotni None DONE [9]
commons-discovery sochotni logging DONE [10]
commons-daemon sochotni None DONE [11]
commons-io sochotni None DONE [12]
commons-fileupload sochotni io DONE [13]
commons-lang sochotni None DONE [14]
commons-net sochotni None DONE [15]
commons-beanutils sochotni collections, logging DONE[16]
commons-cli spike lang, logging DONE[17]
commons-jxpath sochotni beanutils, collections, logging DONE[18]
commons-dbcp spike collections, pool DONE[19]
commons-digester mbooth beanutils, logging DONE [20]
commons-modeler mbooth beanutils, collections, digester, logging DONE[21]
commons-validator mbooth beanutils, collections, digester, logging DONE[22]
commons-configuration sochotni beanutils, codec, collections, dbcp, digester, jxpath, lang, logging, pool DONE[23]


  • jakarta-commons-httpclient - It is not part of apache commons but a top-level project. As a result we will leave jakarta-commons-httpclient package for now and package the new one allowing the 2 to coexist.



Progress details

Package rawhide build bug closed dead.package comps retired in pkgdb rel-eng ticket
commons-beanutils
Pass pass
[24]
Pass pass
[25]
Pass pass
[26]
Pass pass
Pass pass
[27]
Pass pass
[28]
commons-cli
Pass pass
[29]
Pass pass
[30]
Pass pass
[31]
Warning warn
not present
Pass pass
[32]
Pass pass
[33]
commons-codec
Pass pass
[34]
Pass pass
[35]
Pass pass
[36]
Pass pass
Pass pass
[37]
Pass pass
[38]
commons-collections
Pass pass
[39]
Pass pass
[40]
Pass pass
[41]
Pass pass
Pass pass
[42]
Pass pass
[43]
commons-compress
Pass pass
[44]
Pass pass
[45]
Pass pass
[46]
Pass pass
Pass pass
[47]
Pass pass
[48]
commons-configuration
Pass pass
[49]
Pass pass
[50]
Pass pass
[51]
Pass pass
Pass pass
[52]
Pass pass
[53]
commons-daemon
Pass pass
[54]
Pass pass
[55]
Pass pass
[56]
Pass pass
Pass pass
[57]
Pass pass
[58]
commons-dbcp
Pass pass
[59]
Pass pass
[60]
Pass pass
[61]
Pass pass
Pass pass
[62]
Pass pass
[63]
commons-digester
Pass pass
[64]
Pass pass
[65]
Pass pass
[66]
Pass pass
Pass pass
[67]
Pass pass
[68]
commons-discovery
Pass pass
[69]
Pass pass
[70]
Pass pass
[71]
Pass pass
Pass pass
[72]
Pass pass
[73]
commons-el
Pass pass
[74]
Pass pass
[75]
Pass pass
[76]
Pass pass
Pass pass
[77]
Pass pass
[78]
commons-fileupload
Pass pass
[79]
Pass pass
[80]
Pass pass
[81]
Pass pass
Pass pass
[82]
Pass pass
[83]
commons-io
Pass pass
[84]
Pass pass
[85]
Pass pass
[86]
Pass pass
Pass pass
[87]
Pass pass
[88]
commons-jxpath
Pass pass
[89]
Pass pass
[90]
Pass pass
[91]
Warning warn
not present
Pass pass
[92]
Pass pass
[93]
commons-lang
Pass pass
[94]
Pass pass
[95]
Pass pass
[96]
Pass pass
Pass pass
[97]
Pass pass
[98]
commons-launcher
Pass pass
[99]
Pass pass
[100]
Pass pass
[101]
Pass pass
Pass pass
[102]
Pass pass
[103]
commons-logging
Pass pass
[104]
Pass pass
[105]
Pass pass
[106]
Pass pass
Pass pass
[107]
Pass pass
[108]
commons-modeler
Pass pass
[109]
Pass pass
[110]
Pass pass
[111]
Pass pass
Pass pass
[112]
Pass pass
[113]
commons-net
Pass pass
[114]
Pass pass
[115]
Pass pass
[116]
Pass pass
Pass pass
[117]
Pass pass
[118]
commons-pool
Pass pass
[119]
Pass pass
[120]
Pass pass
[121]
Pass pass
Pass pass
[122]
Pass pass
[123]
commons-validator
Pass pass
[124]
Pass pass
[125]
Pass pass
[126]
Pass pass
Pass pass
[127]
Pass pass
[128]