m (Minor grammar fix.) |
(Example spec: don't glob everything under the sitelib directories. https://pagure.io/packaging-committee/issue/793) |
||
Line 330: | Line 330: | ||
%license COPYING | %license COPYING | ||
%doc README.rst | %doc README.rst | ||
%{python2_sitelib}/ | %{python2_sitelib}/%{srcname}/ | ||
%files -n python3-%{srcname} | %files -n python3-%{srcname} | ||
%license COPYING | %license COPYING | ||
%doc README.rst | %doc README.rst | ||
%{python3_sitelib}/ | %{python3_sitelib}/%{srcname}/ | ||
%{_bindir}/sample-exec | %{_bindir}/sample-exec | ||
Revision as of 16:47, 8 September 2018
Python Version Support
In Fedora we have multiple Python runtimes, one for each supported major Python release. At this point that's one for python3.x and one for python2.7 However, it is possible that the python2 stack will be removed from Fedora when support for the python2 interpreter officially ends in 2020. If a piece of software supports python3, it MUST be packaged for python3. If it supports python2 as well, it MAY be packaged for python2. If it supports only python2 then (obviously) it MUST NOT be packaged for python3 but upstream SHOULD be contacted and encouraged to rectify this issue.
Multiple Python Runtimes
Each runtime corresponds to a binary of the form /usr/bin/python$MAJOR.$MINOR
. One of these python runtimes is the "system runtime" which is what is run when invoking /usr/bin/python
. On Fedora 27, for example, this is a link to /usr/bin/python2
(which itself is a link to /usr/bin/python2.7
).
However, packages in Fedora MUST NOT depend on where /usr/bin/python
happens to point but instead MUST call the proper executable for the needed python major version directly, either /usr/bin/python2
or /usr/bin/python3
as appropriate. As a result of that /usr/bin/python
(as well as /usr/bin/env python
and similar) MUST NOT be used in shebang lines or as a dependency of a package. As of Fedora 28, all uses of unversioned python executables in shebang lines are automatically converted to /usr/bin/python2
. When this is done, warnings such as the following may appear in the build log:
*** WARNING: mangling shebang in ./usr/bin/taskotron_result from #!/usr/bin/python to #!/usr/bin/python2. This will become an ERROR, fix it manually!
These MUST be fixed manually, as the warnings will eventually become errors which fail the build. If it is necessary to disable the checks, please see the information in Packaging:Guidelines#Shebang_lines.
All python runtimes have a virtual provide for python(abi) = $MAJOR-$MINOR
. For example, the python-3.4 runtime package has:
$ rpm -q --provides python3 |grep -i abi python(abi) = 3.4
python modules using these runtimes should have a corresponding "Requires" line on the python runtime that they are used with. This is done automatically for files below /usr/lib[^/]*/python${PYVER}
Mirroring the policy for regular packages, the Python-version-specific subpackages of your package MUST NOT be removed in a release branch of Fedora.
Dependencies
Packages building for Python2 will need BuildRequires: python2-devel
.
Packages building for Python3 will need BuildRequires: python3-devel
.
Packages building for for both will need build-time dependencies on both.
Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python-
prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2-
or python3-
as appropriate.
Automatically generated dependencies
Packages MAY use the automatic Python dependency generator. This generator uses upstream egg/dist metadata (such as setuptool's install_requires) to determine what the package should depend on. The generator parses the installed metadata from /usr/lib(64)?/pythonX.Y/site-packages/<module>-<version>-pyX.Y.(egg|dist)-info/requires.txt
, so it will not work with software that uses plain distutils.
To enable this feature, add:
%{?python_enable_dependency_generator}
Although this statement can be used anywhere in the spec, we recommend putting it just before the main package's %description
declaration.
This generates run time requires in the form of pythonX.Ydist(foo)
. If the generated dependencies are not accurate, additional ones can still be added manually. To remove some, a packager MAY modify upstream-provided metadata (usually specified in the setup.py
file) in the %prep
section of the specfile or fall back to filtering those dependencies.
The packager MUST inspect the generated requires for correctness. All dependencies MUST be resolvable within the targeted Fedora version.
As an example, the upstream notebook package has (as of version 5.6.0):
install_requires = [ 'jinja2', 'tornado>=4', 'pyzmq>=17', 'ipython_genutils', 'traitlets>=4.2.1', 'jupyter_core>=4.4.0', 'jupyter_client>=5.2.0', 'nbformat', 'nbconvert', 'ipykernel', 'Send2Trash', 'terminado>=0.8.1', 'prometheus_client' ],
And the resulting
dependencies:
python3-notebook
python3.7dist(ipykernel) python3.7dist(ipython-genutils) python3.7dist(jinja2) python3.7dist(jupyter-client) >= 5.2.0 python3.7dist(jupyter-core) >= 4.4.0 python3.7dist(nbconvert) python3.7dist(nbformat) python3.7dist(prometheus-client) python3.7dist(pyzmq) >= 17 python3.7dist(send2trash) python3.7dist(terminado) >= 0.8.1 python3.7dist(tornado) >= 4 python3.7dist(traitlets) >= 4.2.1
This generator will most likely be enabled by default in the future. If a packager wishes to explicitly opt out of the generator because the upstream metadata are not applicable, a packager MUST NOT assume that the generator won't be used simply because it is not enabled explicitly. Rather, they SHOULD opt out explicitly by adding:
%{?python_disable_dependency_generator}
Provides
Using a fictional module named "example", the subpackage containing the python2 version must provide python2-example
. This is of course always the case if the subpackage is named python2-example
(as in the examples below). If the subpackage has some other name then then Provides: python2-example
must be added explicitly (but see the %python_provide
macro below).
The python3 subpackage must provide python3-example
. However, as the naming guidelines mandate that the python3 subpackage be named python3-example
, this will happen automatically.
The %python_provide macro
In addition, the subpackage corresponding to the current system runtime must provide Provides: python-example
. However, the system version of python in Fedora will almost certainly change at some point in the future.
To avoid having to alter every python module package when this change happens, and to allow the same spec to build for releases with different system versions of python, a convenient %python_provide
macro is provided. When given (as an argument) the name of the current subpackage, it will evaluate to either the proper Provide:
line or nothing at all as appropriate for the version of the system runtime. Thus if the package follows the suggested subpackage naming scheme as shown in the below example, placing this macro in the definition of each subpackage will guarantee that the necessary Provide:
line appears where it should, and does not appear where it shouldn't.
If %python_provide
is called with an argument beginning with python2-
, it will also generate a suitable Obsoletes:
line for the unversioned python-
package. This facilitate renaming those unversioned subpackages.
Finally, if the macro called with an argument like python-example
(no python major version in the name) then it will evaluate to either Provides: python2-example
or Provides: python3-example
depending on the version of the current system runtime.
Automatic Provides with a standardized name
When building a Python package, RPM looks for .dist-info
and .egg-info
files or directories in the %files
sections of all packages. If one or more are found, RPM parses them to find the standardized name (i.e. dist name, name on PyPI) of the packaged software, and then automatically creates two Provides:
tags in the following format:
Provides: pythonX.Ydist(CANONICAL_STANDARDIZED_NAME) Provides: pythonXdist(CANONICAL_STANDARDIZED_NAME)
The X
and X.Y
are the Python version used (usually 2.7 or 3.5 and higher), and between the parentheses is the name of the software in a canonical format used by Python tools and services such as setuptools, pip and PyPI. The canonical name is obtained by switching the standardized name to lower case and converting all runs of non-alphanumeric characters to single “-” characters. Example: “The $$$ Tree” becomes “the-tree”.
Requires and BuildRequires with standardized names
Starting with Fedora 26, these Provides tags can be used to list Requires and BuildRequires of a package using the standardized names (i.e. dist name, name on PyPI) of Python modules. To make it easier, you can use macros %{py2_dist}
and %{py3_dist}
that accept one or more parameters: the standardized name(s) of the desired Python software. They will convert the name(s) to the canonical format and create the proper pythonXdist(...)
tag(s).
In addition, you can use the %{py_dist_name} macro that simply transforms any standardized name to the canonical format.
For example:
BuildRequires: %{py2_dist PyMySQL} >= 0.7.5 # => BuildRequires: python2dist(pymysql) >= 0.7.5 Requires: %{py3_dist virtualenv pyPEG2} # => Requires: python3dist(virtualenv) python3dist(pypeg2) %{py_dist_name 0-._.-._.-._.-._.-._.-._.-0} # => 0-0
Source Files from PyPI
When packaging software which is available from PyPI, you can make use of the %pypi_source
macro. This macro accepts from zero to three arguments and evaluates to an appropriate URL for the source file on PyPI. The arguments are:
- The name of the PyPI project. Defaults to
%srcname
if defined, or to%pypi_name
if defined, or to%name
(the package name). - The version of the PyPI project. Defaults to
%version
(the package version). - The file extension to use. Defaults to
tar.gz
.
In most cases it is not necessary to specify any arguments.
Macros
The following macros are defined for you in all supported Fedora and EPEL releases:
Macro | Normal Definition | Notes |
---|---|---|
__python | /usr/bin/python | Prohibited (see note below) |
__python2 | /usr/bin/python2 | Python 2 interpreter. |
__python3 | /usr/bin/python3 | Python 3 interpreter |
python_provide | (Lua script) | Given a package name, evaluates to either Provides: python-example or nothing at all depending on the version of the system runtime. See here for an example.
|
py2_dist | (Lua script) | Given a standardized name (i.e. dist name, name on PyPI) of Python software, it will convert it to a canonical format, and evaluates to python2dist(CANONICAL_NAME) , which is useful when listing dependencies. See above for more information.
|
python2_sitelib | /usr/lib/python2.X/site-packages | Where pure python2 modules are installed |
python2_sitearch | /usr/lib64/python2.X/site-packages on x86_64 /usr/lib/python2.X/site-packages on x86 |
Where python2 extension modules that are compiled C are installed |
python3_sitelib | /usr/lib/python3.X/site-packages | Where pure python3 modules are installed |
python3_sitearch | /usr/lib64/python3.X/site-packages on x86_64 /usr/lib/python3.X/site-packages on x86 |
Where python3 extension modules that are compiled C are installed |
py3_dist | (Lua script) | Given a standardized name (i.e. dist name, name on PyPI) of Python software, it will convert it to a canonical format, and evaluates to python3dist(CANONICAL_NAME) , which is useful when listing dependencies. See above for more information.
|
py_byte_compile | (script) | Defined in python3-devel. See the byte compiling section for usage |
python3_version | 3.X | Defined in python3-devel. Useful when running programs with Python version in filename, such as nosetest-%{python3_version} |
python3_version_nodots | 3X | Defined in python3-devel. Useful when listing files explicitly in %files section , such as %{python3_sitelib}/foo/*.cpython-%{python3_version_nodots}.pyo |
py2_build | %{__python2} setup.py build ... | Various flags are added, see /usr/lib/rpm/macros.d/macros.python2 for details and similar macros. Define %py_setup_args to pass custom command line arguments to setup.py. |
py2_install | %{__python2} setup.py install --skip-build ... | |
py3_build | %{__python3} setup.py build ... | Various flags are added, see /usr/lib/rpm/macros.d/macros.python3 for details and similar macros. Define %py_setup_args to pass custom command line arguments to setup.py. |
py3_install | %{__python3} setup.py install --skip-build ... | |
py_dist_name | (Lua script) | Given a standardized name (i.e. dist name, name on PyPI) of Python software, it will convert it to a canonical format. See above for more information. |
pypi_source | (Lua script) | Evaluates to the appropriate URL for the package. See above for more information. |
During %install
or when listing %files
you can use the python2_sitearch
and python2_sitelib
macros to specify where the installed modules are to be found. For instance:
%files # A pure python2 module %{python2_sitelib}/foomodule/ # A compiled python2 extension module %{python2_sitearch}/barmodule/ # A compiled python3 extension module %{python3_sitearch}/bazmodule/
Use of the macros has several benefits:
- It ensures that the packages are installed correctly on multilib architectures.
- Using these macros instead of hardcoding the directory in the specfile ensures your spec remains compatible with the installed python version even if the directory structure changes radically (for instance, if
python2_sitelib
moves into%{_datadir}
).
Files to include
When packaging python modules, several types of files are included:
- *.py source files because they are used when generating tracebacks.
- *.pyc and *.pyo byte compiled files (and, if present, the enclosing __pycache__ directory in most cases).
- Python will try to create them at runtime if they don't exist which leads to spurious SELinux AVC denials in the logs.
- If the system administrator invokes python with -OO, .pyos will be created with no docstrings. This can break some programs.
- *.egg-info files or directories. If these are generated by the module's build scripts they must be included in the package because they might be needed by other applications and modules at runtime.
The source files must be included in the same package as the byte compiled versions.
Byte compiling
Python will automatically try to byte compile files when it runs in order to speed up startup the next time it is run. These files are saved in files with the extension of .pyc (compiled python) or .pyo (optimized compiled python). With current versions of python 3, these files will be located inside a directory named __pycache__
. Older versions of python will simply place them alongside the .py files.
The .pyc and .pyo files contain byte code that is portable across OSes. If you do not include them in your packages, python will try (and generally fail) to create them when the user runs the program. If the system administrator runs the program, then the files will be successfully written, causing stray .pyc and .pyo files which will not be removed when the package is removed. To prevent that the byte compiled files need to be compiled and included in the %files
section. Normally, byte compilation is done for you by the brp-python-bytecompile
script. This script runs after the %install
section of the spec file has been processed and byte compiles any .py files that it finds (this recompilation puts the proper filesystem paths into the modules otherwise tracebacks would include the %{buildroot}
in them).
You must include in your package the .pyc and .pyo files. If the build process creates a __pycache__ directory in a subdirectory of %{python3_sitearch} or %{python3_sitelib}, you must also include all items in the __pycache__ directory. You MUST NOT include the directories %{python3_sitearch}/__pycache__ or %{python3_sitelib}/__pycache__ because they are already owned by the python3-libs package.
All that you need to do is include the files in the %files
section (replacing %{python3_sitelib} with the appropriate macro for your package):
%files %{python3_sitelib}/foo/
or, if the python code installs directly into %{python3_sitelib}:
%files %{python3_sitelib}/foo.py %{python3_sitelib}/__pycache__/*
Optimization
Fedora packages running with 2 MUST NOT invoke python with the -OO
option or set the environment variable PYTHONOPTIMIZE
to 2 or greater. (Using -O or PYTHONOPTIMIZE
less than 2 is fine, though unnecessary.)
Similarly, any .pyo
shipped in a Fedora package for Python 2 MUST NOT have been byte compiled using optimization level 2 or higher.
Manual byte compilation
For more details on the internals of byte compilation, please see the appendix.
Common SRPM vs split SRPMs
Many times when you package a python module you will want to create a module for python2 and a module for python3. Both versions should be built from the same SRPM. An exception to this would be if the two versions are distributed as separate archives and do not follow the same release schedule.
Example common spec file
The following is a very simple spec file for a module building for both python2 and python3. It builds both versions in the same directory; this is possible because the build products for different versions of Python usually do not conflict.
There are cases where it is not possible to build in a single directory. Most
commonly this happens when the sources are modified during the build process to
convert them from python2 to python3 using the the 2to3
tool. In
that case, please see the appendix.
As you can see in the %install
section below, the order in which
you do the python2 versus python3 install can sometimes matter. You need to be
aware of when the install is writing to the same file in both packages (in this
example, a script in %{_bindir}
and make sure that you're getting
the version you expect.
%global srcname example Name: python-%{srcname} Version: 1.2.3 Release: 1%{?dist} Summary: An example python module License: MIT URL: https://pypi.python.org/pypi/%{srcname} Source0: %pypi_source BuildArch: noarch BuildRequires: python2-devel python3-devel %description An python module which provides a convenient example. %package -n python2-%{srcname} Summary: %{summary} %{?python_provide:%python_provide python2-%{srcname}} %description -n python2-%{srcname} An python module which provides a convenient example. %package -n python3-%{srcname} Summary: %{summary} %{?python_provide:%python_provide python3-%{srcname}} %description -n python3-%{srcname} An python module which provides a convenient example. %prep %autosetup -n %{srcname}-%{version} %build %py2_build %py3_build %install # Must do the python2 install first because the scripts in /usr/bin are # overwritten with every setup.py install, and in general we want the # python3 version to be the default. # If, however, we're installing separate executables for python2 and python3, # the order needs to be reversed so the unversioned executable is the python2 one. %py2_install %py3_install %check %{__python2} setup.py test %{__python3} setup.py test # Note that there is no %%files section for the unversioned python module if we are building for several python runtimes %files -n python2-%{srcname} %license COPYING %doc README.rst %{python2_sitelib}/%{srcname}/ %files -n python3-%{srcname} %license COPYING %doc README.rst %{python3_sitelib}/%{srcname}/ %{_bindir}/sample-exec %changelog
Avoiding collisions between the python 2 and python 3 stacks
The python 2 and python 3 stacks are intended to be fully-installable in parallel. When generalizing the package for both python 2 and python 3, it is important to ensure that two different built packages do not attempt to place different payloads into the same path.
Executables in /usr/bin
Many existing python packages install executables into /usr/bin
.
For example if we have a console_scripts
in a setup.py
shared between
python 2 and python 3 builds: these will spit out files in /usr/bin/
,
and these will collide.
For example python-coverage
has a setup.py
that contains:
entry_points = { 'console_scripts': [ 'coverage = coverage:main', ] },
which thus generates a /usr/bin/coverage
executable (this is a python
script that runs another python script whilst generating code-coverage
information on the latter).
Similarly for the 'scripts' clause; see e.g. python-pygments
:
Pygments-1.1.1/setup.py
has:
scripts = ['pygmentize'],
which generates a /usr/bin/pygmentize
(this is a python script that leverages the pygments syntax-highlighting module, giving a simple command-line interface for generating syntax-highlighted files)
If the executables provide the same functionality independent of whether they are run on top of Python 2 or Python 3, then only the Python 3 version of the executable should be packaged. Transitioning from python2 to python3 is left to individual package maintainers except for packages in Fedora's critical path. For these, we want to port to python3 versions in the same Fedora release if possible.
Examples of this:
/usr/bin/pygmentize
ought to generate the same output regardless of whether it's implemented via Python 2 or Python 3, so only one version needs to be shipped.
If the executables provide different functionality for Python 2 and Python 3, then both versions should be packaged.
Examples of this:
/usr/bin/coverage
runs a python script, augmenting the interpreter with code-coverage information. Given that the interpreter itself is the thing being worked with, it's reasonable to package both versions of the executable./usr/bin/bpython
augments the interpreter with a "curses" interface. Again, it's reasonable to package both versions of this./usr/bin/easy_install
installs a module into one of the Python runtimes: we need a version for each runtime.
Naming
Many executables already contain a "-MAJOR.MINOR" suffix, for example /usr/bin/easy_install-3.4
. These obviously can be used as-is, as they won't conflict.
For other executables, the general rule is:
- If only one executable is to be shipped, then it owns its own slot and should use /usr/bin/python3 from Fedora 22 on.
- If executables are to be shipped for both python 2 and python 3:
- Both python 2 and python 3 variants must provide symlinks with a '-X' and '-X.Y' suffix (python runtime major version, or python runtime major.minor version), unless upstream already provides appropriately versioned executables without the dash.
- The unversioned executable must be the python2 version.
- For example, the python3 version of "coverage" must ship executables
/usr/bin/coverage-3
and/usr/bin/coverage-3.4
(assuming python3 is currently version 3.4), while the python2 version must provide/usr/bin/coverage
,/usr/bin/coverage-2
and/usr/bin/coverage-2.7
(assuming python2 version 2.7). - For compatibility packages, the Python version is appended *after* the specific package version, for example
/usr/bin/coverage-v1.2-3
and/usr/bin/coverage-v1.2-3.4
for python3-coverage1.2 compat package.
See this thread and a newer thread [1] for discussions of this.
Packaging eggs
Please see the Python eggs guidelines for information specific to Python eggs.
Reviewer checklist
The following briefly summarizes the guidelines for reviewers to go over:
- Must: If you build for more than one python runtime you must use the
%python_provide
macro. - Must: If you build for a single python runtime you must add
%python_provide python-$module
so that the current default python is provided from the unversioned python package. - Must: Python modules must be built from source. They cannot simply drop an egg from upstream into the proper directory. (See prebuilt binaries Guidelines for details)
- Must: Python modules must not download any dependencies during the build process.
- Must: When building a compat package, it must install using easy_install -m so it won't conflict with the main package.
- Must: When building multiple versions (for a compat package) one of the packages must contain a default version that is usable via "import MODULE" with no prior setup.
- Should: A package which is used by another package via an egg interface should provide egg info.