Changes/EnableFSTrimTimer

🔗 Change Proposal Name

🔗 Owner

• Name: Your Name
• Email: <your email address so we can contact you, invite you to meetings, etc. Please provide your Bugzilla email address if it is different from your email in FAS>

🔗 Current status

• Targeted release: [[Releases/<number> | Fedora <number> ]]
• Last updated: 2019-12-18
• Tracker bug: <will be assigned by the Wrangler>
• Release notes tracker: <will be assigned by the Wrangler>

🔗 Scope

• Proposal owners:

Upon approval, submit a PR for fedora-release, modifying 90-default.preset to enable fstrim.timer

• Other developers:

strim.timer is provided by util-linux, notify util-linux maintainer

https://bugzilla.redhat.com/show_bug.cgi?id=1785041

• Release engineering: #9116

• Policies and guidelines: N/A

• Trademark approval: N/A

🔗 Upgrade/compatibility impact

fstrim.timer will be enabled on upgrade. An upgraded system should exhibit the same behaviors as a clean installed system.

🔗 How To Test

The low level function of the fstrim command and fstrim.service is well understood and tested already, all Fedora needs to test is that the timer is enabled following clean installation and upgrades: Preliminaries:

• Clean install Fedora 32, any edition or spin; or
• Upgrade from Fedora 30 or Fedora 31, any edition or spin, to Fedora 32

Confirm:

• sudo systemctl list-timers
• Confirm fstrim.timer is listed under UNITS, and is next scheduled for Monday 00:00:00
• Anytime following the NEXT time, sudo systemctl status fstrim.timer

Example, should apply in all cases: Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Succeeded.

Full example on a device with an SSD and filesystem supporting trim: ` $ sudo systemctl status fstrim.service ● fstrim.service - Discard unused blocks on filesystems from /etc/fstab

  Loaded: loaded (/usr/lib/systemd/system/fstrim.service; static; vendor preset: disabled)
  Active: inactive (dead) since Wed 2019-12-18 13:48:54 MST; 15min ago
    Docs: man:fstrim(8)
 Process: 3870 ExecStart=/usr/sbin/fstrim --fstab --verbose --quiet (code=exited, status=0/SUCCESS)
Main PID: 3870 (code=exited, status=0/SUCCESS)
     CPU: 1.387s

Dec 18 13:48:48 fmac.local systemd[1]: Starting Discard unused blocks on filesystems from /etc/fstab... Dec 18 13:48:54 fmac.local fstrim[3870]: /: 32 GiB (34409328640 bytes) trimmed on /dev/sda4 Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Succeeded. Dec 18 13:48:54 fmac.local systemd[1]: Started Discard unused blocks on filesystems from /etc/fstab. Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Consumed 1.387s CPU time. ` Regardless of configuration, there should be no errors.

🔗 User Experience

Most users will not notice the change. Some will notice improved performance of flash storage devices, and more efficient use of thinly provisioned storage.

This does NOT affect all storage. Only file systems listed in fstab will be affected.

If the user/admin wants fstrim to apply to all storage, they should copy the original fstrim.service unit file, replacing --fstab with --all which will then run fstrim weekly on all mounted file systems. And use this modified unit file as a drop in service unit. See https://www.freedesktop.org/software/systemd/man/systemd.unit.html

🔗 Contingency Plan

• Contingency mechanism: Owner will revert the change
• Contingency deadline: final freeze
• Blocks release? No
• Blocks product? No

🔗 Documentation

man fstrim