From Fedora Project Wiki
 
(16 intermediate revisions by 2 users not shown)
Line 19: Line 19:
 
<!-- Include you email address that you can be reached should people want to contact you about helping with your change, status is requested, or technical issues need to be resolved. If the change proposal is owned by a SIG, please also add a primary contact person. -->
 
<!-- Include you email address that you can be reached should people want to contact you about helping with your change, status is requested, or technical issues need to be resolved. If the change proposal is owned by a SIG, please also add a primary contact person. -->
 
* Email: <python-devel@lists.fedoraproject.org>
 
* Email: <python-devel@lists.fedoraproject.org>
* Release notes owner: <!--- To be assigned by docs team [[User:FASAccountName| Release notes owner name]] <email address> -->
+
* Release notes ticket: [https://pagure.io/fedora-docs/release-notes/issue/77 #77]
 
<!--- UNCOMMENT only for Changes with assigned Shepherd (by FESCo)
 
<!--- UNCOMMENT only for Changes with assigned Shepherd (by FESCo)
 
* FESCo shepherd: [[User:FASAccountName| Shehperd name]] <email address>
 
* FESCo shepherd: [[User:FASAccountName| Shehperd name]] <email address>
Line 39: Line 39:
 
CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development
 
CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development
 
-->
 
-->
* Tracker bug: <will be assigned by the Wrangler>
+
* Tracker bug: [https://bugzilla.redhat.com/show_bug.cgi?id=1534542 #1534542]
  
 
== Detailed Description ==
 
== Detailed Description ==
Line 48: Line 48:
 
The {{package|python-django}} package will be updated to 2.0, Python 2 subpackage(s) will be removed. A new compatibility {{package|python2-django1.11}} package will be created with Python 2 version of Django 1.11. The Django 1.11.x series is the last to support Python 2.7, it also has Long Term Support (supported until April 2020 by upstream). See the [https://docs.djangoproject.com/en/2.0/releases/2.0/#python-compatibility Django 2.0 release notes] for details about Django compatibility with various Python versions.
 
The {{package|python-django}} package will be updated to 2.0, Python 2 subpackage(s) will be removed. A new compatibility {{package|python2-django1.11}} package will be created with Python 2 version of Django 1.11. The Django 1.11.x series is the last to support Python 2.7, it also has Long Term Support (supported until April 2020 by upstream). See the [https://docs.djangoproject.com/en/2.0/releases/2.0/#python-compatibility Django 2.0 release notes] for details about Django compatibility with various Python versions.
  
The new {{package|python2-django1.11}} package will obsolete <code>python2-django < 2</code> and <code>python-django < 2</code>, but it will deliberately not provide either of those. This will render packages depending on <code>python(2)-django</code> FTBFS (or broken runtime dependencies if tehy don't require Django at buildtime). This is intentional. If we don't do that, all Django packages in Fedora will just keep dragging the Legacy Python dependency chain forever. Package owners of Django applications requiring Python 2 will need to manually adjust their dependencies to use {{package|python2-django1.11}} or move to Python 3 only (this is preferred but not always possible). Package owners of Django libraries will need to coordinate this with package owners of the applications. The rule of thumb is: If the library is not required by an application (packaged in Fedora) that uses Legacy Python, remove the Python 2 subpackage (or retire the package, if it cannot support Python 3).
+
The new {{package|python2-django1.11}} package will obsolete <code>python2-django < 2</code> and <code>python-django < 2</code>, but it will deliberately not provide either of those. This will render packages depending on <code>python(2)-django</code> FTBFS (or broken runtime dependencies if they don't require Django at buildtime). This is intentional. If we don't do that, all Django packages in Fedora will just keep dragging the Legacy Python dependency chain forever. Package owners of Django applications requiring Python 2 will need to manually adjust their dependencies to use {{package|python2-django1.11}} or move to Python 3 only (this is preferred but not always possible). Package owners of Django libraries will need to coordinate this with package owners of the applications. The rule of thumb is: If the library is not required by an application (packaged in Fedora) that uses Legacy Python, remove the Python 2 subpackage (or retire the package, if it cannot support Python 3).
  
 
There will be packages that fail to build or have broken dependencies. Package owners shall fix those by the steps described above. Proposal owners will send dist-git Pull Requests or Bugzilla patches to help. Proven packager powers will be used to merge those after 14 days of no activity. The removal of leftover packages from Fedora will be coordinated with FESCo (for approval) and releng (for execution).
 
There will be packages that fail to build or have broken dependencies. Package owners shall fix those by the steps described above. Proposal owners will send dist-git Pull Requests or Bugzilla patches to help. Proven packager powers will be used to merge those after 14 days of no activity. The removal of leftover packages from Fedora will be coordinated with FESCo (for approval) and releng (for execution).
  
 
[http://fedora.portingdb.xyz/grp/django/ Most of the Django packages in Fedora are already Python 3 compatible.]
 
[http://fedora.portingdb.xyz/grp/django/ Most of the Django packages in Fedora are already Python 3 compatible.]
 +
 +
''Note that we are aware that naming the compatibility package {{package|python2-django}} would make this entire change much easier. But we'd very much like to retire the entire Python 2 based Django ecosystem at this point already. Creating {{package|python2-django1.11}} and not providing  <code>python2-django</code> is a compromise. Also, we plan to provide it as a contingency plan if necessary, see bellow.''
  
 
== Benefit to Fedora ==
 
== Benefit to Fedora ==
 
Fedora will be able to provide both: latest and current release of Django and also a fallback for applications, which do not support Python 3 yet.
 
Fedora will be able to provide both: latest and current release of Django and also a fallback for applications, which do not support Python 3 yet.
  
This will also remove some Legacy packages nobody is actively taking care of.
+
This will also remove some legacy packages nobody is actively taking care of.
 
   
 
   
 
    
 
    
Line 63: Line 65:
  
 
== Scope ==
 
== Scope ==
* '''Proposal owners:''' drop Python 2 subpackage(s) from {{package|python-django}}, upgrade {{package|python-django}} to 2.0 and package {{package|python2-django1.11}} for Python 2 only.   
+
* '''Proposal owners:''' drop Python 2 subpackage(s) from {{package|python-django}} (done), upgrade {{package|python-django}} to 2.0 (done) and package {{package|python2-django1.11}} for Python 2 only (done).   
 
<!-- What work do the feature owners have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->
 
<!-- What work do the feature owners have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->
  
 
* '''Django apps owners:''' Either update to Python 3 or use {{package|python2-django1.11}} as a dependency.
 
* '''Django apps owners:''' Either update to Python 3 or use {{package|python2-django1.11}} as a dependency.
  
* '''Django libraries owners:''' Either drop Python 2 subpackages (eventually retire the package if no subpackages are left) or use {{package|python2-django1.11}} as a dependency for the python 2 subpackages iff those are needed by apps. When removing subpackages, add proper Obosletes tags to their Python 3 counterparts. When orphaning entire packages, add Obosletes to the {{package|python3-django}} package.
+
* '''Django libraries owners:''' Either drop Python 2 subpackages (eventually retire the package if no subpackages are left) or use {{package|python2-django1.11}} as a dependency for the python 2 subpackages iff those are needed by apps (the second option applies to {{package|python2-django-tagging}} only!). When removing subpackages, add proper Obosletes tags to their Python 3 counterparts. When orphaning entire packages, add Obosletes to the {{package|python3-django}} package.
  
* '''Release engineering:''' [https://pagure.io/releng/issues #Releng issue number] (a check of an impact with Release Engineering is needed) <!-- REQUIRED FOR SYSTEM WIDE AS WELL AS FOR SELF CONTAINED CHANGES -->
+
* '''Release engineering:''' [https://pagure.io/releng/issue/7211 #7211] (a check of an impact with Release Engineering is needed) <!-- REQUIRED FOR SYSTEM WIDE AS WELL AS FOR SELF CONTAINED CHANGES -->
 
<!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)?  Is a mass rebuild required?  include a link to the releng issue.  
 
<!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)?  Is a mass rebuild required?  include a link to the releng issue.  
 
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing, and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication -->
 
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing, and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication -->
Line 87: Line 89:
 
* {{package|fts-monitoring}}
 
* {{package|fts-monitoring}}
 
* {{package|gramps-webapp}}
 
* {{package|gramps-webapp}}
* {{package|graphite-web}}
+
* {{package|graphite-web}} (requires {{package|python2-django-tagging}}, the only library that needs to have py2 version)
 
* {{package|pony}}
 
* {{package|pony}}
 
* {{package|pulp-server}}
 
* {{package|pulp-server}}
 
* {{package|python2-kobo-admin}}
 
* {{package|python2-kobo-admin}}
 
* {{package|python2-kobo-hub}}
 
* {{package|python2-kobo-hub}}
* {{package|python2-pelican}}
+
* {{package|python2-pelican}} (removed)
 
* {{package|python2-testfixtures-tests}}
 
* {{package|python2-testfixtures-tests}}
 
* {{package|python2-whitenoise}}
 
* {{package|python2-whitenoise}}
Line 133: Line 135:
 
<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
 
<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
  
Users using RPM installed Django to develop Django apps might be affected by this change. We shall recommend either using venvs or using Python 3. See The developer portal, we are already [https://developer.fedoraproject.org/tech/languages/python/django-installation.html recommending both].
+
Users using RPM installed Django to develop Django apps might be affected by this change. We shall recommend either using venvs or using Python 3. See the developer portal, we are already [https://developer.fedoraproject.org/tech/languages/python/django-installation.html recommending both].
  
 
== Contingency Plan ==
 
== Contingency Plan ==
  
 
<!-- If you cannot complete your feature by the final development freeze, what is the backup plan?  This might be as simple as "Revert the shipped configuration".  Or it might not (e.g. rebuilding a number of dependent packages).  If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy.  -->
 
<!-- If you cannot complete your feature by the final development freeze, what is the backup plan?  This might be as simple as "Revert the shipped configuration".  Or it might not (e.g. rebuilding a number of dependent packages).  If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy.  -->
* Contingency mechanism: (What to do?  Who will do it?) Add <code>python2-django</code> and <code>python-django</code> virtual provides to {{package|python2-django1.11}}.
+
* Contingency mechanism: (What to do?  Who will do it?) Proposal owners will add <code>python2-django</code> and <code>python-django</code> virtual provides to {{package|python2-django1.11}} if everything goes south.
 
<!-- When is the last time the contingency mechanism can be put in place?  This will typically be the beta freeze. -->
 
<!-- When is the last time the contingency mechanism can be put in place?  This will typically be the beta freeze. -->
 
* Contingency deadline: beta freeze
 
* Contingency deadline: beta freeze
Line 159: Line 161:
 
TBD
 
TBD
  
[[Category:ChangePageIncomplete]]
+
[[Category:ChangeAcceptedF28]]
 
<!-- When your change proposal page is completed and ready for review and announcement -->
 
<!-- When your change proposal page is completed and ready for review and announcement -->
 
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->
 
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->

Latest revision as of 14:40, 2 March 2018


Django 2.0

Summary

This change is about upgrading Package-x-generic-16.pngpython-django to version 2.0. The latest Django release drops support for Python 2, but a few Django apps packaged in Fedora do not yet support Python 3. A compatibility package will be provided for those.

Owner

Current status

Detailed Description

The latest Django release 2.0 finally drops support for Python 2.7. Not all dependent applications in Fedora can keep up with Djangos pace. This change describes a way how to enable both, keeping 2.7 compatibility and also leveraging the latest version.

The Package-x-generic-16.pngpython-django package will be updated to 2.0, Python 2 subpackage(s) will be removed. A new compatibility Package-x-generic-16.pngpython2-django1.11 package will be created with Python 2 version of Django 1.11. The Django 1.11.x series is the last to support Python 2.7, it also has Long Term Support (supported until April 2020 by upstream). See the Django 2.0 release notes for details about Django compatibility with various Python versions.

The new Package-x-generic-16.pngpython2-django1.11 package will obsolete python2-django < 2 and python-django < 2, but it will deliberately not provide either of those. This will render packages depending on python(2)-django FTBFS (or broken runtime dependencies if they don't require Django at buildtime). This is intentional. If we don't do that, all Django packages in Fedora will just keep dragging the Legacy Python dependency chain forever. Package owners of Django applications requiring Python 2 will need to manually adjust their dependencies to use Package-x-generic-16.pngpython2-django1.11 or move to Python 3 only (this is preferred but not always possible). Package owners of Django libraries will need to coordinate this with package owners of the applications. The rule of thumb is: If the library is not required by an application (packaged in Fedora) that uses Legacy Python, remove the Python 2 subpackage (or retire the package, if it cannot support Python 3).

There will be packages that fail to build or have broken dependencies. Package owners shall fix those by the steps described above. Proposal owners will send dist-git Pull Requests or Bugzilla patches to help. Proven packager powers will be used to merge those after 14 days of no activity. The removal of leftover packages from Fedora will be coordinated with FESCo (for approval) and releng (for execution).

Most of the Django packages in Fedora are already Python 3 compatible.

Note that we are aware that naming the compatibility package Package-x-generic-16.pngpython2-django would make this entire change much easier. But we'd very much like to retire the entire Python 2 based Django ecosystem at this point already. Creating Package-x-generic-16.pngpython2-django1.11 and not providing python2-django is a compromise. Also, we plan to provide it as a contingency plan if necessary, see bellow.

Benefit to Fedora

Fedora will be able to provide both: latest and current release of Django and also a fallback for applications, which do not support Python 3 yet.

This will also remove some legacy packages nobody is actively taking care of.


Scope

  • Django libraries owners: Either drop Python 2 subpackages (eventually retire the package if no subpackages are left) or use Package-x-generic-16.pngpython2-django1.11 as a dependency for the python 2 subpackages iff those are needed by apps (the second option applies to Package-x-generic-16.pngpython2-django-tagging only!). When removing subpackages, add proper Obosletes tags to their Python 3 counterparts. When orphaning entire packages, add Obosletes to the Package-x-generic-16.pngpython3-django package.
  • Release engineering: #7211 (a check of an impact with Release Engineering is needed)
    • releng will help with bulk retirement of packages that fail to keep up with this proposal
  • Policies and guidelines:
    • Python packaging guidelines
    • Documentation should be provided

List of packages requiring Package-x-generic-16.pngpython2-django/ Package-x-generic-16.pngpython-django without having django in their name:

Upgrade/compatibility impact

The obsoletes added to Package-x-generic-16.pngpython2-django1.11 and others should make the upgrade work seamlessly.

How To Test

You should be able to install two web-apps, one requiring Package-x-generic-16.pngpython2-django1.11 and one requiring Package-x-generic-16.pngpython3-django. (TODO: provide actual package names)

  1. dnf install (package 1)
  2. see python2-django1.11 is installed as dependency
  3. run that package
  4. dnf install (package 2)
  5. verify python3-django is installed as dependency
  6. package 1 still works
  7. package 2 works as well
  8. dnf remove package 1
  9. package 2 still works

User Experience

Users using RPM installed Django to develop Django apps might be affected by this change. We shall recommend either using venvs or using Python 3. See the developer portal, we are already recommending both.

Contingency Plan

  • Contingency mechanism: (What to do? Who will do it?) Proposal owners will add python2-django and python-django virtual provides to Package-x-generic-16.pngpython2-django1.11 if everything goes south.
  • Contingency deadline: beta freeze
  • Blocks release? No
  • Blocks product? No

Documentation

TBD

Release Notes

TBD