< Changes
Chrismurphy (talk | contribs) m (→How To Test) |
Chrismurphy (talk | contribs) |
||
| Line 147: | Line 147: | ||
== User Experience == | == User Experience == | ||
<!-- If this change proposal is noticeable by users, how will their experiences change as a result? | <!-- If this change proposal is noticeable by users, how will their experiences change as a result? | ||
== Dependencies == | == Dependencies == | ||
| Line 154: | Line 152: | ||
<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
Most users will not notice the change. Some will notice improved performance of flash storage devices, and more efficient use of thinly provisioned storage. | |||
== Contingency Plan == | == Contingency Plan == | ||
Revision as of 21:30, 18 December 2019
Change Proposal Name
Summary
Owner
- Name: Your Name
- Email: <your email address so we can contact you, invite you to meetings, etc. Please provide your Bugzilla email address if it is different from your email in FAS>
Current status
- Targeted release: [[Releases/<number> | Fedora <number> ]]
- Last updated: 2019-12-18
- Tracker bug: <will be assigned by the Wrangler>
- Release notes tracker: <will be assigned by the Wrangler>
Detailed Description
Benefit to Fedora
Scope
- Proposal owners:
- Other developers: N/A (not a System Wide Change)
- Release engineering: #Releng issue number (a check of an impact with Release Engineering is needed)
- Policies and guidelines: N/A (not a System Wide Change)
- Trademark approval: N/A (not needed for this Change)
Upgrade/compatibility impact
N/A (not a System Wide Change)
How To Test
The low level function of the fstrim command and fstrim.service is well understood and tested already, all Fedora needs to test is that the timer is enabled following clean installation and upgrades: Preliminaries:
- Clean install Fedora 32, any edition or spin; or
- Upgrade from Fedora 30 or Fedora 31, any edition or spin, to Fedora 32
Confirm:
sudo systemctl list-timers- Confirm
fstrim.timeris listed under UNITS, and is next scheduled for Monday 00:00:00 - Anytime following the NEXT time,
sudo systemctl status fstrim.timer
Example, should apply in all cases: Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Succeeded.
Full example on a device with an SSD and filesystem supporting trim:
`
$ sudo systemctl status fstrim.service
● fstrim.service - Discard unused blocks on filesystems from /etc/fstab
Loaded: loaded (/usr/lib/systemd/system/fstrim.service; static; vendor preset: disabled)
Active: inactive (dead) since Wed 2019-12-18 13:48:54 MST; 15min ago
Docs: man:fstrim(8)
Process: 3870 ExecStart=/usr/sbin/fstrim --fstab --verbose --quiet (code=exited, status=0/SUCCESS)
Main PID: 3870 (code=exited, status=0/SUCCESS)
CPU: 1.387s
Dec 18 13:48:48 fmac.local systemd[1]: Starting Discard unused blocks on filesystems from /etc/fstab...
Dec 18 13:48:54 fmac.local fstrim[3870]: /: 32 GiB (34409328640 bytes) trimmed on /dev/sda4
Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Succeeded.
Dec 18 13:48:54 fmac.local systemd[1]: Started Discard unused blocks on filesystems from /etc/fstab.
Dec 18 13:48:54 fmac.local systemd[1]: fstrim.service: Consumed 1.387s CPU time.
`
Regardless of configuration, there should be no errors.
User Experience
Most users will not notice the change. Some will notice improved performance of flash storage devices, and more efficient use of thinly provisioned storage.
Contingency Plan
- Contingency mechanism: Owner will revert the change
- Contingency deadline: final freeze
- Blocks release? No
- Blocks product? No
Documentation
man fstrim