From Fedora Project Wiki
No edit summary
(28 intermediate revisions by 2 users not shown)
Line 1: Line 1:
{{admon/important | Comments and Explanations | The page source contains comments providing guidance to fill out each section. They are invisible when viewing this page. To read it, choose the "view source" link.<br/> '''Copy the source to a ''new page'' before making changes!  DO NOT EDIT THIS TEMPLATE FOR YOUR CHANGE PROPOSAL.'''}}
{{admon/tip | Guidance | For details on how to fill out this form, see the [https://docs.fedoraproject.org/en-US/program_management/changes_guide/ documentation].}}
<!-- The actual name of your proposed change page should look something like: Changes/Your_Change_Proposal_Name.  This keeps all change proposals in the same namespace -->
= KTLS implementation for GnuTLS <!-- The name of your change proposal --> =
= KTLS implementation for GnuTLS <!-- The name of your change proposal --> =
 
{{admon/important|kTLS now disabled by default| see the rationale for this decision [https://pagure.io/fesco/issue/2871#comment-824428 here].}}
{{Change_Proposal_Banner}}


== Summary ==
== Summary ==
<!-- A sentence or two summarizing what this change is and what it will do. This information is used for the overall changeset summary page for each release. Note that motivation for the change should be in the Benefit to Fedora section below, and this part should answer the question "What?" rather than "Why?". -->
Acceleration of GnuTLS with software ''Kernel TLS'' (KTLS)
Acceleration of GnuTLS with software Kernel TLS(KTLS)


== Owner ==
== Owner ==
<!--
* Name: [[User:Fkrenzel| František Krenželok]], [[User:Ueno| Daiki Ueno]]
For change proposals to qualify as self-contained, owners of all affected packages need to be included here. Alternatively, a SIG can be listed as an owner if it owns all affected packages.
* Email: fkrenzel@redhat.com, dueno@redhat.com
This should link to your home wiki page so we know who you are.
-->
* Name: [[User:Fkrenzel| František Krenželok]]
<!-- Include you email address that you can be reached should people want to contact you about helping with your change, status is requested, or technical issues need to be resolved. If the change proposal is owned by a SIG, please also add a primary contact person. -->
* Email: fkrenzel@redhat.com
<!--- UNCOMMENT only for Changes with assigned Shepherd (by FESCo)
<!--- UNCOMMENT only for Changes with assigned Shepherd (by FESCo)
* FESCo shepherd: [[User:FASAccountName| Shehperd name]] <email address>
* FESCo shepherd: [[User:FASAccountName| Shehperd name]] <email address>
-->
-->


== Current status ==
== Current status ==
[[Category:ChangePageIncomplete]]
[[Category:ChangeAcceptedF38]]
<!-- When your change proposal page is completed and ready for review and announcement -->
<!-- When your change proposal page is completed and ready for review and announcement -->
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->
Line 33: Line 19:
<!-- After review, the Wrangler will move your page to Category:ChangeReadyForFesco... if it still needs more work it will move back to Category:ChangePageIncomplete-->
<!-- After review, the Wrangler will move your page to Category:ChangeReadyForFesco... if it still needs more work it will move back to Category:ChangePageIncomplete-->


<!-- Select proper category, default is Self Contained Change -->
<!-- [[Category:SelfContainedChange]] -->
<!-- [[Category:SelfContainedChange]] -->
[[Category:SystemWideChange]]
[[Category:SystemWideChange]]
Line 45: Line 30:
ON_QA -> change is fully code complete
ON_QA -> change is fully code complete
-->
-->
* FESCo issue: <will be assigned by the Wrangler>
* [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/T2JYAYRCHUBFZF57AJ6TFASLMYHRGVI4/ devel thread]
* Tracker bug: <will be assigned by the Wrangler>
* FESCo issue: [https://pagure.io/fesco/issue/2871 #2871]
* Release notes tracker: <will be assigned by the Wrangler>
* Tracker bug: [https://bugzilla.redhat.com/show_bug.cgi?id=2130000 #2130000]
* Release notes tracker: [https://pagure.io/fedora-docs/release-notes/issue/881 #881]


== Detailed Description ==
== Detailed Description ==
The goal of this change is to provide GnuTLS users with a high throughput data transfer mechanism on encrypted channels, with emphasis on network block devices(NBD).
The goal of this change is to provide GnuTLS users with a high throughput data transfer mechanism on encrypted channels, with emphasis on ''network block devices'' (NBD).


We accomplish this with KTLS which offloads enc/decryption to the kernel, while GnuTLS handles initial connection(TLS handshake). This approach saves us from frequent context switching as well as data copies in userspace when using send_file() function.
We accomplish this with kTLS which offloads enc/decryption (TLS record) to the kernel, while GnuTLS handles initial connection (TLS handshake).


<strike>GNUTLS will detect whether the kernel supports kTLS and will automatically enable its usage when compatible</strike>
</br>kTLS will be disabled by default and enabled with the following [https://fedoraproject.org/wiki/Changes/KTLSSupportForGnuTLS#How_To_Test steps]. Any package built against GNUTLS with kTLS enabled, is likely to see some performance benefit from kTLS, provided it has not installed custom push/pull I/O function callbacks.
kTLS enables a reduction in context switching and reduced data copies when using send_file(). With suitable NIC hardware the encryption operations can be offloaded, freeing time on the main CPUs for application usage. Without offload hardware, kTLS may still improve parallelism for applications as the kernel can perform encryption operations on a differen host CPU to that running the application threads


== Feedback ==
== Feedback ==
Line 59: Line 49:


== Benefit to Fedora ==
== Benefit to Fedora ==
<!-- What is the benefit to the distribution?  Will the software we generate be improved? How will the process of creating Fedora releases be improved?
The improvement lies in acceleration of large data transfers trough encrypted channels.
 
The send_file function enables us to send data directly trough socket without entering user space, saving us from 2 context switches and 2 additional user space buffers. This is especially useful for NBD
      Be sure to include the following areas if relevant:
      If this is a major capability update, what has changed?
          For example: This change introduces Python 5 that runs without the Global Interpreter Lock and is fully multithreaded.
      If this is a new functionality, what capabilities does it bring?
          For example: This change allows package upgrades to be performed automatically and rolled-back at will.
      Does this improve some specific package or set of packages?
          For example: This change modifies a package to use a different language stack that reduces install size by removing dependencies.
      Does this improve specific Spins or Editions?
          For example: This change modifies the default install of Fedora Workstation to be more in line with the base install of Fedora Server.
      Does this make the distribution more efficient?
          For example: This change replaces thousands of individual %post scriptlets in packages with one script that runs at the end.
      Is this an improvement to maintainer processes?
          For example: Gating Fedora packages on automatic QA tests will make rawhide more stable and allow changes to be implemented more smoothly.
      Is this an improvement targeted as specific contributors?
          For example: Ensuring that a minimal set of tools required for contribution to Fedora are installed by default eases the onboarding of new contributors.


    When a Change has multiple benefits, it's better to list them all.
'''Benefits'''
* Acceleration of ''live VM migration'', which should mitigate the downtime for various services used by both the users and the developers.


    Consider these Change pages from previous editions as inspiration:
* Increased speed at which files can be retrieved from NBD via encrypted channel and less CPU and memory strain on NBD server.
    https://fedoraproject.org/wiki/Changes/Annobin (low-level and technical, invisible to users)
    https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo (low-level, but visible to advanced users)
    https://fedoraproject.org/wiki/Changes/VirtualBox_Guest_Integration (primarily a UX change)
    https://fedoraproject.org/wiki/Changes/NoMoreAlpha (an improvement to distro processes)
    https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack)
-->
== Scope ==
* Proposal owners:
<!-- What work do the feature owners have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->


* Other developers: <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
packages that might benefit: {{package|nbd}} {{package|nbdkit}} {{package|qemu}}
<!-- What work do other developers have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->


* Release engineering: [https://pagure.io/releng/issues #Releng issue number] <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
== Scope ==
<!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)?  Is a mass rebuild required?  include a link to the releng issue.
* Proposal owners: Support for kTLS key update in GnuTLS ''track'': [https://gitlab.com/gnutls/gnutls/-/merge_requests/1625 gitlab]
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication -->
* Other developers: Support for TLS1.3 key update in kTLS (tls kernel module)
 
* Release engineering: https://pagure.io/releng/issue/11016
* Policies and guidelines: N/A (not needed for this Change) <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
* Policies and guidelines: not needed for this Change
<!-- Do the packaging guidelines or other documents need to be updated for this feature?  If so, does it need to happen before or after the implementation is done?  If a FPC ticket exists, add a link here. Please submit a pull request with the proposed changes before submitting your Change proposal. -->
* Trademark approval: not needed for this Change
 
* Alignment with Objectives: None
* Trademark approval: N/A (not needed for this Change)
<!-- If your Change may require trademark approval (for example, if it is a new Spin), file a ticket ( https://pagure.io/Fedora-Council/tickets/issues ) requesting trademark approval from the Fedora Council. This approval will be done via the Council's consensus-based process. -->
 
* Alignment with Objectives:  
<!-- Does your proposal align with the current Fedora Objectives: https://docs.fedoraproject.org/en-US/project/objectives/ ? It's okay if it doesn't, but it's something to consider -->


== Upgrade/compatibility impact ==
== Upgrade/compatibility impact ==
<!-- What happens to systems that have had a previous versions of Fedora installed and are updated to the version containing this change? Will anything require manual configuration or data migration? Will any existing functionality be no longer supported? -->
<strike>Although this feature will be enabled by default, users will not notice any change, as in case of failure to initialize kTLS, GnuTLS will fallback to the currently used mode of operation.</strike>
 
kTLS will be disabled by default so users will not notice any changes.
<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
 


== How To Test ==
== How To Test ==
<!-- This does not need to be a full-fledged document. Describe the dimensions of tests that this change implementation is expected to pass when it is done.  If it needs to be tested with different hardware or software configurations, indicate them.  The more specific you can be, the better the community testing can be.
'''To enable this feature user has to:'''
 
# load TLS kernel module (`modprobe tls`)
Remember that you are writing this how to for interested testers to use to check out your change implementation - documenting what you do for testing is OK, but it's much better to document what *I* can do to test your change.
# enable ktls with crypto policies
 
<pre>$ cat > /etc/crypto-policies/local.d/gnutls-ktls.config <<EOF
A good "how to test" should answer these four questions:
[global]
 
ktls = true
0. What special hardware / data / etc. is needed (if any)?
EOF
1. How do I prepare my system to test this change? What packages
</pre>
need to be installed, config files edited, etc.?
<pre>$ update-crypto-policies</pre>
2. What specific actions do I perform to check that the change is
{{admon/important||kTLS will not initialize if app uses custom push/pull callback for GnuTLS.}}
working like it's supposed to?
3. What are the expected results of those actions?
-->
 
<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
 
To enable this feature, user has to load TLS kernel module (`modprobe tls`) and enable ktls by entering `ktls = true` in `[global]` section of GnuTLS configuration file [https://gnutls.org/manual/html_node/Enabling_002fDisabling-system_002facceleration-protocols.html#Enabling-KTLS see].


== User Experience ==
== User Experience ==
<!-- If this change proposal is noticeable by users, how will their experiences change as a result?
This change should accelerate large data transfers especially that of files.  
 
This will affect users that use applications which utilize GnuTLS for encrypting communication channels.
This section partially overlaps with the Benefit to Fedora section above. This section should be primarily about the User Experience, written in a way that does not assume deep technical knowledge. More detailed technical description should be left for the Benefit to Fedora section.
 
Describe what Users will see or notice, for example:
  - Packages are compressed more efficiently, making downloads and upgrades faster by 10%.
  - Kerberos tickets can be renewed automatically. Users will now have to authenticate less and become more productive. Credential management improvements mean a user can start their work day with a single sign on and not have to pause for reauthentication during their entire day.
- Libreoffice is one of the most commonly installed applications on Fedora and it is now available by default to help users "hit the ground running".
- Green has been scientifically proven to be the most relaxing color. The move to a default background color of green with green text will result in Fedora users being the most relaxed users of any operating system.
-->
This change might interest package maintainers i.e. developers that picked GnuTLS as their go to solution when it come to transferring data securely, and wish to accelerate it. The acceleration is most noticeable on large data transfer such that of files.


== Dependencies ==
== Dependencies ==
<!-- What other packages (RPMs) depend on this package?  Are there changes outside the developers' control on which completion of this change depends?  In other words, completion of another change owned by someone else and might cause you to not be able to finish on time or that you would need to coordinate?  Other upstream projects like the kernel (if this is not a kernel change)? -->


<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
Currently '''kTLS doesn't support key_update''' (The keys delivered to the kernel can’t be set more than once per session) so a kernel module patch would be needed for this functionality.
This not only impacts key_update invokation by user of either side, but also by [https://datatracker.ietf.org/doc/html/rfc8446#section-5.5 AES-GCM key usage limit]. As this could weaken the security of TLS protocol, <strike> GnuTLS will disable kTLS for rest of the session and fallback to default mode of operation i.e. move encryption and decryption back to usersace </strike> GnuTLS will invalidate the session and return a error after the key_update is called.


{{admon/note|GnuTLS supports kTLS key_update| This feature is supported if apropriate kernel patch is applied}}


== Contingency Plan ==
== Contingency Plan ==
* Contingency mechanism: Feature will be disabled by default in crypto-policies.
* Contingency deadline: 2023-02-21
* Blocks release? No


<!-- If you cannot complete your feature by the final development freeze, what is the backup plan?  This might be as simple as "Revert the shipped configuration".  Or it might not (e.g. rebuilding a number of dependent packages).  If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy.  -->
* Contingency mechanism: (What to do?  Who will do it?) N/A (not a System Wide Change)  <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
<!-- When is the last time the contingency mechanism can be put in place?  This will typically be the beta freeze. -->
* Contingency deadline: N/A (not a System Wide Change)  <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
<!-- Does finishing this feature block the release, or can we ship with the feature in incomplete state? -->
* Blocks release? N/A (not a System Wide Change), Yes/No <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->


== Documentation ==
=== API ===
'''[https://gnutls.org/manual/gnutls.html#index-gnutls_005ftransport_005fis_005fktls_005fenabled gnutls_transport_is_ktls_enabled()]'''
To check if kTLS was properly initialized on the interfaces:
{{admon/important||it has to be invoked no earlier that after a TLS-handshake}}
<pre> gnutls_transport_ktls_enable_flags_t gnutls_transport_is_ktls_enabled(gnutls_session_t session);</pre>


== Documentation ==
<!-- Is there upstream documentation on this change, or notes you have written yourself?  Link to that material here so other interested developers can get involved. -->


<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
'''[https://gnutls.org/manual/gnutls.html#index-gnutls_005frecord_005fsend_005ffile gnutls_record_send_file()]'''
N/A (not a System Wide Change)  
To send data directly from a file descriptor in a zero-copy manner if kTLS is enabled; otherwise it will just iteratively read from the file descriptor:
<pre> ssize_t gnutls_record_send_file(gnutls_session_t session, int fd, off_t *offset, size_t count);</pre>


== Release Notes ==
== Release Notes ==

Revision as of 14:45, 7 November 2022

KTLS implementation for GnuTLS

Important.png
kTLS now disabled by default
see the rationale for this decision here.

Summary

Acceleration of GnuTLS with software Kernel TLS (KTLS)

Owner

Current status

Detailed Description

The goal of this change is to provide GnuTLS users with a high throughput data transfer mechanism on encrypted channels, with emphasis on network block devices (NBD).

We accomplish this with kTLS which offloads enc/decryption (TLS record) to the kernel, while GnuTLS handles initial connection (TLS handshake).

GNUTLS will detect whether the kernel supports kTLS and will automatically enable its usage when compatible
kTLS will be disabled by default and enabled with the following steps. Any package built against GNUTLS with kTLS enabled, is likely to see some performance benefit from kTLS, provided it has not installed custom push/pull I/O function callbacks.

kTLS enables a reduction in context switching and reduced data copies when using send_file(). With suitable NIC hardware the encryption operations can be offloaded, freeing time on the main CPUs for application usage. Without offload hardware, kTLS may still improve parallelism for applications as the kernel can perform encryption operations on a differen host CPU to that running the application threads

Feedback

Benefit to Fedora

The improvement lies in acceleration of large data transfers trough encrypted channels. The send_file function enables us to send data directly trough socket without entering user space, saving us from 2 context switches and 2 additional user space buffers. This is especially useful for NBD

Benefits

  • Acceleration of live VM migration, which should mitigate the downtime for various services used by both the users and the developers.
  • Increased speed at which files can be retrieved from NBD via encrypted channel and less CPU and memory strain on NBD server.

packages that might benefit: Package-x-generic-16.pngnbd Package-x-generic-16.pngnbdkit Package-x-generic-16.pngqemu

Scope

  • Proposal owners: Support for kTLS key update in GnuTLS track: gitlab
  • Other developers: Support for TLS1.3 key update in kTLS (tls kernel module)
  • Release engineering: https://pagure.io/releng/issue/11016
  • Policies and guidelines: not needed for this Change
  • Trademark approval: not needed for this Change
  • Alignment with Objectives: None

Upgrade/compatibility impact

Although this feature will be enabled by default, users will not notice any change, as in case of failure to initialize kTLS, GnuTLS will fallback to the currently used mode of operation. kTLS will be disabled by default so users will not notice any changes.

How To Test

To enable this feature user has to:

  1. load TLS kernel module (modprobe tls)
  2. enable ktls with crypto policies
$ cat > /etc/crypto-policies/local.d/gnutls-ktls.config <<EOF
[global]
ktls = true
EOF
$ update-crypto-policies
Important.png
kTLS will not initialize if app uses custom push/pull callback for GnuTLS.

User Experience

This change should accelerate large data transfers especially that of files. This will affect users that use applications which utilize GnuTLS for encrypting communication channels.

Dependencies

Currently kTLS doesn't support key_update (The keys delivered to the kernel can’t be set more than once per session) so a kernel module patch would be needed for this functionality. This not only impacts key_update invokation by user of either side, but also by AES-GCM key usage limit. As this could weaken the security of TLS protocol, GnuTLS will disable kTLS for rest of the session and fallback to default mode of operation i.e. move encryption and decryption back to usersace GnuTLS will invalidate the session and return a error after the key_update is called.

Note.png
GnuTLS supports kTLS key_update
This feature is supported if apropriate kernel patch is applied

Contingency Plan

  • Contingency mechanism: Feature will be disabled by default in crypto-policies.
  • Contingency deadline: 2023-02-21
  • Blocks release? No


Documentation

API

gnutls_transport_is_ktls_enabled() To check if kTLS was properly initialized on the interfaces:

Important.png
it has to be invoked no earlier that after a TLS-handshake
 gnutls_transport_ktls_enable_flags_t gnutls_transport_is_ktls_enabled(gnutls_session_t session);


gnutls_record_send_file() To send data directly from a file descriptor in a zero-copy manner if kTLS is enabled; otherwise it will just iteratively read from the file descriptor:

 ssize_t gnutls_record_send_file(gnutls_session_t session, int fd, off_t *offset, size_t count);

Release Notes