From Fedora Project Wiki
No edit summary
No edit summary
Line 62: Line 62:


== Scope ==
== Scope ==
* Proposal owners:
* Proposal owners: Support for KTLS key update in GnuTLS ''track'': [https://gitlab.com/gnutls/gnutls/-/merge_requests/1625 gitlab]
<!-- What work do the feature owners have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->
* Other developers: Support for TLS1.3 key update in KTLS module
Support for KTLS key update in GnuTLS ''track'': [https://gitlab.com/gnutls/gnutls/-/merge_requests/1625 gitlab]
* Release engineering: not needed for this Change
 
* Policies and guidelines: not needed for this Change
* Other developers: <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
* Trademark approval: not needed for this Change
<!-- What work do other developers have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?-->
* Alignment with Objectives: None
Support for TLS1.3 key update in KTLS module
 
* Release engineering: [https://pagure.io/releng/issues #Releng issue number] <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
<!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)?  Is a mass rebuild required?  include a link to the releng issue.
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication -->
 
* Policies and guidelines: N/A (not needed for this Change) <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
<!-- Do the packaging guidelines or other documents need to be updated for this feature?  If so, does it need to happen before or after the implementation is done?  If a FPC ticket exists, add a link here. Please submit a pull request with the proposed changes before submitting your Change proposal. -->
 
* Trademark approval: N/A (not needed for this Change)
<!-- If your Change may require trademark approval (for example, if it is a new Spin), file a ticket ( https://pagure.io/Fedora-Council/tickets/issues ) requesting trademark approval from the Fedora Council. This approval will be done via the Council's consensus-based process. -->
 
* Alignment with Objectives:  
<!-- Does your proposal align with the current Fedora Objectives: https://docs.fedoraproject.org/en-US/project/objectives/ ? It's okay if it doesn't, but it's something to consider -->


== Upgrade/compatibility impact ==
== Upgrade/compatibility impact ==
Line 109: Line 95:


== Contingency Plan ==
== Contingency Plan ==
<!-- If you cannot complete your feature by the final development freeze, what is the backup plan?  This might be as simple as "Revert the shipped configuration".  Or it might not (e.g. rebuilding a number of dependent packages).  If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy.  -->
* Contingency mechanism: Feature will be disabled by default in crypto-policies.
* Contingency mechanism: (What to do?  Who will do it?) N/A (not a System Wide Change)  <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
* Contingency deadline: 2023-02-21
<!-- When is the last time the contingency mechanism can be put in place?  This will typically be the beta freeze. -->
* Blocks release? No
* Contingency deadline: N/A (not a System Wide Change)  <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
 
<!-- Does finishing this feature block the release, or can we ship with the feature in incomplete state? -->
* Blocks release? N/A (not a System Wide Change), Yes/No <!-- REQUIRED FOR SYSTEM WIDE CHANGES -->


== Documentation ==
== Documentation ==
Line 127: Line 111:
To send data directly from a file descriptor in a zero-copy manner if KTLS is enabled; otherwise it will just iteratively read from the file descriptor:
To send data directly from a file descriptor in a zero-copy manner if KTLS is enabled; otherwise it will just iteratively read from the file descriptor:
<pre> ssize_t gnutls_record_send_file(gnutls_session_t session, int fd, off_t *offset, size_t count);</pre>
<pre> ssize_t gnutls_record_send_file(gnutls_session_t session, int fd, off_t *offset, size_t count);</pre>
<!-- REQUIRED FOR SYSTEM WIDE CHANGES -->
N/A (not a System Wide Change)


== Release Notes ==
== Release Notes ==

Revision as of 12:54, 24 August 2022

Important.png
Comments and Explanations
The page source contains comments providing guidance to fill out each section. They are invisible when viewing this page. To read it, choose the "view source" link.
Copy the source to a new page before making changes! DO NOT EDIT THIS TEMPLATE FOR YOUR CHANGE PROPOSAL.
Idea.png
Guidance
For details on how to fill out this form, see the documentation.


KTLS implementation for GnuTLS

Important.png
This is a proposed Change for Fedora Linux.
This document represents a proposed Change. As part of the Changes process, proposals are publicly announced in order to receive community feedback. This proposal will only be implemented if approved by the Fedora Engineering Steering Committee.

Summary

Acceleration of GnuTLS with software Kernel TLS (KTLS)

Owner

Current status

  • Targeted release: Fedora Linux 38
  • Last updated: 2022-08-24
  • FESCo issue: <will be assigned by the Wrangler>
  • Tracker bug: <will be assigned by the Wrangler>
  • Release notes tracker: <will be assigned by the Wrangler>

Detailed Description

The goal of this change is to provide GnuTLS users with a high throughput data transfer mechanism on encrypted channels, with emphasis on network block devices (NBD).

We accomplish this with KTLS which offloads enc/decryption (TLS record) to the kernel, while GnuTLS handles initial connection (TLS handshake). This approach saves us from frequent context switching as well as data copies in userspace when using send_file() function.

Feedback

Benefit to Fedora

The improvement lies in acceleration of large data transfers trough encrypted channels. The send_file function enables us to send data directly trough socket without entering user space, saving us from 2 context switches and 2 additional user space buffers. This is especially useful for NBD

Benefits

  • Acceleration of live VM migration, which should mitigate the downtime for various services used by both the users and the developers.
  • Increased speed at which files can be retrieved from NBD via encrypted channel and less CPU and memory strain on NBD server.

packages that might benefit: Package-x-generic-16.pngnbd Package-x-generic-16.pngnbdkit Package-x-generic-16.pngqemu

Scope

  • Proposal owners: Support for KTLS key update in GnuTLS track: gitlab
  • Other developers: Support for TLS1.3 key update in KTLS module
  • Release engineering: not needed for this Change
  • Policies and guidelines: not needed for this Change
  • Trademark approval: not needed for this Change
  • Alignment with Objectives: None

Upgrade/compatibility impact

Although this feature will be enabled by default, users will not notice any change, as in case of failure to initialize KTLS, GnuTLS will fallback to the currently used mode of operation.

Users will be also provided with means to disable this feature trough crypto-policies

How To Test

To enable this feature user has to:

  1. load TLS kernel module (modprobe tls)
  2. enable ktls with crypto policies
Note.png
Once proposal accepted
KTLS will be enabled by default and this step will not be needed.
$ cat > /etc/crypto-policies/local.d/gnutls-ktls.config <<EOF
[global]
ktls = true
EOF
$ update-crypto-policies
Important.png
KTLS will not initialize if app uses custom push/pull callback for GnuTLS.

User Experience

This change should accelerate large data transfers especially that of files. This will affect users that use applications which utilize GnuTLS for encrypting communication channels.

Dependencies

Currently KTLS doesn't support key_update (The keys delivered to the kernel can’t be set more than once per session) so a kernel module patch would be needed for this functionality.

Contingency Plan

  • Contingency mechanism: Feature will be disabled by default in crypto-policies.
  • Contingency deadline: 2023-02-21
  • Blocks release? No


Documentation

API

gnutls_transport_is_ktls_enabled() To check if KTLS was properly initialized on the interfaces:

Important.png
it has to be invoked no earlier that after a TLS-handshake
 gnutls_transport_ktls_enable_flags_t gnutls_transport_is_ktls_enabled(gnutls_session_t session);


gnutls_record_send_file() To send data directly from a file descriptor in a zero-copy manner if KTLS is enabled; otherwise it will just iteratively read from the file descriptor:

 ssize_t gnutls_record_send_file(gnutls_session_t session, int fd, off_t *offset, size_t count);

Release Notes