From Fedora Project Wiki
mNo edit summary
m (review templete was outdated)
 
Line 22: Line 22:


* [https://admin.fedoraproject.org/pkgdb/users/packages/fab Package database]
* [https://admin.fedoraproject.org/pkgdb/users/packages/fab Package database]
== Review template ==
<pre>
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[?] Package is named according to the Package Naming Guidelines.
[?] Spec file name must match the base package %{name}, in the format %{name}.spec.
[?] Package meets the Packaging Guidelines
[?] Package successfully compiles and builds into binary rpms on at least one supported architecture.
    Tested on:
      [] devel/i386
      [] devel/x86_64
      [] F9/i386
      [] F9/x86_64
[?] Rpmlint output:
    Source RPM:
    Binary RPM(s):
[?] Package is not relocatable.
[?] Buildroot is correct
    (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[?] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[?] License field in the package spec file matches the actual license.
    License type:
[?] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[?] Spec file is legible and written in American English.
[?] Sources used to build the package matches the upstream source, as provided in the spec URL.
    Upstream source:
    Build source:   
[?] Package is not known to require ExcludeArch
[?] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[?] The spec file handles locales properly.
[?] ldconfig called in %post and %postun if required.
[?] Package must own all directories that it creates.
[?] Package requires other packages for directories it uses.
[?] Package does not contain duplicates in %files.
[?] Permissions on files are set properly.
[?] Package has a %clean section, which contains rm -rf %{buildroot}.
[?] Package consistently uses macros.
[?] Package contains code, or permissable content.
[?] Large documentation files are in a -doc subpackage, if required.
[?] Package uses nothing in %doc for runtime.
[?] Header files in -devel subpackage, if present.
[?] Static libraries in -devel subpackage, if present.
[?] Package requires pkgconfig, if .pc files are present.
[?] Development .so files in -devel subpackage, if present.
[?] Fully versioned dependency in subpackages, if present.
[?] Package does not contain any libtool archives (.la).
[?] Package contains a properly installed %{name}.desktop file if it is a GUI application.
[?] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[?] Latest version is packaged.
[?] Package does not include license text files separate from upstream.
[?] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[?] Reviewer should test that the package builds in mock.
    Tested on: F9/i386
[?] Package should compile and build into binary rpms on all supported architectures.
    Tested on:
      [?] devel/i386
      [?] devel/x86_64
      [?] F9/i386
      [?] F9/x86_64
[?] Package functions as described (no hardware to test with).
[?] Scriptlets must be sane, if used.
[?] The placement of pkgconfig(.pc) files is correct.
[?] File based requires are sane.
</pre>

Latest revision as of 12:15, 22 June 2010

My sponsor is Christoph Wickert

Packages for review

Closed Package reviews

Personal wishlist

  • OpenFOAM
  • gerris
  • mozart
  • alice
  • étoile
  • salome
  • yade

Packages