From Fedora Project Wiki
(→‎Gitorious Web Application Gems: upstream uses a new version of riddle)
(→‎Open review requests: literati is compmlete)
 
(158 intermediate revisions by 2 users not shown)
Line 5: Line 5:
# Get all Gitorious' dependencies into Fedora.
# Get all Gitorious' dependencies into Fedora.
#* Several Rubygems.
#* Several Rubygems.
#* Several Javascripts.
# Get Gitorious into Fedora.
# Get Gitorious into Fedora.
#* Bundled libraries: Gitorious bundles several things, including Rails. [https://issues.gitorious.org/issues/3 Upstream bug for Rails]
#* Bundler issues: If we use different Gem versions than upstream, Bundler wants to write to Gemfile and Gemfile.lock. We will use bundler_ext to work around this. This will require the {{Pkg|rubygem-bundler_ext}} package and a lot of testing.
#* Bundler issues: If we use different Gem versions than upstream, Bundler wants to write to Gemfile and Gemfile.lock. We must patch upstream's Gemfile/Gemfile.lock to make this work.
#* Init scripts: Create equivalent systemd unit files for Fedora & RHEL 7.
#* Init scripts: Create equivalent systemd unit files for Fedora & RHEL 7.
#* Ruby version: Upstream master works with Ruby 1.8; verify Ruby 1.9.x compatability.
#* Ruby version: Upstream "master" branch works with Ruby 1.9.3 and 2.0.0. I'm working with upstream to maintain this compatibility via [https://ci.gitorious.org/jenkins/ Jenkins].
#* Gem versions: Upstream uses different Gem versions than Fedora has. The biggest difference is Rails, but others are documented below. Plan of attack is to ensure that the test suite passes with both.
#* Gem versions: Upstream uses different Gem versions than Fedora has. The biggest difference is Rails, but others are documented below. Plan of attack is to ensure that the test suite passes with both.
#* Javascript libs: There are a couple Git submodules in upstream (buster-core, capillary-js, raphael, spin.js). We should find a way to unbundle these and [[JavaScript libraries packaging guideline draft|package them]] separately.
#* Javascript libs: There are several Git submodules in upstream (bane, capillary-js, raphael, spin.js, others). We must unbundle these and [[JavaScript libraries packaging guideline draft|package them]] separately.
#* GeoIP data: Gitorious bundles GeoIP.dat, which is already available in Fedora as the "GeoIP" package.
#* FHS considerations: for the Gitorious web application itself, we need to discover how to split up the package to fit the FHS conventions of /etc/, /usr/, and so on.
#* FHS considerations: for the Gitorious web application itself, we need to discover how to split up the package to fit the FHS conventions of /etc/, /usr/, and so on.


Line 19: Line 20:
#* Various Rubygems must be branched for EPEL.
#* Various Rubygems must be branched for EPEL.
# Get Gitorious into EPEL.
# Get Gitorious into EPEL.
#* Ruby 1.8 may make things easier, since this is what upstream currently uses (although this will change, eventually).
#* Unfortunately upstream has dropped support for Ruby 1.8, so formal EPEL inclusion can only happen in EPEL 7.
#* EPEL has RSpec 1, but some gems (eg riddle) require RSpec 2.


== Dependencies ==
== Open review requests ==


* [[File:Test-result-fail.png|alt=Fail|link=]] - The package is not in Fedora/EPEL
Please review some of these. I'm willing to trade reviews.
* [[File:Artwork_EchoDevelopment_dialog-question16.png|alt=Pass|link=]] - The package is not in Fedora/EPEL, and I'm unsure how to proceed (lib might be deprecated, etc.)
* [[File:Test-result-inprogress.gif|alt=Inprogress|link=]] - The package spec is written, but not yet accepted into Fedora/EPEL
* [[File:Test-result-warn.png|alt=Pass|link=]] - The package is present in Fedora/EPEL and versions differ from upstream
* [[File:Test-result-pass.png|alt=Pass|link=]] - The package is present in Fedora/EPEL and versions match upstream


(FYI, the ordering in these tables matches [https://gitorious.org/gitorious/mainline/blobs/master/Gemfile upstream's Gemfile].)
{|border="2" cellpadding="2" cellspacing="0"
 
! Gem !! Package Review Request
=== Gitorious Web Application Gems ===
{|
! Gem !! Upstream Gemfile !! Fedora 17 !! EPEL 6
|-
| rails || 2.3.15 || {{result|warn}} 3.0/3.2 in F18  || {{result|fail}}
|-
| chronic        || 0.3.0  || {{result|warn}} 0.6.6  || {{result|fail}}
|-
| geoip          || 0.8.9<ref>Upstream ships data/GeoIP.dat, which Fedora already ships in GeoIP.</ref>  || {{result|inprogress}} 1.2.1, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-geoip.git git]  || {{result|fail}}
|-
| daemons        || 1.1.0  || {{result|warn}} 1.0.10 || {{result|warn}} 1.0.10
|-
| hoe            || 2.8.0  || {{result|warn}} 2.12.5  || {{result|fail}}
|-
| echoe          || 4.3.1  || {{result|warn}} 4.3.1  || {{result|fail}}
|-
| ruby-yadis      || 0.3.4  ||  {{result|inprogress}} 0.3.4, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-ruby-yadis.git git] || {{result|fail}}
|-
| ruby-openid      || 2.2.2  || {{result|warn}} 2.1.7 || {{result|fail}}
|-
| rdiscount      || 1.3.1.1 || {{result|warn}}1.6.3.2 || {{result|fail}}
|-
| mime-types      || 1.16  || {{result|pass}} 1.16 || {{result|pass}} 1.16
|-
| diff-lcs        || 1.1.2  || {{result|pass}} 1.1.2  || {{result|pass}} 1.1.2
|-
| oauth          || 0.4.4  || {{result|pass}} 0.4.4 || {{result|fail}}
|-
| paperclip      || 2.7.4  || {{result|inprogress}} 3.1.4, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-paperclip.git git] || {{result|fail}}
|-
| activesupport  || Dep for paperclip (2.3.15)  || {{result|warn}} 3.2.11 in F18 || {{result|fail}}
|-
| activerecord    || Dep for paperclip (2.3.15)  || {{result|warn}} 3.2.11 in F18  || {{result|fail}}
|-
| cocaine        || Dep for paperclip  || {{result|inprogress}} 0.2.1, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-cocaine.git git] || {{result|fail}}
|-
| bourne          || Dep for cocaine    || {{result|inprogress}} 1.1.2, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-bourne.git git] || {{result|fail}}
|-
| state_machine  || 0.9.4  || {{result|warn}} 1.1.2 || {{result|warn}} 1.1.2
|-
| rack            || 1.0.1  || {{result|warn}} 1.4.0  || {{result|warn}} 1.1.0
|-
| riddle          || Dep for thinking-sphinx (1.5.3)  || {{result|inprogress}} 1.5.2, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-riddle.git git] || {{result|fail}}
|-
| mysql2          || Dep for riddle || {{result|inprogress}} 0.3.11, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-mysql2.git git] || {{result|fail}}
|-
| yard            || Dep for riddle || {{result|pass}} 0.7.4 || {{result|fail}}
|-
| rspec-core      || Dep for yard || {{result|pass}} 0.7.4 || {{result|fail}}
|-
| rspec-expectations || Dep for rspec-core || {{result|pass}} 2.8.0 || {{result|fail}}
|-
| rspec-mocks    || Dep for rspec-core || {{result|pass}} 2.8.0 || {{result|fail}}
|-
| builder        || 3.0.0  || {{result|warn}} 2.1.2  || {{result|fail}}
|-
| mysql          || 2.8.1  || {{result|warn}} 2.8.2? || {{result|warn}} 2.8.2?
|-
| validates_url_format_of || 0.1.1  || {{result|inprogress}} 0.3.0, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-validates_url_format_of.git git] || {{result|fail}}
|-
| acts-as-taggable-on || 2.0.6 || {{result|inprogress}} 2.3.3, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-acts-as-taggable-on.git git] || {{result|fail}}
|-
| will_paginate  || 2.3.15 || {{result|warn}} 3.0.2 || {{result|fail}}
|-
| hodel_3000_compliant_logger || 0.1.0 || {{result|inprogress}} 0.1.0, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-hodel_3000_compliant_logger.git git] || {{result|fail}}
|-
| ruby-net-ldap  || 0.0.4 || {{result|warn}} Use net-ldap<ref name="net-ldap">https://gitorious.org/gitorious/mainline/merge_requests/191</ref> || {{result|fail}}  Use net-ldap<ref name="net-ldap" />
|-
| capillary      || 1.0.1  || {{result|inprogress}} 1.0.1, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-capillary.git git] || {{result|fail}}
|-
| mini_shoulda    || Dep for capillary (0.4.0)  || {{result|inprogress}} 0.4.0, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-mini_shoulda.git git] || {{result|fail}}
|-
| nokogiri        || 1.5.0  || {{result|warn}} 1.5.5  || {{result|warn}} 1.4.3.1
|-
|-
| exception_notification || 1.0.20090728 || {{result|inprogress}} 2.6.1, [http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-exception_notification.git git] || {{result|fail}}
| resque-cleaner || {{bz|1037278}}
|-
|-
| revo-ssl_requirement || 1.1.0 || {{result|warn}}unneeded?<ref name="ssl_requirement">[http://stackoverflow.com/questions/3634100/rails-3-ssl-deprecation SSL requirement is built into Rails 3]</ref> || {{result|fail}}
| resque-job-stats || {{bz|1037900}}
|-
|-
| ruby-hmac || 0.4.0 || {{result|warn}} unneeded<ref>https://groups.google.com/d/topic/gitorious/yNDA9ipKe8I/discussion</ref> || {{result|fail}}
| paperclip || {{bz|1065682}}
|-
|-
| json            || 1.5.4  || {{result|warn}} (not needed) || {{result|warn}} 1.4.6
|}
|}


=== Test suite Gem dependencies ===
== Checking progress with rhgc.rb ==


{|
In order to see the list of gems that must still be packaged:
! Gem !! Upstream Gemfile !! Fedora 17 !! EPEL 6
|-
| mocha            || 0.9.10 || {{result|warn}} 0.11.0 || {{result|warn}} 0.9.8
|-
| factory_girl    || 1.3.3  || {{result|warn}} 2.3.2 || {{result|fail}}
|-
| shoulda          || 2.9.1  || {{result|warn}} 2.11.3 || {{result|warn}} 2.11.3
|-
| tuxml            || 0.0.1  || {{result|pass}}unneeded<ref>tuxml is apparently only needed for automated builds inside Hudson. In F17, Gitorious tests crash with "uninitialized constant Test::Unit::AutoRunner::RUNNERS", which comes from tuxml. Remove it and the tests succeed.</ref> || {{result|pass}}
|-
| rots            || git clone (!)  || {{result|fail}} || {{result|fail}}
|-
| capybara        || 1.0.1  || {{result|warn}} 1.1.2  || {{result|fail}}
|-
| rack-test        || Dep for capybara (0.6.1)  || {{result|warn}} 0.6.0  || {{result|warn}} 0.5.4
|-
| selenium-webdriver || Dep for capybara (2.4.0) || {{result|warn}} 2.3.2 || {{result|fail}}
|-
| childprocess    || Dep for selenium-webdriver (0.2.1) || {{result|warn}} 0.2.0  || {{result|fail}}
|-
| ffi              || Dep for selenium-webdriver (1.0.9) || {{result|pass}} 1.0.9 || {{result|fail}}
|-
| multi_json      || Dep for selenium-webdriver (1.0.4) || {{result|warn}} 1.0.3 || {{result|fail}}
|-
| rubyzip          || Dep for selenium-webdriver (0.9.4) || {{result|pass}} 0.9.4 || {{result|fail}}
|-
| xpath            || Dep for capybara (0.1.4)  || {{result|pass}} 0.1.4 || {{result|fail}}
|-
| launchy          || 2.0.5  || {{result|warn}} 0.4.0 || {{result|warn}} 0.3.7
|-
| addressable      || Dep for launchy (2.2.6)  || {{result|pass}} 2.2.6 || {{result|fail}} (unneeded?)
|}


=== Possibly optional Gem dependencies ===
# <code>git clone git://gitorious.org/gitorious/mainline.git gitorious</code>
# <code>git clone git://gist.github.com/movitto/6086381 rhgc</code>
# <code>./rhgc/rhgc.rb --gemfile gitorious/Gemfile</code>


{|
== Gem dependency graph ==
! Gem !! Upstream Gemfile !! Fedora 17 !! EPEL 6
|-
| foreman (for dev) || 0.41.0 || {{result|fail}}  || {{result|fail}}
|-
| thor (for dev)    || Dep for foreman (0.14.6) || {{result|pass}} 0.14.6 || {{result|fail}}
|-
| stompserver      || 0.9 || {{result|fail}}<ref>We just need a stomp-compatible server. [https://olezfdtd.wordpress.com/2010/04/22/install-gitorious-on-your-own-fedora-11-server/#section2 ActiveMQ Messaging Server] would work equally well. The stompserver gem needs [https://github.com/drizztbsd/stompserver/commit/b2dd714f9bc6d7b831767cc0d45d7f00cae2bde5 this patch] to not crash on Ruby 1.9. TBD: investigate the "stompserver_ng" fork.</ref>  || {{result|fail}}
|-
| thin (for dev)  || 1.2 || {{result|warn}} 1.3.1 || {{result|warn}} 1.2.8
|-
| proxymachine (for dev, and git proxy) || 1.2.4 || {{result|warn}} 1.3.1 || {{result|warn}} 1.2.8
|-
| eventmachine  || Dep for proxymachine (0.12.10) || {{result|pass}} 0.12.10 || {{result|pass}} 0.12.10
|-
| rake  (for git proxy) || 0.8.7  || {{result|warn}} 0.9.2.2 || {{result|pass}} 0.8.7
|-
| resque (for resque) || 1.9.8  || {{result|fail}} || {{result|fail}}
|-
| redis (for resque) || 2.2.0  || {{result|fail}} || {{result|fail}}
|-
| redis-namespace (for resque) || 0.7.0  || {{result|fail}} || {{result|fail}}
|-
| sinatra        || 1.0    || {{result|fail}} || {{result|fail}}
|-
| vegas (for resque) || 0.1.11 || {{result|fail}} || {{result|fail}}
|-
| SystemTimer (for resque) || 1.2.3  || {{result|warn}}(gone from Ruby<ref name="SystemTimer">does not build on Fedora 17</ref>) || {{result|fail}}
|-
| stomp (for stomp) || 1.1  || {{result|warn}} 1.2.2 || {{result|warn}} 1.1.8
|-
| activemessaging (for active messaging) || 0.7.1  || (gone from rails?) || {{result|fail}}
|}
 
=== Bundled (vendored) dependencies ===
These deps are bundled in /vendor:
 
{|
! Name !! Bundled version !! Fedora 17 !! EPEL 6
|-
| [https://gitorious.org/diff-display diff-display] || ??? || {{result|fail}}  || {{result|fail}}
|-
| grit || ??? || {{result|warn}} 2.4.1  || {{result|fail}}
|-
| ruby-git || ??? || {{result|warn}} 1.2.5<ref name="rubygem-git">Called "rubygem-git" in Fedora</ref>  || {{result|fail}}
|-
| plugins/localized_dates || ??? || {{result|unknown}}  || {{result|fail}}
|-
| plugins/localized_dates || ??? || {{result|unknown}}  || {{result|fail}}
|-
| plugins/open_id_authentication || ??? || {{result|unknown}}  || {{result|fail}}
|-
| plugins/restful_authentication || ??? || {{result|unknown}}  || {{result|fail}}
|-
| plugins/routing-filter || ??? || {{result|unknown}}  || {{result|fail}}
|-
| plugins/ultrasphinx || ??? || {{result|fail}}  || {{result|fail}}
|}
 
These deps are git submodules under public/javascripts/lib/:
 
{|
! Name !! Bundled version !! Fedora 17 !! EPEL 6
|-
| [https://gitorious.org/buster/buster-core buster-core] || ??? || {{result|fail}}  || {{result|fail}}
|-
| [https://gitorious.org/capillary/capillary-js capillary-js] || ??? || {{result|fail}} || {{result|fail}}
|-
| [https://github.com/DmitryBaranovskiy/raphael.git raphael] || ??? || {{result|fail}} || {{result|fail}}
|-
| [https://github.com/fgnass/spin.js.git spin.js] || ??? || {{result|fail}} || {{result|fail}}
|}


You can view the [http://ktdreyer.fedorapeople.org/gitorious/graph.png outstanding Gem dependency chart] ([http://ktdreyer.fedorapeople.org/gitorious/graph.dot graphviz source]). I will attempt to keep this graph up to date, but it is a manual process. For "live" data, see the rhgc.rb section above.


This graph does not take into account Javascript libraries.


<references />
<references />

Latest revision as of 21:07, 8 July 2014

This document outlines the steps to get Gitorious into Fedora and EPEL.

High Level Steps and Issues

Fedora

  1. Get all Gitorious' dependencies into Fedora.
    • Several Rubygems.
    • Several Javascripts.
  2. Get Gitorious into Fedora.
    • Bundler issues: If we use different Gem versions than upstream, Bundler wants to write to Gemfile and Gemfile.lock. We will use bundler_ext to work around this. This will require the rubygem-bundler_ext package and a lot of testing.
    • Init scripts: Create equivalent systemd unit files for Fedora & RHEL 7.
    • Ruby version: Upstream "master" branch works with Ruby 1.9.3 and 2.0.0. I'm working with upstream to maintain this compatibility via Jenkins.
    • Gem versions: Upstream uses different Gem versions than Fedora has. The biggest difference is Rails, but others are documented below. Plan of attack is to ensure that the test suite passes with both.
    • Javascript libs: There are several Git submodules in upstream (bane, capillary-js, raphael, spin.js, others). We must unbundle these and package them separately.
    • GeoIP data: Gitorious bundles GeoIP.dat, which is already available in Fedora as the "GeoIP" package.
    • FHS considerations: for the Gitorious web application itself, we need to discover how to split up the package to fit the FHS conventions of /etc/, /usr/, and so on.

EPEL

  1. Get all Gitorious's dependencies into EPEL.
    • Rails. I don't have experience packaging Rails, and there's been questions about which version to put into EPEL.
    • Various Rubygems must be branched for EPEL.
  2. Get Gitorious into EPEL.
    • Unfortunately upstream has dropped support for Ruby 1.8, so formal EPEL inclusion can only happen in EPEL 7.

Open review requests

Please review some of these. I'm willing to trade reviews.

Gem Package Review Request
resque-cleaner RHBZ #1037278
resque-job-stats RHBZ #1037900
paperclip RHBZ #1065682

Checking progress with rhgc.rb

In order to see the list of gems that must still be packaged:

  1. git clone git://gitorious.org/gitorious/mainline.git gitorious
  2. git clone git://gist.github.com/movitto/6086381 rhgc
  3. ./rhgc/rhgc.rb --gemfile gitorious/Gemfile

Gem dependency graph

You can view the outstanding Gem dependency chart (graphviz source). I will attempt to keep this graph up to date, but it is a manual process. For "live" data, see the rhgc.rb section above.

This graph does not take into account Javascript libraries.