|
|
| (58 intermediate revisions by 5 users not shown) |
| Line 1: |
Line 1: |
| {{DISPLAYTITLE:Fedora Packaging Guidelines}} | | {{DISPLAYTITLE:Fedora Packaging Guidelines}} |
| Last revised {{REVISIONYEAR}}-{{REVISIONMONTH}}-{{REVISIONDAY2}} by {{REVISIONUSER}}.
| |
|
| |
|
| The Packaging Guidelines are a collection of common issues and the severity that should be placed on them. While these guidelines should not be ignored, they should also not be blindly followed. If you think that your package should be exempt from part of the Guidelines, please bring the issue to the [[Packaging_Committee|Fedora Packaging Committee]].
| | {{admon/warning |The packaging guidelines have been moved out of the wiki. The current version of this document is located at https://docs.fedoraproject.org/en-US/packaging-guidelines/ . Please update your bookmarks.}} |
| | |
| It is the package reviewer's responsibility to point out specific problems with a package and a packager's responsibility to deal with those issues. The reviewer and packager work together to determine the severity of the issues (whether they block a package or can be worked on after the package is in the repository.) Please remember that any package that you submit must also conform to the [[Packaging:ReviewGuidelines|Review Guidelines]] .
| |
| | |
| The original author of these documents is [[TomCallaway| Tom 'spot' Callaway]], though they were originally based on many other documents. They have been significantly modified over the years by many members of the Packaging Committee.
| |
| | |
| Report issues with these guidelines, including typos, [https://fedorahosted.org/fpc/ here]. The wiki discussion pages are not read by the Committee.
| |
| | |
| == General Exception Policy ==
| |
| As these guidelines can never cover all possible contingencies, there will always be packages which need exceptions. It is the packager's responsibility to follow these guidelines as closely as is feasible and to clearly document, as comments in the package specfile, instances where they cannot be followed.
| |
| | |
| If, in a guideline, the language "should" or "is suggested" is used and it is not feasible for the package to conform to that guideline, the packager may deviate from the it. The nature of the deviation and the reasoning behind it MUST be documented in the specfile.
| |
| | |
| Where the language "must", "is required to" or "needs to" is used, the packager may deviate from the guideline only with approval from the packaging committee. Please follow the procedure at the [[Packaging_Committee#Bringing_Issues_to_the_Committee|Packaging Committee]] page for making these requests.
| |
| | |
| == Naming ==
| |
| You should go through the [[Packaging:NamingGuidelines]] to ensure that your package is named appropriately.
| |
| | |
| == Version and Release ==
| |
| Documentation covering the proper way to use the Version and Release fields can be found here: [[Packaging:NamingGuidelines#Package_Versioning]]
| |
| | |
| == Legal ==
| |
| There are various legal concerns to consider when packaging for Fedora.
| |
| | |
| === Licensing ===
| |
| You should review [[Licensing:Main]] and the [[Packaging:LicensingGuidelines]] to ensure that your package is licensed appropriately.
| |
| | |
| === Code Vs Content ===
| |
| It is important to make distinction between computer executable code and content.
| |
| While code is permitted (assuming, of course, that it has an open source compatible license, is not legally questionable, etc.), only some kinds of content are permissable.
| |
| | |
| The rule is this:
| |
| | |
| If the content enhances the OS user experience, then the content is OK to be packaged in Fedora. This means, for example, that things like: fonts, themes, clipart, and wallpaper are OK.
| |
| | |
| Content still has to be reviewed for inclusion. It must have an open source compatible license, must not be legally questionable. In addition, there are several additional restrictions for content:
| |
| * Content must not be pornographic, or contain nudity, whether animated, simulated, or photographed. There are better places on the Internet to get porn.
| |
| * Content should not be offensive, discriminatory, or derogatory. If you're not sure if a piece of content is one of these things, it probably is.
| |
| * All content is subject to review by FESCo, who has the final say on whether or not it can be included.
| |
| | |
| Some examples of content which is permissable:
| |
| | |
| * Package documentation or help files
| |
| * Clipart for use in office suites
| |
| * Background images (non-offensive, discriminatory, with permission to freely redistribute)
| |
| * Fonts (under an open source license, with no ownership/legal concerns)
| |
| * Game levels are not considered content, since games without levels would be non functional.
| |
| * Sound or graphics included with the source tarball that the program or theme uses (or the documentation uses) are acceptable.
| |
| * Game music or audio content is permissible, as long as the content is freely distributable without restriction, and the format is not patent encumbered.
| |
| * Example files included with the source tarball are not considered content.
| |
| | |
| Some examples of content which are not permissable:
| |
| | |
| * Comic book art files
| |
| * Religious texts
| |
| * mp3 files (patent encumbered)
| |
| | |
| If you are unsure if something is considered approved content, ask on fedora-devel-list.
| |
| | |
| === Packages which are not useful without external bits ===
| |
| Some software is not functional or useful without the presence of external code dependencies in the runtime operating system environment. When those external code dependencies are non-free, legally unacceptable, or binary-only (with the exception of permissible firmware), then the dependent software is not acceptable for inclusion in Fedora. If the code dependencies are acceptable for Fedora, then they should be packaged and included in Fedora as a pre-requisite for inclusion of the dependent software. Software which downloads code bundles from the internet in order to be functional or useful is not acceptable for inclusion in Fedora (regardless of whether the downloaded code would be acceptable to be packaged in Fedora as a proper dependency).
| |
| | |
| This also means that packages which are not functional or useful without code or packages from third-party sources are not acceptable for inclusion in Fedora.
| |
| | |
| == No External Kernel Modules ==
| |
| At one point (pre Fedora 8), packages containing "addon" kernel modules were permitted. This is no longer the case. Fedora strongly encourages kernel module packagers to submit their code into the upstream kernel tree.
| |
| | |
| The reference documentation on how to package kernel modules in the "kmod" style has been preserved [[Obsolete/KernelModules|here]] .
| |
| | |
| == No inclusion of pre-built binaries or libraries ==
| |
| All program binaries and program libraries included in Fedora packages must be built from the source code that is included in the source package. This is a requirement for the following reasons:
| |
| * Security: Pre-packaged program binaries and program libraries not built from the source code could contain parts that are malicious, dangerous, or just broken. Also, these are functionally impossible to patch.
| |
| * Compiler Flags: Pre-packaged program binaries and program libraries not built from the source code were probably not compiled with standard Fedora compiler flags for security and optimization.
| |
| | |
| Content binaries (such as .pdf, .png, .ps files) are ''not'' required to be rebuilt from the source code.
| |
| | |
| If you are in doubt as to whether something is considered a program binary or a program library, here is some helpful criteria:
| |
| * Is it executable? If so, it is probably a program binary.
| |
| * Does it contain a .so, ,so.#, or .so.#.#.# extension? If so, it is probably a program library.
| |
| * If in doubt, ask your reviewer. If the reviewer is not sure, they should ask the Fedora Packaging Committee.
| |
| | |
| Packages which require non-open source components to build are also not permitted (e.g. proprietary compiler required).
| |
| | |
| When you encounter prebuilt binaries in a package you '''MUST''':
| |
| | |
| * Remove all pre-built program binaries and program libraries in %prep prior to the building of the package. Examples include, but are not limited to, *.class, *.dll, *.DS_Store, *.exe, *.jar, *.o, *.pyc, *.pyo, *.egg, *.so, *.swf files.
| |
| * Ask upstream to remove the binaries in their next release.
| |
| | |
| {{Anchor|SourceRequirementExceptions}} | |
| === Exceptions ===
| |
| | |
| * Some software (usually related to compilers or cross-compiler environments) cannot be built without the use of a previous toolchain or development environment (open source). If you have a package which meets this criteria, contact the Fedora Packaging Committee for approval. Please note that this exception, if granted, is limited to only the initial build of the package. You may bootstrap this build with a "bootstrap" pre-built binary, but after this is complete, you must immediately increment Release, drop the "bootstrap" pre-built binary, and build completely from source. Bootstrapped packages containing pre-built "bootstrap" binaries must not be pushed as release packages or updates under any circumstances. These packages should contain the necessary logic to be built once bootstrapping is completed and the prebuilt programs are no longer needed. Information about how you should break circular dependencies by bootstrapping can be found here: [[Packaging:Guidelines#Bootstrapping]]
| |
| * An exception is made for binary firmware, as long as it meets the requirements documented here: [[Licensing:Main#Binary_Firmware]]
| |
| * Some pre-packaged program binaries or program libraries may be under terms which do not permit redistribution, or be affected by legal scenarios such as patents. In such situations, simply deleting these files in %prep is not sufficient, the maintainer will need to make a modified source that does not contain these files. See: [[Packaging:SourceURL#When_Upstream_uses_Prohibited_Code]]
| |
| | |
| == Use of pregenerated code ==
| |
| Often a package will contain code which was itself generated by other code. This often takes the form of configure files or parsing code generated by bison/yacc or lex/flex.
| |
| | |
| It is required that the original source files from which the code was generated be included in the srpm. Generally these files are part of the source archive supplied by upstream, but it may be necessary to fetch those files from an upstream source repository and include them in the srpm as separate Source: entries.
| |
| | |
| It is preferred, but not required, that the tools used to generate such code be free software and included in Fedora.
| |
| | |
| It is suggested, but not required, that such code be regenerated as part of the build process. The means for doing this are entirely specific to the individual package being built, but it may happen automatically if the necessary dependencies are present at build time.
| |
| | |
| == Spec File Naming ==
| |
| The spec file '''must''' be named <code>%{name}.spec</code>. That is, if your package is named <code>example</code>, the spec file must be named <code>example.spec</code>.
| |
| | |
| == Spec Legibility ==
| |
| All Fedora Package Spec Files must be legible. If the reviewer is unable to read the spec file, it will be impossible to perform a review.
| |
| | |
| To help facilitate legibility, only macros and conditionals for Fedora and EPEL are allowed to be used in Fedora Packages. Use of macros and conditionals for other distros, including Fedora derivatives, is not permitted in spec files of packages in the main Fedora repositories (unless those macros and conditionals are also present in Fedora).
| |
| | |
| == Writing a package from scratch ==
| |
| When writing a package from scratch, it is often convenient base your spec file on the Fedora specfile template (see [[Rpmdevtools]]). However, note that this file can occasionally diverge from recommended practice as the packaging guidelines change. Also, please put your preferences about spec file formatting and organization aside and try to conform to this template as much as possible. This is not because we believe this is the only right way to write a spec file, but because it makes it simpler for others to assist in the maintenance of those packages and often it makes it easier for QA to spot mistakes and quickly understand what you are trying to do.
| |
| | |
| == Modifying an existing package ==
| |
| If you base a package on an existing non-Fedora package, be careful to verify its correctness and to understand exactly what goes on. Do not submit a package without knowing what those strange, but innocent-looking commands do.
| |
| | |
| In particular, you should
| |
| *verify any sources and patches.
| |
| *verify that the license stated in the spec file matches the actual license of the software (see [[#tags| Tags]] ),
| |
| *skim the summary and description for typos and oddities (see [[#summary| Summary and description]] ),
| |
| *make sure that the correct build root is used,
| |
| *ensure that macro usage is consistent (see [[#macros| Macros]] ).
| |
| | |
| Keep old changelog entries to credit the original authors. Entries that are several years old or refer to ancient versions of the software may be erased. If you end up doing radical changes and re-write most of the spec file anyway, feel free to start the changelog from scratch. In other words, use your best judgement.
| |
| | |
| {{Anchor|ArchitectureSupport}}
| |
| == Architecture Support ==
| |
| All Fedora packages must successfully compile and build into binary rpms on at least one supported primary architecture, except where the package is useful only on a secondary architecture (such as an architecture-specific boot utility, microcode loader, or hardware configuration tool). Fedora packagers should make every effort to support all [[Architectures#Primary_Architectures|primary architectures]].
| |
| | |
| Content, code which does not need to compile or build, and architecture independent code (noarch) are notable exceptions.
| |
| | |
| === Architecture Build Failures ===
| |
| If a Fedora package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in <code>ExcludeArch</code>. Each architecture listed in <code>ExcludeArch</code> needs to have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number should then be placed in a comment, next to the corresponding <code>ExcludeArch</code> line. New packages will not have bugzilla entries during the review process, so they should put this description in the comment until the package is approved, then file the bugzilla entry, and replace the long explanation with the bug number. The bug should be marked as blocking one (or more) of the following bugs to simplify tracking such issues:
| |
| | |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-x86 F-ExcludeArch-x86]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-x64 F-ExcludeArch-x64]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-ARM F-ExcludeArch-ARM]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-aarch64 F-ExcludeArch-aarch64]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-ppc F-ExcludeArch-ppc]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-ppc64 F-ExcludeArch-ppc64]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-ppc64le F-ExcludeArch-ppc64le]
| |
| * [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=F-ExcludeArch-s390x F-ExcludeArch-s390x]
| |
| | |
| === Noarch with unported dependencies ===
| |
| | |
| Sometimes you are working on a noarch package that can only run in locations that a different, arched package builds on. This is common for packages written in a scripting language which depend on the language's interpreter package, for instance. If the arched package that your package deps on isn't available on all architectures Fedora (or EPEL) targets you run into a situation where you may need to exclude your package from certain architectures' package repositories or prevent it from building on certain architectures in the buildsystem.
| |
| | |
| ==== Requires ====
| |
| | |
| When your package needs the problematic dependency at runtime but not at build time then you only need to keep it from entering the package repositories for that architecture. There is a relatively simple workaround for this:
| |
| | |
| <pre>
| |
| BuildArch: noarch
| |
| # List the arches that the dependent package builds on below
| |
| ExclusiveArch: %{ix86} %{arm} x86_64 noarch
| |
| </pre>
| |
| | |
| Sometimes a language runtime you are packaging for will provide a macro for the arches it's available on, for instance, <code>%{nodejs_arches}</code>. If it does exist, then you can use something like <code>ExclusiveArch:%{nodejs_arches} noarch</code> in your spec file. Take a look at the Guidelines for the language to see if such a macro exists.
| |
| | |
| ==== BuildRequires ====
| |
| | |
| Building a noarch package that has a dependency that isn't available on all arches is much more difficult to handle. There is no way to specify architectures to exclude building on that koji will apply to a noarch package build. Koji attempts to use any available builder to build a noarch package.
| |
| | |
| In this case packagers '''MUST''' make their packages architecture specific. Koji will then be able to use the package's <code>ExclusiveArch:</code> tag to tell what architectures cannot be used to build:
| |
| | |
| <pre>
| |
| # Cannot build as noarch until foo-lang is ported to arm.
| |
| # Comment out BuildArch: noarch for now.
| |
| # BuildArch: noarch
| |
| ExclusiveArch: %{ix86} x86_64
| |
| </pre>
| |
| | |
| Packagers are sometimes tempted to continue to keep the package noarch and simply resubmit the package when it fails. However this is a very kludgey and manual method. A big drawback is that automated mass rebuilds will generate failed builds simply because the package hit a builder of the wrong architecture.
| |
| | |
| ==== Conditionalizing Builds for Architecture ====
| |
| Packages '''MUST NOT''' have <code>SourceN:</code> or <code>PatchN:</code> tags which are conditionalized on architecture. For instance:
| |
| | |
| <pre>
| |
| # Incorrect
| |
| %ifarch ppc64
| |
| Patch0: build-fix-for-ppc64.patch
| |
| %endif
| |
| </pre>
| |
| | |
| Conditionalizing Source and Patch tags by architecture makes it so the built SRPM may not contain everything needed to rebuild itself on a different architecture (If the example above was built into an SRPM on x86 then the SRPM would not contain Patch0. This would mean the SRPM would not contain all the files needed to be built on a ppc64 computer.)
| |
| | |
| The best strategy for things like this is to write code that can be built on any architecture (using conditionals in the code to handle incompatibilities between architectures if necessary). The second best strategy is to use spec file conditionals only when utilizing the value of a Source or Patch tag like this:
| |
| | |
| <pre>
| |
| %prep
| |
| [...]
| |
| %ifarch ppc64
| |
| %patch0 -p1
| |
| %endif
| |
| </pre>
| |
| | |
| {{Anchor|layout}}
| |
| | |
| == Filesystem Layout ==
| |
| | |
| Fedora follows the [http://www.pathname.com/fhs/ Filesystem Hierarchy Standard] with regards to filesystem layout, with exceptions noted below. The FHS defines where files should be placed on the system.
| |
| | |
| === Exceptions ===
| |
| | |
| * Fedora allows cross-compilers to place files in <code>/usr/target</code>.
| |
| | |
| * Fedora does not allow new directories directly under <code>/</code> or <code>/usr</code> without FPC approval.
| |
| | |
| === Libexecdir ===
| |
| | |
| The [http://www.pathname.com/fhs/ Filesystem Hierarchy Standard] does not include any provision for libexecdir, but Fedora packages may store appropriate files there. Libexecdir (aka, <code>/usr/libexec</code> on Fedora systems) should only be used as the directory for executable programs that are designed primarily to be run by other programs rather than by users.
| |
| | |
| Fedora's rpm includes a macro for libexecdir, <code>%{_libexecdir}</code>. Packagers are highly encouraged to store libexecdir files in a package-specific subdirectory of <code>%{_libexecdir}</code>, such as <code>%{_libexecdir}/%{name}</code>.
| |
| | |
| If upstream's build scripts support the use of <code>%{_libexecdir}</code> then that is the most appropriate place to configure it (eg. passing <code>--libexecdir=%{libexecdir}/%{name}</code> to autotools configure). If upstream's build scripts do not support that, <code>%{_libdir}/%{name}</code> is a valid second choice. If you have to patch support for using one of these directories in, then you should patch in LIBEXECDIR, preferably configurable at build time (so distributions that do not have <code>/usr/libexec</code> can set LIBEXECDIR to another directory more appropriate for their distro.
| |
| | |
| === Multilib Exempt Locations ===
| |
| If a package is exempt from multilib, it may use <code>%{_prefix}/lib</code> instead of <code>%{_libdir}</code>. Packages that contain architecture specific files that would ordinarily be installed into <code>%{_libexecdir}</code> are always considered ineligible for multilib. However, you should be sure that the (sub)package that they are in does not have other content that would be considered eligible for multilib. If this is not the case for the files you wish to do this in for your package or you are just unsure, ask FESCo for an explicit multilib exemption.
| |
| | |
| === <code>/run</code> ===
| |
| System services should store small volatile run-time data in <code>/run</code>. This is a tmpfs backed directory that is mounted in very early boot, before any services are started (and before <code>/var</code> is available). <code>/var/run</code> is a legacy symlink to <code>/run</code>.
| |
| | |
| === No Files or Directories under /srv, /usr/local, or /home/$USER ===
| |
| | |
| The [http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM FHS says] :
| |
| | |
| <pre>
| |
| "...no program should rely on a specific subdirectory structure of /srv existing
| |
| or data necessarily being stored in /srv. However /srv should always exist on FHS
| |
| compliant systems and should be used as the default location for such data.
| |
| | |
| Distributions must take care not to remove locally placed files in these
| |
| directories without administrator permission."
| |
| </pre>
| |
| | |
| The FHS is explicitly handing control of the directory structure under <code>/srv</code> to the system administrator rather than the distribution. Therefore, no Fedora packages can have any files or directories under <code>/srv</code>, come preconfigured to use specific files or directories under <code>/srv</code>, to remove files there, or to modify the files there in any way.
| |
| | |
| In addition, no Fedora package can contain files or directories or modify files under:
| |
| * <code>/usr/local</code> as these directories are not permitted to be used by Distributions in the FHS
| |
| * <code>/home/$USER</code> as users can arbitrarily modify the files in their home directories and rpm packages that modify those files run the risk of destroying user data. Additionally, sites may be nfs mounting <code>/home</code> on many different types of systems or even network automounting them on demand. Modifying files in home directories that are thus configured will have negative effects in both of these situations.
| |
| | |
| It is important to note that the software in a Fedora package, once installed and configured by a user, can use <code>/srv</code> as a location for data. The package simply must not do this out of the box
| |
| | |
| === Limited usage of /opt, /etc/opt, and /var/opt ===
| |
| | |
| <code>/opt</code> and its related directories (<code>/etc/opt</code> and <code>/var/opt</code>) is reserved for the use of vendors in the FHS. We have reserved the <code>fedora</code> name with [http://www.lanana.org/lsbreg/providers/providers.txt LANANA] for our use. If a package installs files into <code>/opt</code> it may only use directories in the <code>/opt/fedora</code> hierarchy. Fedora attempts to organize this directory by allocating a subdirectory of our <code>/opt/fedora</code> directory for specific subsystems. If you think you need to use <code>/opt/fedora</code> please file an FPC ticket to decide whether it's a valid use of <code>/opt</code> and what subdirectory should be allocated for your use.
| |
| | |
| Currently, we have allocated <code>/opt/fedora/scls</code>, <code>/etc/opt/fedora/scls</code>, and <code>/var/opt/fedora/scls</code> for use by [[User:Toshio/SCL_Guidelines_(draft)| Software Collections]].
| |
| | |
| === Effect of the UsrMove Fedora Feature ===
| |
| | |
| Fedora has merged several directories in <code>/</code> with their counterparts in <code>/usr/</code>.
| |
| | |
| <table>
| |
| <tr><td>
| |
| /bin
| |
| </td><td>/usr/bin aka %{_bindir}
| |
| </td></tr>
| |
| <tr><td>
| |
| /sbin
| |
| </td><td>
| |
| /usr/sbin aka %{_sbindir}
| |
| </td></tr>
| |
| <tr><td>
| |
| /lib64 or /lib
| |
| </td><td>
| |
| /usr/lib64 or /usr/lib aka %{_libdir}
| |
| </td></tr>
| |
| <tr><td>
| |
| /lib
| |
| </td><td>
| |
| /usr/lib aka %{_prefix}/lib
| |
| </td></tr>
| |
| </table>
| |
| | |
| For example, end users will find that <code>/bin/sh</code> is the same file as <code>/usr/bin/sh</code>.
| |
| | |
| However, rpm file dependencies don't work according to what's on the filesystem, they work according to the path specified in the rpm <code>%files</code> section. So an rpm which specified:
| |
| | |
| <pre>
| |
| %files
| |
| /bin/sh
| |
| </pre>
| |
| | |
| would be able to satisfy a file dependency for <code>/bin/sh</code> but not for <code>/usr/bin/sh</code>. As a packager you may need to pay attention to where other packages expect to find your files. Things that history has placed into <code>/bin</code>, <code>/sbin</code>, <code>/lib</code>, or <code>/lib64</code> should be listed in the <code>%files</code> section as being in those directories. Things that history placed in <code>/usr/bin</code>, <code>/usr/sbin</code>, etc, should be listed in the <code>%files</code> section as being in <code>%{_bindir}</code>, <code>%{_sbindir}</code>, etc. If you feel that there is some historical confusion as to which directory a program is placed in, you can use a Virtual Provides to list the alternate path. For instance:
| |
| | |
| <pre>
| |
| Provides: %{_sbindir}/ifconfig
| |
| [...]
| |
| %files
| |
| /sbin/ifconfig
| |
| </pre>
| |
| | |
| If you are a packager who uses file dependencies to Require the proper dependencies then you may need to make sure that the file dependencies are pointing to the location that the packager of that file specified to rpm. Here's an example of doing this:
| |
| | |
| <pre>
| |
| $ rpm -ql $(rpm -qf /usr/sbin/ifconfig)|grep sbin/ifconfig
| |
| /sbin/ifconfig
| |
| </pre>
| |
| | |
| So you'd want to use <code>Requires: /sbin/ifconfig</code> in your spec file.
| |
| | |
| == Use rpmlint ==
| |
| Run rpmlint on binary and source rpms to examine them for common errors, and fix them (unless rpmlint is wrong, which can happen, too). If you find rpmlint's output cryptic, the <code>-i</code> switch to it can be used to get more verbose descriptions of most errors and warnings. Note that rpmlint will perform additional checks if given the name of an installed package. For example, <code>dnf install foo-1.0-1.f20.x86_64.rpm; rpmlint foo</code> will perform a set of tests on the foo package that <code>rpmlint foo-1.0-1.f20.x86_64.rpm</code> cannot. A community-maintained page on rpmlint issues can be found [[Common_Rpmlint_issues|here]].
| |
| | |
| == Tags and Sections ==
| |
| * The <code>Copyright:</code>, <code>Packager:</code>, <code>Vendor:</code> and <code>PreReq:</code> tags MUST NOT be used.
| |
| * The <code>BuildRoot:</code> tag and <code>%clean</code> section SHOULD NOT be used.
| |
| * The contents of the buildroot SHOULD NOT be removed in the first line of <code>%install</code>.
| |
| * The <code>Summary:</code> tag value SHOULD NOT end in a period.
| |
| * The <code>Source:</code> tags document where to find the upstream sources for the package. In most cases this SHOULD be a complete URL to the upstream tarball. For special cases, please see the [[Packaging:SourceURL|SourceURL Guidelines]].
| |
| * The <code>Group:</code> tag is unnecessary.
| |
| | |
| == Package dependencies ==
| |
| RPM has very good capabilities of automatically finding dependencies for libraries and eg. Perl modules. In short, don't reinvent the wheel, but just let rpm do its job. There is usually no need to explicitly list eg. Requires: libX11 when the dependency has already been picked up by rpm in the form of depending on libraries in the libX11 package.
| |
| | |
| Build requirements are different. There's no automatic dependency find procedure for them, which means that you must explicitly list stuff that the package requires to build successfully. Typically, some -devel packages are listed there. Refer to the [[#BuildRequires| BuildRequires section]] .
| |
| | |
| Sometimes we know that a package requires eg. gtk+-devel 1.2 or newer to build (and thus gtk+ 1.2 or newer to run, but that's handled automatically). There are two things to consider here:
| |
| | |
| First, if the lowest possible requirement is so old that nobody has a version older than that installed on any target distribution release, there's no need to include the version in the dependency at all. In that case we know the available software is new enough. For example, the version in gtk+-devel 1.2 dependency above is unnecessary for all Red Hat Linux distributions since (at least) release 6.2. As a rule of thumb, if the version is not required, don't add it just for fun.
| |
| | |
| Second, the Epoch (if used) must be listed when adding a versioned dependency to achieve robust epoch-version-release comparison. See [[#Use_of_Epochs]] for details. A quick way to check the Epoch of package foo is to run:
| |
| | |
| <code>rpm --query --qf "%{EPOCH}\n" packagename</code>
| |
| | |
| Typically, the requirements for -devel packages need yet another look. They're not usually picked up automatically by rpm; and unless the generated RPMs will be noarch, -devel package dependencies on other -devel packages should be arch-specific.
| |
| | |
| A dependency is made arch-specific by appending the macro %{?_isa} to the package name. For example:
| |
| <pre>
| |
| Requires: foo
| |
| </pre>
| |
| becomes:
| |
| <pre>
| |
| Requires: foo%{?_isa}
| |
| </pre>
| |
| | |
| If the foo-devel package has a foo-config script, you can try doing a foo-config --libs and foo-config --cflags to get strong hints what packages should be marked as foo's requirements. For example:
| |
| | |
| <pre>
| |
| $ gtk-config --cflags
| |
| -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include
| |
| $ gtk-config --libs
| |
| -L/usr/lib -L/usr/X11R6/lib -lgtk -lgdk -rdynamic -lgmodule -lglib -ldl -lXi -lXext -lX11 -lm
| |
| </pre>
| |
| | |
| This means that gtk+-devel should contain
| |
| | |
| <code>Requires: glib-devel%{?_isa} libXi-devel%{?_isa} libXext-devel%{?_isa} libX11-devel%{?_isa}</code>
| |
| | |
| === Weak dependencies ===
| |
| | |
| Weak dependencies (<code>Recommends:</code>, <code>Suggests:</code>, <code>Supplements:</code> and <code>Enhances:</code>) can be used to specify relationships between packages which are less strict than mandatory requirements. Please see [[Packaging:WeakDependencies]] for guidelines on using these tags.
| |
| | |
| === Rich/Boolean dependencies ===
| |
| | |
| Packages for Fedora 23 and later may make limited use of the rich (or Boolean) dependency feature [[http://www.rpm.org/wiki/PackagerDocs/BooleanDependencies]] supported in RPM 4.13. They may be used in <code>Suggests:</code>, <code>Enhances:</code> and <code>Supplements:</code> dependencies. However they may '''not''' currently be used in <code>Requires:</code> or <code>Recommends:</code> dependencies as this will cause issues with the package updates process.
| |
| | |
| Rich/Boolean dependencies are not supported in Fedora 22.
| |
| | |
| === File Dependencies ===
| |
| | |
| RPM gives you the ability to depend on files instead of packages. Whenever possible you should avoid file dependencies as they slow down dependency resolution and require the package manager to download file lists in addition to to regular dependency information. There are, however, times when other technical considerations outweigh these considerations. If the files you need are prone to moving between packages of different names, it can be useful to depend on those files directly.
| |
| | |
| === Explicit Requires ===
| |
| Explicit Requires are Requires added manually by the packager in the spec file. Packages must not contain unnecessary explicit Requires on libraries. We generally rely on rpmbuild to automatically add dependencies on library SONAMEs. Modern package management tools are capable of resolving such dependencies to determine the required packages in many cases. However, present versions of rpmbuild only add deps on library SONAMES, not the library's full version. This can be a problem if a library has added features over the course of time without backwards incompatibilities that would cause SONAMES to be changed. This can lead to a case where the user has an old version of a library installed, the new version of the library with new ABI is built in Fedora and an application using that ABI is built. If the user just attempts to install or update that one application without also updating the library, the application will install fine (because the SONAME dependency is satisfied) but will fail when run because the library installed on the system is missing features it needs.
| |
| | |
| Although you do need to add explicit library dependencies to keep this from occurring, there are drawbacks to manually specifying this in all your packages. History has shown that such dependencies add confusion when library/files are moved from one package to another, when packages get renamed, when one out of multiple alternative packages would suffice, and when versioned explicit dependencies become out-of-date and inaccurate. Additionally, in some cases, old explicit dependencies on package names require unnecessary updates/rebuilds. For example, Fedora packages are only required to retain historical provides for two full release cycles.
| |
| | |
| Because of this and because we hope to have this fixed in rpmbuild, this is something to be aware of but it's not required that you explicitly specify the libraries you require with their version information.
| |
| | |
| When explicit library Requires are necessary, explicit library dependencies should typically be arch-specific (unless the packages involved are noarch) and there should be a spec file comment justifying it:
| |
| | |
| <pre>
| |
| # The automatic dependency on libfubar.so.1 is insufficient,
| |
| # as we strictly need at least the release that fixes two segfaults.
| |
| Requires: libfubar%{?_isa} >= 0:1.2.3-7
| |
| </pre>
| |
| | |
| Packagers should revisit an explicit dependency as appropriate to avoid it becoming inaccurate and superfluous. For instance in the example above, when no current Fedora release shipped with libfubar < 1.2.3-7, it is no longer necessary to list the explicit, versioned requirement.
| |
| | |
| === Filtering Auto-Generated Requires ===
| |
| RPM attempts to auto-generate Requires (and Provides) at build time, but in some situations, the auto-generated Requires/Provides are not correct or not wanted. For more details on how to filter out auto-generated Requires or Provides, please see: [[Packaging:AutoProvidesAndRequiresFiltering]]
| |
| | |
| {{Anchor|BuildRequires}}
| |
| | |
| == BuildRequires ==
| |
| | |
| It is important that your package list all necessary build dependencies using the <code>BuildRequires:</code> tag. You may assume that enough of an environment exists for RPM to function, to build packages and execute basic shell scripts, but you should not assume any other packages are present as RPM dependencies and anything brought into the buildroot by the build system may change over time.
| |
| | |
| === BuildRequires and %{_isa} ===
| |
| | |
| You '''MUST NOT''' use arched BuildRequires. The arch ends up in the built SRPM but SRPMs need to be architecture independent. For instance, if you did this:
| |
| <pre>
| |
| # Example of what *not* to do
| |
| BuildRequires: python%{?_isa} >= 2.7
| |
| </pre>
| |
| | |
| Then the SRPM that is built in Fedora would have one of these Requirements depending on what builder the SRPM was created on:
| |
| | |
| <pre>
| |
| python(x86-32) >= 2.7
| |
| # or
| |
| python(x86-64) >= 2.7
| |
| </pre>
| |
| | |
| This would prevent yum-builddep or similar tools that use the SRPM's requirements from operating correctly.
| |
| | |
| {{Anchor|ConditionalDependencies}}
| |
| | |
| === BuildRequires based on pkg-config ===
| |
| | |
| Fedora packages which use <code>pkg-config</code> to build against a library (e.g. 'foo') on which they depend, '''SHOULD''' express their build dependency correctly as <code>pkgconfig(foo)</code>. For more information, see [[Packaging:PkgConfigBuildRequires]].
| |
| | |
| == Conditional build-time dependencies ==
| |
| If the spec file contains conditional dependencies selected based on presence of optional <code>--with(out) foo</code> arguments to <code>rpmbuild</code>, build the source RPM to be submitted with the default options, ie. so that none of these arguments are present in the <code>rpmbuild</code> command line. The reason is that those requirements get "serialized" into the resulting source RPM, ie. the conditionals no longer apply.
| |
| | |
| {{Anchor|summary}}
| |
| | |
| == Summary and description ==
| |
| The summary should be a short and concise description of the package. The description expands upon this. Do not include installation instructions in the description; it is not a manual. If the package requires some manual configuration or there are other important instructions to the user, refer the user to the documentation in the package. Add a ''README.Fedora'', or similar, if you feel this is necessary. Also, please make sure that there are no lines in the description longer than 80 characters.
| |
| | |
| Please put personal preferences aside and use American English spelling in the summary and description. Packages can contain additional translated summary/description for supported Non-English languages, if available.
| |
| | |
| === Trademarks in Summary or Description ===
| |
| Packagers should be careful how they use trademarks in Summary or Description. There are a few rules to follow:
| |
| * Never use "(TM)" or "(R)" (or the unicode equivalents, ™/®). It is incredibly complicated to use these properly, so it is actually safer for us to not use them at all.
| |
| * Use trademarks in a way that is not ambiguous. Avoid phrasing like "similar to" or "like". Some examples:
| |
| | |
| * '''BAD:''' It is similar to Adobe Photoshop.
| |
| * '''GOOD:''' It supports Adobe Photoshop PSD files, ...
| |
| | |
| * '''BAD:''' A Linux version of Microsoft Office
| |
| * '''GOOD:''' A word-processor with support for Microsoft Office DOC files
| |
| | |
| If you're not sure, ask yourself, is there any chance someone may get confused and think that this package is the trademarked item? When in doubt, try to leave the trademark out.
| |
| | |
| {{Anchor|PackageEncoding}}
| |
| | |
| == Encoding ==
| |
| Unless you need to use characters outside the [http://commons.wikimedia.org/wiki/Image:Ascii_full.png ASCII repertoire] , you will not need to be concerned about the encoding of the spec file. If you do need non-ASCII characters, save your spec files as UTF-8. If you're in doubt as to what characters are ASCII, please refer to [http://commons.wikimedia.org/wiki/Image:Ascii_full.png this chart] .
| |
| | |
| {{Anchor|FilenameEncoding}}
| |
| === Non-ASCII Filenames ===
| |
| Similarly, filenames that contain non-ASCII characters must be encoded as UTF-8. Since there's no way to note which encoding the filename is in, using the same encoding for all filenames is the best way to ensure users can read the filenames properly. If upstream ships filenames that are not encoded in UTF-8 you can use a utility like convmv (from the convmv package) to convert the filename in your %install section.
| |
| | |
| {{Anchor|PackageDocumentation}}
| |
| == Documentation ==
| |
| Any relevant documentation included in the source distribution should be included in the package in the proper documentation directory. Irrelevant documentation includes build instructions, the omnipresent ''INSTALL'' file containing generic build instructions, for example, and documentation for non-Linux systems, e.g. ''README.MSDOS''. Also pay attention about which subpackage you include documentation in. For example API documentation belongs in the <code>-devel</code> subpackage, not the main one. Or if there's a lot of documentation, consider putting it into a subpackage. In this case, it is recommended to use <code>*-doc</code> as the subpackage name.
| |
| | |
| Marking a ''relative'' path with <code>%doc</code> in the <code>%files</code> section will cause RPM to copy the referenced file or directory from <code>%_builddir</code> to the proper location for documentation. Files can also be placed in <code>%_pkgdocdir</code>, and the build scripts of the software being packaged may do this automatically when called in <code>%install</code>. However, mixing these methods is problematic and may result in duplicated or conflicting files, so use of <code>%doc</code> with ''relative'' paths and installation of files directly into <code>%_pkgdocdir</code> in the same source package is forbidden.
| |
| | |
| Files marked as documentation must not cause the package to pull in more dependencies than it would without the documentation. One simple way to ensure this in most cases is to remove all executable permissions from files in <code>%_pkgdocdir</code>.
| |
| | |
| Files located in <code>%_pkgdocdir</code> must not affect the runtime of the packaged software. The software must function properly and with unchanged functionality if those files are modified, removed or not installed at all.
| |
| | |
| Although license files are documentation, they are treated specially (including using a different tag. Please see [[Packaging:LicensingGuidelines]] for how to handle them.
| |
| | |
| == Changelogs ==
| |
| ''Every time'' you make changes, that is, whenever you increment the E-V-R of a package, add a changelog entry. This is important not only to have an idea about the history of a package, but also to enable users, fellow packages, and QA people to easily spot the changes that you make.
| |
| | |
| If a particular change is related to a Bugzilla bug, include the bug ID in the changelog entry for easy reference, e.g.
| |
| | |
| <pre>
| |
| * Wed Jun 14 2003 Joe Packager <joe at gmail.com> - 1.0-2
| |
| - Added README file (#42).
| |
| </pre>
| |
| | |
| You must use one of the following formats:
| |
| <pre>
| |
| * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> - 0.6-4
| |
| - And fix the link syntax.
| |
| </pre>
| |
| | |
| <pre>
| |
| * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> 0.6-4
| |
| - And fix the link syntax.
| |
| </pre>
| |
| | |
| <pre>
| |
| * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com>
| |
| - 0.6-4
| |
| - And fix the link syntax.
| |
| </pre>
| |
| | |
| Changelog entries should provide a brief summary of the changes done to the package between releases, including noting updating to a new version, adding a patch, fixing other spec sections, note bugs fixed, and CVE's if any. They must never simply contain an entire copy of the source CHANGELOG entries. The intent is to give the user a hint as to what changed in a package update without overwhelming them with the technical details. Links to upstream changelogs can be entered for those who want additional information.
| |
| If you wish to "scramble" or "obfuscate" your email address in the changelog, you may do so, provided that it is still understandable by humans.
| |
| | |
| === Multiple Changelog Entries per Release ===
| |
| In some situations, it may be useful for packagers to have multiple changelog entries in the spec file, but not increment the release field for each one. There are two supported methods for doing this:
| |
| | |
| ==== Updating and replacing the existing date line ====
| |
| | |
| In this situation, you have added this changelog entry, but have not built the package yet:
| |
| | |
| <pre>
| |
| * Nov 12 2010 Toshio Kuratomi <toshio_fedoraproject.org> - 1.0-1
| |
| - Fix spelling errors in package description
| |
| </pre>
| |
| | |
| The next day, you make additional changes to the spec, and need to add a new changelog line, then you would update the existing date line for 1.0-1, and append any new notes, making the changelog look like this:
| |
| | |
| <pre>
| |
| * Nov 13 2010 Toshio Kuratomi <toshio_fedoraproject.org> - 1.0-1
| |
| - Fix spelling errors in package description
| |
| - Add a patch to fix compilation problems on F15
| |
| </pre>
| |
| | |
| Please remember that this is only acceptable if 1.0-1 has not yet been built.
| |
| | |
| You can do this any number of times, until you actually build 1.0-1 in the buildsystem. Once you've done that, you must change the E-V-R and any new entries should be added as described in [[Packaging:Guidelines#Changelogs|Changelogs]].
| |
| | |
| ==== Repeat the old version release with a new entry ====
| |
| | |
| In this situation, you have added this changelog entry, but have not built the package yet:
| |
| | |
| <pre>
| |
| * Nov 12 2010 Toshio Kuratomi <toshio_fedoraproject.org> - 1.0-1
| |
| - Fix spelling errors in package description
| |
| </pre>
| |
| | |
| The next day, you make additional changes to the spec, and need to add a new changelog line. Now, you can add an additional changelog item with the new date, but the same Version-Release, so your new changelog looks like this:
| |
| | |
| <pre>
| |
| * Nov 13 2010 Toshio Kuratomi <toshio_fedoraproject.org> - 1.0-1
| |
| - Add a patch to fix compilation problems on F15
| |
| | |
| * Nov 12 2010 Toshio Kuratomi <toshio_fedoraproject.org> - 1.0-1
| |
| - Fix spelling errors in package description
| |
| </pre>
| |
| | |
| Please remember that this is only acceptable if 1.0-1 has not yet been built.
| |
| | |
| You can do this any number of times, until you actually build 1.0-1 in the buildsystem. Once you've done that, you must change the E-V-R and any new entries should be added as described in [[Packaging:Guidelines#Changelogs|Changelogs]].
| |
| | |
| == Manpages ==
| |
| | |
| As man pages are the traditional method of getting help on a Unix system, packages should contain them for all executables. If some man pages are absent, packagers should work with upstream to add them. It is also occasionally possible to find pages created by other distributions, or to use the output of the help2man program; those are often useful as a starting point. When installing man pages, note that they should be installed uncompressed as the build system will compress them as needed. The compression method may change, so it is important to reference the pages in the %files section with a pattern that takes this into account:
| |
| | |
| <pre>
| |
| %files
| |
| %{_mandir}/man1/foo.1*
| |
| </pre>
| |
| | |
| == Compiler ==
| |
| Fedora uses gcc as the compiler (for all languages that gcc supports). Packages may only build with an alternative compiler to gcc if upstream does not support gcc.
| |
| | |
| {{Anchor|CompilerFlags}}
| |
| == Compiler flags ==
| |
| Compilers used to build packages must honor the applicable compiler flags set in the system rpm configuration. Honoring means that the contents of that variable is used as the basis of the flags actually used by the compiler during the package build.
| |
| | |
| For C, C++, and Fortran code, the [[Packaging:RPMMacros#Build_flags_macros_and_variables| %{optflags} macro]] contains these flags.
| |
| Overriding these flags for performance optimizations (for instance, -O3 instead of -O2) is generally discouraged. If you can present benchmarks that show a
| |
| significant speedup for this particular code, this could be revisited on a case-by-case basis. Adding to and overriding or filtering parts of
| |
| these flags is permitted if there's a good reason to do so; the rationale for doing so must be documented in the specfile.
| |
| | |
| There are certain, security related flags that are commonly allowed. These flags may degrade performance slightly but the increased security can be worthwhile for some programs.
| |
| | |
| === PIE ===
| |
| | |
| PIE adds security to executables by composing them entirely of position-independent code. Position-independent code (PIC) is machine instruction code that executes properly regardless of where in memory it resides. PIE allows Exec Shield to use address space layout randomization to prevent attackers from knowing where existing executable code is during a security attack using exploits that rely on knowing the offset of the executable code in the binary, such as return-to-libc attacks.
| |
| | |
| To use this in your spec, add:
| |
| | |
| <pre>
| |
| %global _hardened_build 1
| |
| </pre>
| |
| | |
| This adds <code>-fPIC</code> (if <code>-fPIE</code> is not already present) to the compiler flags, and adds <code>-z now</code> to the linker flags.
| |
| | |
| If your package meets any of the following criteria you <b>MUST</b> enable the PIE compiler flags:
| |
| | |
| * Your package is long running. This means it's likely to be started and keep running until the machine is rebooted, not start on demand and quit on idle.
| |
| | |
| * Your package has suid binaries, or binaries with capabilities.
| |
| | |
| * Your package runs as root.
| |
| | |
| If your package meets the following criteria you <b>should consider</b> enabling the PIE compiler flags:
| |
| | |
| * Your package accepts/processes untrusted input.
| |
| | |
| FESCo maintains a [[Hardened_Packages|list of packages]] that <b>MUST</b> have PIE turned on. Other packages may enable the flags at the maintainer's discretion.
| |
| | |
| There are some notable disadvantages to enabling PIE that should be considered in making the decision:
| |
| | |
| * Some code does not compile with PIE (or does not function properly).
| |
| | |
| * You can not use prelink on PIE enabled binaries, resulting in a slower startup time.
| |
| | |
| {{Anchor|Debuginfo}}
| |
| | |
| == Debuginfo packages ==
| |
| Packages should produce useful <code>-debuginfo</code> packages, or explicitly disable them when it is not possible to generate a useful one but rpmbuild would do it anyway. Whenever a <code>-debuginfo</code> package is explicitly disabled, an explanation why it was done is required in the specfile. Debuginfo packages are discussed in more detail in a separate document, [[Packaging:Debuginfo]] .
| |
| | |
| {{Anchor|DevelPackages}}
| |
| == Devel Packages ==
| |
| | |
| Fedora packages must be designed with a logical separation of files. Specifically, -devel packages must be used to contain files which are intended solely for development or needed only at build-time. This is done to minimize the install footprint for users. There are some types of files which almost always belong in a -devel package:
| |
| | |
| * Header files (foo.h), usually found in /usr/include
| |
| * Static library files when the package does not provide any matching shared library files. See [[Packaging:Guidelines#Packaging_Static_Libraries]] for more information about this scenario.
| |
| * Unversioned shared system library files, when a matching versioned shared system library file is also present. For example, if your package contains:
| |
| <pre>
| |
| /usr/lib/libfoo.so.3.0.0
| |
| /usr/lib/libfoo.so.3
| |
| /usr/lib/libfoo.so
| |
| </pre>
| |
| | |
| The versioned shared library files (/usr/lib/libfoo.so.3.2.0 and /usr/lib/libfoo.so.3) are necessary for users to run programs linked against libfoo, so they belong in the base package. The other, unversioned, shared library file (/usr/lib/libfoo.so) is only used to actually link libfoo to code being compiled, and is not necessary to be installed on a users system. This means that it belongs in a -devel package. Please note that in most cases, only the fully versioned shared library file (/usr/lib/libfoo.so.3.2.0) is an actual file, all of the other files are symbolic links to it.
| |
| When a shared library file is only provided in an unversioned format, the packager should ask upstream to consider providing a properly versioned library file. However, in such cases, if the shared library file is necessary for users to run programs linked against it, it must go into the base package. If upstream versions the shared library file at a future point, packagers must be careful to move to the versioned layout described above.
| |
| | |
| As an additional complication, some software generates unversioned shared objects which are not intended to be used as system libraries. These files are usually plugins or modular functionality specific to an application, and are not located in the ld library paths or cache. This means that they are not located directly in /usr/lib or /usr/lib64, or in a directory listed as a library path in /etc/ld.so.conf (or an /etc/ld.so.conf.d/config file). Usually, these unversioned shared objects can be found in a dedicated subdirectory under /usr/lib or /usr/lib64 (e.g. /usr/lib/purple-2/ is the plugin directory used for libpurple applications). In these cases, the unversioned shared objects do not need to be placed in a -devel package.
| |
| | |
| There are some notable exceptions to this packaging model, specifically:
| |
| | |
| * compilers often include development files in the main package because compilers are themselves only used for software development, thus, a split package model does not make any sense.
| |
| | |
| When in doubt as to whether a file belongs in the base package or in -devel, packagers should consider whether the file is necessary to be present for a user to use or execute the functionality in the base package properly, or if it is only necessary for development. If it is only necessary for development, it must go into a -devel package.
| |
| | |
| As with all Fedora Packaging Guidelines, it is recognized that there are unique situations that fall outside of the boundaries of this model. Should you come across such a case, please open a ticket with the [https://fedorahosted.org/fpc/ Fedora Packaging Committee] and explain it to us so that we can extend the Guidelines to address it.
| |
| | |
| {{Anchor|PkgconfigFiles}}
| |
| === Pkgconfig Files (foo.pc) ===
| |
| | |
| The placement of pkgconfig(.pc) files depends on their usecase. Since they are almost always used for development purposes, they should be placed in a -devel package. A reasonable exception is when the main package itself is a development tool not installed in a user runtime, e.g. gcc or gdb.
| |
| | |
| {{Anchor|RequiringBasePackage}}
| |
| | |
| == Requiring Base Package ==
| |
| Subpackages are often extensions for their base package and in that case they should require their base package. It is almost always better to over specify the version, so it is best practice to just use a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}. Devel packages are an example of a package that must require their base packages using a fully versioned dependency. -libs subpackages which only contain shared libraries do not normally need to explicitly depend on %{name}%{?_isa} = %{version}-%{release}, as they usually do not need the base package to be functional libraries.
| |
| | |
| If you end up in a situation where the main package depends on the subpackage and the subpackage on the main package you should think carefully about why you don't have everything in the main package.
| |
| | |
| When a subpackage requires the base package, it must do so using a fully versioned arch-specific (for non-noarch packages) dependency:
| |
| <pre>
| |
| Requires: %{name}%{?_isa} = %{version}-%{release}
| |
| </pre>
| |
| | |
| {{Anchor|SharedLibraries}}
| |
| == Shared Libraries ==
| |
| Whenever possible (and feasible), Fedora Packages containing libraries should build them as shared libraries. In addition, every binary RPM package which contains shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in <code>%post</code> and <code>%postun</code>. If the package has multiple subpackages with libraries, each subpackage should also have a <code>%post/%postun</code> section that calls <code>/sbin/ldconfig</code>. An example of the correct syntax for this is:
| |
| <pre>
| |
| %post -p /sbin/ldconfig
| |
| | |
| %postun -p /sbin/ldconfig
| |
| </pre>
| |
| Note that this specific syntax only works if <code>/sbin/ldconfig</code> is the only call in <code>%post</code> and <code>%postun</code>. If you have additional commands to run during the scriptlet, call <code>/sbin/ldconfig</code> at the beginning of the scriptlet, like this:
| |
| <pre>
| |
| %post
| |
| /sbin/ldconfig
| |
| /usr/bin/foo --add
| |
| | |
| %postun
| |
| /sbin/ldconfig
| |
| /usr/bin/foo --remove
| |
| </pre>
| |
| | |
| === Downstream .so name versioning ===
| |
| | |
| In cases where upstream ships unversioned .so '''library''' (so this is not needed for plugins, drivers, etc.), the packager '''MUST''' try to convince upstream to start versioning it.
| |
| | |
| If that fails due to unwilling or unresposive upstream, the packager may start versioning downstream but this must be done with caution and ideally only in rare cases. We don't want to create a library that could conflict with upstream if they later start providing versioned shared libraries. Under no circumstances should the unversioned library be shipped in Fedora.
| |
| | |
| For downstream versioning, the name should be composed like this:
| |
| <pre>
| |
| libfoobar.so.0.n
| |
| </pre>
| |
| The ''n'' should initially be a small integer (for instance, "1"). we use two digits here ("0.n") because the common practice with upstreams is to use only a single digit here. Using multiple digits helps us avoid potential future conflicts. Do not forget to add the SONAME field (see below) to the library.
| |
| | |
| When new versions of the library are released, you should use an
| |
| [[How_to_check_for_ABI_changes_in_a_package|ABI comparison tool]] to check for ABI differences in the built shared
| |
| libraries. If it detects any incompatibilities, bump the ''n'' number by one.
| |
| | |
| ==== SONAME handling ====
| |
| | |
| When running an executable linked to shared object with SONAME field, the
| |
| dynamic linker checks for this field instead of filename to determine the
| |
| object with which it should link. This allows developers to simply link against the
| |
| unversioned library symlink and the dynamic linker will link against the
| |
| correct object.
| |
| | |
| Keep in mind that although the filename is usually the library's SONAME plus an incrementing minor version there's nothing that intrinsically links these. ldconfig uses the SONAME as the value for a symlink to the actual filename. The dynamic linker then uses that symlink to find the library, disregarding the actual filename. The dynamic linker merely does a simple equality check on the field and does not check for ABI incompatibilities or similar problems. This is the main reason for using an [[How_to_check_for_ABI_changes_in_a_package|ABI comparison tool]] and incrementing the the SONAME.
| |
| | |
| The SONAME field is written to the shared object by linker, using (at least in
| |
| case of <code>ld</code>) the <code>-soname SONAME</code> flags. This can be
| |
| passed as an option to {{package|gcc}} like this:
| |
| <pre>
| |
| $ gcc $CFLAGS -Wl,-soname,libfoo.so.0.n -o libfoo.so.0.n
| |
| </pre>
| |
| | |
| If you want to check if the SONAME field is set and what value it has, use the
| |
| <code>objdump</code> command (from {{package|binutils}}):
| |
| <pre>
| |
| $ objdump -p /path/to/libfoo.so.0.n | grep 'SONAME'
| |
| </pre>
| |
| | |
| | |
| {{Anchor|StaticLibraries}}
| |
| | |
| == Packaging Static Libraries ==
| |
| Packages including libraries should exclude static libs as far as possible (eg by configuring with ''--disable-static''). Static libraries should only be included in exceptional circumstances. Applications linking against libraries should as far as possible link against shared libraries not static versions.
| |
| | |
| Libtool archives, ''foo.la'' files, should not be included. Packages using libtool will install these by default even if you configure with ''--disable-static'', so they may need to be removed before packaging. Due to bugs in older versions of libtool or bugs in programs that use it, there are times when it is not always possible to remove *.la files without modifying the program. In most cases it is fairly easy to work with upstream to fix these issues. Note that if you are updating a library in a stable release (not devel) and the package already contains *.la files, removing the *.la files should be treated as an API/ABI change -- ie: Removing them changes the interface that the library gives to the rest of the world and should not be undertaken lightly.
| |
| | |
| {{Anchor|StaticInclusion}}
| |
| === Packaging Static Libraries ===
| |
| * In general, packagers are strongly encouraged not to ship static libs unless a compelling reason exists.
| |
| | |
| * We want to be able to track which packages are using static libraries (so we can find which packages need to be rebuilt if a security flaw in a static library is fixed, for instance). There are two scenarios in which static libraries are packaged:
| |
| # '''Static libraries and shared libraries.''' In this case, the static libraries must be placed in a ''*-static'' subpackage. Separating the static libraries from the other development files in ''*-devel'' allow us to track this usage by checking which packages <code>BuildRequire</code> the ''*-static'' package. The intent is that whenever possible, packages will move away from using these static libraries, to the shared libraries. If the ''*-static'' subpackage requires headers or other files from ''*-devel'' in order to be useful it must require the ''*-devel'' subpackage.
| |
| # '''Static libraries only.''' When a package only provides static libraries you can place all the static library files in the ''*-devel'' subpackage. When doing this you also must have a virtual Provide for the ''*-static'' package:
| |
| <pre>%package devel
| |
| Provides: foo-static = %{version}-%{release}</pre>
| |
| | |
| Packages which explicitly need to link against the static version must <code>BuildRequire: foo-static</code>, so that the usage can be tracked.
| |
| | |
| * If (and only if) a package has shared libraries which require static libraries to be functional, the static libraries can be included in the ''*-devel'' subpackage. The devel subpackage must have a virtual Provide for the ''*-static'' package, and packages dependent on it must <code>BuildRequire</code> the ''*-static'' package.
| |
| | |
| {{Anchor|HeaderOnlyLibraries}}
| |
| | |
| === Packaging Header Only Libraries ===
| |
| | |
| Certain libraries, especially some C++ template libraries, are header only libraries. Since the code is generated during compile time, they act just like static libraries and need to be treated as such.
| |
| | |
| Place all of the header files in the ''*-devel'' subpackage and then you must have a virtual Provide for the ''*-static'' package:
| |
| <pre>%package devel
| |
| Provides: foo-static = %{version}-%{release}</pre>
| |
| | |
| Packages which use the header library must <code>BuildRequire: foo-static</code>, so that the usage can be tracked.
| |
| | |
| ==== Do not use noarch ====
| |
| | |
| It may be tempting to make the header library package noarch, since the header files themselves are simply text. However, a library should have tests which should be run on all architectures. Also, the install process may modify the installed headers depending on the build architecture. For these reasons, header-only packages must not be marked noarch.
| |
| | |
| {{Anchor|StaticLinkage}}
| |
| | |
| === Statically Linking Executables ===
| |
| * Static linkage is a special exception and should be decided on a case-by-case basis. The packager must provide rationale for linking statically, including precedences where available, to FESCO for approval.
| |
| * If you link statically against a library, add yourself to the initialcc list for the library so you can watch for any security issues or bug fixes for which you'd want to rebuild your package against a new version of the library. Here are [[PackageMaintainers/CVSAdminProcedure| instructions]] for making that request.
| |
| | |
| ==== Programs which don't need to notify FESCo ====
| |
| * Programs written in OCaml do not normally link dynamically to OCaml libraries. Because of that this requirement is waived. (OCaml code that calls out to libraries written in C should still link dynamically to the C libraries, however.)
| |
| | |
| * If a library you depend on '''only''' provides a static version your package can link against it provided that you <code>BuildRequire</code> the ''*-static'' subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.
| |
| | |
| ==== Programs which have been granted exceptions ====
| |
| * yaboot. It's a boot loader that uses e2fsprogs-libs to read the filesystem.
| |
| * GPRbuild. It has a build-time dependency on itself, and uses libraries whose sonames change regularly.
| |
| | |
| == Bundling and Duplication of system libraries ==
| |
| | |
| Fedora packages should make every effort to avoid having multiple, separate, upstream projects bundled together in a single package.
| |
| | |
| All packages whose upstreams allow them to be built against system libraries must be built against system libraries.
| |
| | |
| All packages whose upstreams have no mechanism to build against system libraries may opt to carry bundled libraries, but if they do, they must include <code>Provides: bundled(<libname>) = <version></code> in their RPM spec file. In addition, packages whose upstreams have no mechanism to build against system libraries must be contacted publicly about a path to supporting system libraries. If upstream refuses, this must be recorded in the spec file, either in comments placed adjacent to the <code>Provides:</code> above, or in an additional file checked into the SCM and referenced by a comment placed adjacent to the <code>Provides:</code> above.
| |
| | |
| === Avoid bundling of fonts in other packages ===
| |
| Fonts in general-purpose formats such as Type1, OpenType TT (TTF) or OpenType CFF (OTF) are subject to specific packaging guidelines ([[Packaging:FontsPolicy|1]]), and should always be packaged in the system-wide font repositories instead of private application directories.
| |
| For more information, see: [[Packaging:FontsPolicy#Package_layout_for_fonts]].
| |
| | |
| == Beware of Rpath ==
| |
| Sometimes, code will hardcode specific library paths when linking binaries (using the -rpath or -R flag). This is commonly referred to as an rpath. Normally, the dynamic linker and loader (ld.so) resolve the executable's dependencies on shared libraries and load what is required. However, when -rpath or -R is used, the location information is then hardcoded into the binary and is examined by ld.so in the beginning of the execution. Since the Linux dynamic linker is usually smarter than a hardcoded path, we usually do not permit the use of rpath in Fedora.
| |
| | |
| There is a tool called ''check-rpaths'' which is included in the ''rpmdevtools'' package. It is a good idea to add it to the ''<code>%__arch_install_post</code>'' macro in your ''<code>~/.rpmmacros</code>'' config file:
| |
| <pre>
| |
| %__arch_install_post \
| |
| /usr/lib/rpm/check-rpaths \
| |
| /usr/lib/rpm/check-buildroot
| |
| </pre>
| |
| | |
| When ''check-rpaths'' is run, you might see output like this:
| |
| <pre>
| |
| ERROR 0001: file '/usr/bin/xapian-tcpsrv' contains a standard rpath '/usr/lib64' in [/usr/lib64]
| |
| </pre>
| |
| | |
| Any rpath flagged by check-rpaths '''MUST''' be removed.
| |
| | |
| {{Anchor|AcceptableRpath}}
| |
| === Rpath for Internal Libraries ===
| |
| | |
| When a program installs internal libraries they are often not installed in the system path. These internal libraries are only used for the programs that are present in the package (for example, to factor out code that's common to the executables). These libraries are not intended for use outside of the package. When this occurs, it is acceptable for the programs within the package to use an rpath to find these libraries.
| |
| | |
| Example:
| |
| <pre>
| |
| # Internal libraries for myapp are present in:
| |
| %{_libdir}/myapp/
| |
| %{_libdir}/myapp/libmyapp.so.0.3.4
| |
| %{_libdir}/myapp/libmyapp.so
| |
| | |
| # myapp has an rpath to %{_libdir}/myapp/
| |
| readelf -d /usr/bin/myapp | grep RPATH
| |
| 0x0000000f (RPATH) Library rpath: [/usr/lib/myapp]
| |
| </pre>
| |
| | |
| {{admon/tip|Non-Internal Libraries|When programs outside of the package are supposed to link against the library, it is better to use the [[#AlternativeRpath| Alternative to Rpath]] or simply move the libraries into %{_libdir} instead. That way the dynamic linker can find the libraries without having to link all the programs with an rpath.}}
| |
| | |
| {{Anchor|AlternativeRpath}}
| |
| === Alternatives to Rpath ===
| |
| Often, rpath is used because a binary is looking for libraries in a non-standard location (standard locations are /lib, /usr/lib, /lib64, /usr/lib64). If you are storing a library in a non-standard location (e.g. /usr/lib/foo/), you should include a custom config file in /etc/ld.so.conf.d/. For example, if I was putting 32 bit libraries of libfoo in /usr/lib/foo, I would want to make a file called "foo32.conf" in /etc/ld.so.conf.d/, which contained the following:
| |
| <pre>
| |
| /usr/lib/foo
| |
| </pre>
| |
| Make sure that you also make a 64bit version of this file (e.g. foo64.conf) as well (unless the package is disabled for 64bit architectures, of course).
| |
| | |
| {{Anchor|RemovingRpath}}
| |
| === Removing Rpath ===
| |
| | |
| There are several different ways to fix the rpath issue:
| |
| | |
| * If the application uses configure, try passing the ''--disable-rpath'' flag to configure.
| |
| * If the application uses a local copy of libtool, add the following lines to the spec after %configure:
| |
| <pre>
| |
| %configure
| |
| sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
| |
| sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
| |
| </pre>
| |
| * Sometimes, the code/Makefiles can be patched to remove the ''-rpath'' or ''-R'' flag from being called. This is not always easy or sane to do, however.
| |
| * As a last resort, Fedora has a package called ''chrpath''. When this package is installed, you can run <code>chrpath --delete</code> on the files which contain rpaths. So, in our earlier example, we'd run:
| |
| <pre>
| |
| chrpath --delete $RPM_BUILD_ROOT%{_bindir}/xapian-tcpsrv
| |
| </pre>
| |
| Make sure that you remember to add a '''BuildRequires: chrpath''' if you end up using this method.
| |
| | |
| {{Anchor|Config}}
| |
| | |
| == Configuration files ==
| |
| | |
| Configuration files must be marked as such in packages.
| |
| | |
| As a rule of thumb, use <code>%config(noreplace)</code> instead of plain <code>%config</code> unless your best, educated guess is that doing so will break things. In other words, think hard before overwriting local changes in configuration files on package upgrades. An example case when /not/ to use <code>noreplace</code> is when a package's configuration file changes so that the new package revision wouldn't work with the config file from the previous package revision. Whenever plain <code>%config</code> is used, add a brief comment to the specfile explaining why.
| |
| | |
| Don't use %config or %config(noreplace) under /usr. /usr is deemed to not contain configuration files in Fedora.
| |
| | |
| === Configuration of Package Managers ===
| |
| | |
| Configuration for package managers in Fedora <b>MUST ONLY</b> reference the official Fedora repositories in their default enabled and disabled state (see the yum repo configuration in the <code>fedora-release</code> or <code>fedora-repos</code> packages for the canonical list). Unofficial and third-party repositories that contain only packages that it is legal for us to direct people to in Fedora (see the [[Forbidden items]] and [[Licensing:Main]] pages for an explanation of what is legal) may be shipped in <code>%{_docdir}</code>. The idea is that the system administrator would need to explicitly copy the configuration file from doc into the proper location on the filesystem if they want to enable the repository.
| |
| | |
| == Per-product Configuration ==
| |
| | |
| In the Fedora.next world, we will have a set of curated Fedora Products as well as the availability of classic Fedora. Historically, we have maintained a single set of configuration defaults for all Fedora installs but different target use-cases have different needs. Please see the [[Packaging:Per-Product_Configuration| Per-Product Configuration Guidelines]] for instructions on how to create packages that need to behave differently between Fedora.next Products.
| |
| | |
| == Initscripts ==
| |
| | |
| SystemV-style initscripts are forbidden in Fedora. Systemd units must be used instead.
| |
| | |
| == Systemd units==
| |
| | |
| Detailed guidelines for packaging systemd units and systemd-managed services are [[Packaging:Systemd|here]].
| |
| | |
| == Desktop files ==
| |
| | |
| If a package contains a GUI application, then it needs to also include a properly installed .desktop file. For the purposes of these guidelines, a GUI application is defined as any application which draws an X window and runs from within that window. Installed .desktop files MUST follow the [http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html desktop-entry-spec] , paying particular attention to validating correct usage of Name, GenericName, [http://standards.freedesktop.org/menu-spec/latest/apa.html Categories] ,
| |
| [http://www.freedesktop.org/Standards/startup-notification-spec StartupNotify]
| |
| entries.
| |
| | |
| === Icon tag in Desktop Files ===
| |
| The icon tag can be specified in two ways:
| |
| | |
| * Full path to specific icon file:
| |
| <code> Icon=/usr/share/pixmaps/comical.png </code>
| |
| | |
| * Short name without file extension:
| |
| <code> Icon=comical </code>
| |
| | |
| The short name without file extension is preferred, because it allows for icon theming (it assumes .png by default, then tries .svg and finally .xpm), but either method is acceptable.
| |
| | |
| Additionally, there are scriptlets for packages to use to update the icon cache to ensure that the Desktop files are able to load the included icon files. See [[Packaging:Scriptlets#Icon_Cache]].
| |
| | |
| === .desktop file creation ===
| |
| If the package doesn't already include and install its own .desktop file, you need to make your own. You can do this by including a .desktop file you create as a Source: (e.g. Source3: %{name}.desktop) or generating it in the spec file. Here are the contents of a sample .desktop file (comical.desktop):
| |
| | |
| <pre>
| |
| [Desktop Entry]
| |
| Name=Comical
| |
| GenericName=Comic Archive Reader
| |
| Comment=Open .cbr & .cbz files
| |
| Exec=comical
| |
| Icon=comical
| |
| Terminal=false
| |
| Type=Application
| |
| Categories=Graphics;
| |
| </pre>
| |
| | |
| === desktop-file-install usage ===
| |
| It is not simply enough to just include the .desktop file in the package, one MUST run <code>desktop-file-install</code> (in <code>%install</code>) OR <code>desktop-file-validate</code> (in <code>%check</code> or <code>%install</code>) and have <code>BuildRequires: desktop-file-utils</code>, to help ensure .desktop file safety and spec-compliance. <code>desktop-file-install</code> MUST be used if the package does not install the file or there are changes desired to the .desktop file (such as add/removing categories, etc). <code>desktop-file-validate</code> MAY be used instead if the .desktop file's content/location does not need modification. Here are some examples of
| |
| usage:
| |
| | |
| <pre>
| |
| desktop-file-install \
| |
| --dir=${RPM_BUILD_ROOT}%{_datadir}/applications \
| |
| %{SOURCE3}
| |
| </pre>
| |
| | |
| <pre>
| |
| desktop-file-install \
| |
| --add-category="AudioVideo" \
| |
| --delete-original \
| |
| --dir=%{buildroot}%{_datadir}/applications \
| |
| %{buildroot}/%{_datadir}/applications/foo.desktop
| |
| </pre>
| |
| | |
| <pre>
| |
| desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop
| |
| </pre>
| |
| | |
| Do '''not''' apply a vendor tag to .desktop files (using --vendor).
| |
| | |
| == AppData files ==
| |
| | |
| Packages containing graphical applications should include AppData files. See [[Packaging:AppData]] for the relevant guidelines.
| |
| | |
| == Macros ==
| |
| Packagers are strongly encouraged to use macros instead of hard-coded directory names (see [[Packaging:RPMMacros]] ). However, in situations where the macro is longer than the path it represents, or situations where the packager feels it is cleaner to use the actual path, the packager is permitted to use the actual path instead of the macro. There are several caveats to this approach:
| |
| * The package must be consistent. For any given path, within the same spec, use either a hard-coded path or a macro, not a combination of the two.
| |
| * %{_libdir} must always be used for binary libraries due to multi-lib, you may not substitute a hard-coded path.
| |
| | |
| Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, <code>rm</code> should be used in preference to <code>%{__rm}</code>, but <code>%{__python}</code> is acceptable.
| |
| | |
| Having macros in a Source: or Patch: line is a matter of style. Some people enjoy the ready readability of a source line without macros. Others prefer the ease of updating for new versions when macros are used. In all cases, remember to be consistent in your spec file and verify that the URLs you list are valid. spectool (from the rpmdevtools package) can aid you in checking that whether the URL contains macros or not.
| |
| | |
| If you need to determine the actual string when it contains macros, you can use rpm. For example, to determine the actual Source: value, you can run:
| |
| <pre>
| |
| rpm -q --specfile foo.spec --qf "$(grep -i ^Source foo.spec)\n"
| |
| </pre>
| |
| | |
| {{Anchor|%autosetup}}
| |
| === <code>%autosetup</code> ===
| |
| As an alternative to the usual <code>%setup</code> macro, the <code>%autosetup</code> can be used. In addition to the normal %setup tasks, it will apply all defined Patch# items in the spec automatically. It is also capable of handling VCS formatted patch files, but this will require additional BuildRequires, and assumes that _all_ patch files in the spec are formatted for that single VCS type. For this reason, it is not recommended that you specify a VCS with <code>%autosetup</code>. For more details on proper use of <code>%autosetup</code>, see [http://www.rpm.org/wiki/PackagerDocs/Autosetup].
| |
| | |
| === Using %{buildroot} and %{optflags} vs $RPM_BUILD_ROOT and $RPM_OPT_FLAGS ===
| |
| There are two styles of defining the rpm Build Root and Optimization Flags in a spec file:
| |
| | |
| {| border="1"
| |
| |-
| |
| | ||macro style || variable style
| |
| |-
| |
| |Build Root||%{buildroot}||$RPM_BUILD_ROOT
| |
| |-
| |
| |Opt. Flags||%{optflags}||$RPM_OPT_FLAGS
| |
| |}
| |
| | |
| There is very little value in choosing one style over the other, since they will resolve to the same values in all scenarios. You should pick a style and use it consistently throughout your packaging.
| |
| | |
| Mixing the two styles, while valid, is bad from a QA and usability point of view, and should not be done in Fedora packages.
| |
| | |
| {{Anchor|MakeInstall}}
| |
| === Why the %makeinstall macro should not be used ===
| |
| Fedora's RPM includes a <code>%makeinstall</code> macro but it must '''NOT''' be used when make install DESTDIR=%{buildroot} works. %makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable but it has the following potential issues:
| |
| * <code>%makeinstall</code> overrides a set of Make variables during "make install" and prepends the %{buildroot} path. I.e. it performs make prefix="%{buildroot}%{_prefix}" libdir="%{buildroot}%{_libdir} ...".
| |
| * It is error-prone and can have unexpected effects when run against less than perfect Makefiles, e.g. the buildroot path may be included in installed files where variables are substituted at install-time.
| |
| * It can trigger unnecessary and wrong rebuilds when executing "make install", since the Make variables have different values compared with the %build section.
| |
| * If a package contains libtool archives, it can cause broken *.la files to be installed.
| |
| | |
| Instead, Fedora packages should use: <code>%make_install</code> (Note the "_" !), <code>make DESTDIR=%{buildroot} install</code> or <code>make DESTDIR=$RPM_BUILD_ROOT install</code>. Those all do the same thing.
| |
| | |
| === Source RPM Buildtime Macros ===
| |
| All macros in <code>Summary:</code> and <code>%description</code> need to be expandable at srpm buildtime. Because SRPMs are built without the package's BuildRequires installed, depending on macros defined outside of the spec file can easily lead to the unexpanded macros showing up in the built SRPM. One way to check is to create a minimal chroot and build the srpm:
| |
| | |
| <pre>
| |
| mock --init
| |
| mock --copyin [SRPM] /
| |
| mock --shell bash
| |
| rpm -ivh [SRPM]
| |
| cd /builddir/build/SPECS
| |
| rpmbuild -bs --nodeps [SRPM]
| |
| rpm -qpiv /builddir/build/SRPMS/[SRPM]
| |
| </pre>
| |
| Check the <code>rpm</code> output for unexpanded macros (<code>%{foo}</code>) or missing information (when<code>%{?foo}</code> is expanded to the empty string). Even easier is to simply avoid macros in <code>Summary:</code> and <code>%description</code> unless they are defined in the current spec file.
| |
| | |
| === Improper use of %_sourcedir ===
| |
| Packages which use files itemized as Source# files, must refer to those files by their <code>Source#</code> macro name, and must not use <code>$RPM_SOURCE_DIR</code> or <code>%{sourcedir}</code> to refer to those files. See [[Packaging:RPM_Source_Dir]] for full details.
| |
| | |
| === Software Collection Macros ===
| |
| [[User:Toshio/SCL_Guidelines_(draft)| Software Collections]] are to be kept to separate packages from mainstream packages similar to how [[Packaging:MinGW| MingW packages]] are managed.
| |
| | |
| In the past, SCL macros were allowed to be present inside of mainstream packages if they were not used. Since we're now building SCLs, we are now enforcing a strict separation. Packages '''MUST''' be updated to restrict SCL macros to only those packages particularly approved as part of an SCL.
| |
| | |
| === Packaging of Additional RPM Macros ===
| |
| | |
| Additional RPM macros '''must''' be stored under the <code>%{_rpmconfigdir}/macros.d</code> directory. spec files that are intended to also work on EPEL < 7 can conditionally use <code>%{_sysconfdir}/rpm</code> instead as rpm in RHEL6 and below does not search <code>%{_rpmconfigdir}/macros.d</code> for macros).
| |
| | |
| They '''must''' be named using the syntax "<code>macros.$PACKAGE</code>" (e.g. <code>macros.perl</code>). Normally, these files are packaged in the -devel subpackage, since they are usually only needed for building other packages. However, in some situations, this is not always ideal and packagers are encouraged to use their best judgment when determining the proper package for these files. RPM Macro files '''MUST NOT''' be marked as <code>%config</code>.
| |
| | |
| Here's some example spec snippets that place the macro file into the correct directory with both RHEL5 & 6's rpm and with modern rpm.
| |
| | |
| <pre>
| |
| # define macrosdir to the old location for EPEL 5 and 6. Use the new location everywhere else
| |
| %global macrosdir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d)
| |
| [..]
| |
| SOURCE1: macros.perl
| |
| [..]
| |
| %install
| |
| cp %{SOURCE1} %{buildroot}%{macrosdir}
| |
| [..]
| |
| %files -n devel
| |
| %{macrosdir}/macros.perl
| |
| </pre>
| |
| | |
| == Scripting inside of spec files ==
| |
| | |
| Sometimes it is necessary to write a short script (perhaps a one-liner) that is executed in the %prep, %build, or %install sections of a spec file to get some information about the build environment. In order to simplify the dependency graph, spec files should only use the following languages for this purpose:
| |
| | |
| 1. Python
| |
| 2. Perl
| |
| 3. Standard programs used in shell programing, for instance gawk or sed
| |
| 4. Lua (as supported by the native lua interpreter in rpm)
| |
| | |
| Additionally, if your package cannot build without a specific scripting language (such as Ruby, or Tcl), and therefore already has a BuildRequires on that language, it may also be called from the spec file.
| |
| | |
| Note: If you call perl or python in your spec file (and it is not already a BuildRequires for the package), you need to explicitly add a BuildRequires for perl or python.
| |
| | |
| == %global preferred over %define ==
| |
| | |
| Use <code>%global</code> instead of <code>%define</code>, unless you really need only locally defined submacros within other macro definitions (a very rare case).
| |
| | |
| Rationale: The two macro defining statements behave the same when they are a the top level of rpm's nesting level.
| |
| | |
| But when they are used in nested macro expansions (like in <code> %{!?foo: ... } </code> constructs, <code>%define</code> theoretically only lasts until the end brace (local scope), while <code>%global</code> definitions have global scope.
| |
| | |
| Note that %define and %global differ in more ways than just scope: the body of a %define'd macro is lazily expanded (ie when used), but the body of %global is expanded at definition time. It's possible to use %%-escaping to force lazy expansion of %global.
| |
| | |
| {{Anchor|locales}}
| |
| | |
| == Handling Locale Files ==
| |
| | |
| Translation files may be handled by different programs for different frameworks. Make sure you add BuildRequires: for the correct package or else your package could fail to generate translation files in the buildroot.
| |
| | |
| If the package uses gettext for translations, add
| |
| <pre>
| |
| BuildRequires: gettext
| |
| </pre>
| |
| | |
| For Qt-based packages that use the Linguist tool chain, for the localization utilities add
| |
| <pre>
| |
| BuildRequires: qt-devel
| |
| </pre>
| |
| | |
| If you have few enough locale files that they can all go into one package, you can use the <code>%find_lang</code> macro. (If you need to split your package into separate language packs, please see [[Packaging:Langpacks|the langpack guidelines]].) This macro will locate all of the them belonging to your package (by name), and put this list in a file. You can then use that file to include all of the locales. <code>%find_lang</code> should be run in the %install section of your spec file, after all of the files have been installed into the buildroot. The correct syntax for <code>%find_lang</code> is usually:
| |
| <pre>
| |
| %find_lang %{name}
| |
| </pre>
| |
| In some cases, the application may use a different "name" for its locales. You may have to look at the locale files and see what they are named. If they are named <code>myapp.mo</code>, then you will need to pass <code>myapp</code> to <code>%find_lang</code> instead of <code>%{name}</code>.
| |
| After <code>%find_lang</code> is run, it will generate a file in the active directory (by default, the top level of the source dir). This file will be named based on what you passed as the option to the <code>%find_lang</code> macro. Usually, it will be named <code>%{name}.lang</code>. You should then use this file in the <code>%files</code> list to include the locales detected by <code>%find_lang</code>. To do this, you should include it with the -f parameter to <code>%files</code>.
| |
| <pre>
| |
| %files -f %{name}.lang
| |
| %{_bindir}/foobar
| |
| ...
| |
| </pre>
| |
| | |
| Note that <code>%find_lang</code> by default searches for gettext locales, but it can also handle Qt translations, localised manpages and help files.
| |
| | |
| To process GNOME help files put into <code>/usr/share/gnome/help/</code> use
| |
| <pre>
| |
| %find_lang %{name} --with-gnome
| |
| </pre>
| |
| | |
| To process KDE help files put into <code>/usr/share/doc/HTML/</code> use
| |
| <pre>
| |
| %find_lang %{name} --with-kde
| |
| </pre>
| |
| | |
| To process Qt's <code>.qm</code> binary translation files use
| |
| <pre>
| |
| %find_lang %{name} --with-qt
| |
| </pre>
| |
| | |
| To process localised manpages (doesn't include the default, non-localised one), use
| |
| <pre>
| |
| %find_lang %{name} --with-man
| |
| </pre>
| |
| | |
| To see all the options, run <code>/usr/lib/rpm/find-lang.sh</code> in the terminal.
| |
| | |
| Names different from <code>%{name}</code> (e.g. multiple manpages) must be handled via separate calls to <code>%find_lang</code>.
| |
| | |
| Here is an example of proper usage of <code>%find_lang</code>, in <code>foo.spec</code> with the "foo" application localised using gettext and man pages named "bar" instead of "foo":
| |
| | |
| <pre>
| |
| Name: foo
| |
| ...
| |
| %prep
| |
| %setup -q
| |
| | |
| %build
| |
| %configure --with-cheese
| |
| make %{?_smp_mflags}
| |
| | |
| %install
| |
| make DESTDIR=%{buildroot} install
| |
| %find_lang %{name}
| |
| %find_lang bar --with-man
| |
| | |
| %files -f %{name}.lang -f bar.lang
| |
| %doc LICENSE README
| |
| %{_bindir}/%{name}
| |
| %{_mandir}/man1/bar.1.gz
| |
| | |
| %changelog
| |
| * Fri Jan 13 2012 Karel Volny <kvolny@redhat.com> 0.1-2
| |
| - add man pages example
| |
| | |
| * Thu May 4 2006 Tom "spot" Callaway <tcallawa@redhat.com> 0.1-1
| |
| - sample spec that uses %%find_lang
| |
| | |
| </pre>
| |
| | |
| === Why do we need to use %find_lang? ===
| |
| | |
| Using <code>%find_lang</code> helps keep the spec file simple, and helps avoid several other packaging mistakes.
| |
| | |
| * Packages that use <code>%{_datadir}/*</code> to grab all the locale files in one line also grab ownership of the locale directories, which is not permitted.
| |
| * Most packages that have locales have lots of locales. Using <code>%find_lang</code> is much easier in the spec file than having to do:
| |
| <pre>
| |
| %{_datadir}/locale/ar/LC_MESSAGES/%{name}.mo
| |
| %{_datadir}/locale/be/LC_MESSAGES/%{name}.mo
| |
| %{_datadir}/locale/cs/LC_MESSAGES/%{name}.mo
| |
| %{_datadir}/locale/de/LC_MESSAGES/%{name}.mo
| |
| %{_datadir}/locale/es/LC_MESSAGES/%{name}.mo
| |
| ...
| |
| </pre>
| |
| * As new locale files appear in later package revisions, <code>%find_lang</code> will automatically include them when it is run, preventing you from having to update the spec any more than is necessary.
| |
| | |
| Keep in mind that usage of <code>%find_lang</code> in packages containing locales is a MUST unless the locale files are broken out into langpacks. In which case, you should follow [[Packaging:Langpacks|the langpack guidelines]].
| |
| | |
| == Log Files ==
| |
| | |
| Packages which generate log files should write out their logfiles in a package-specific (and package owned) directory under %{_localstatedir}/log. Unless the software being packaged rotates its own logs, it must also ship a logrotate config file to rotate its log file(s).
| |
| | |
| === Logrotate config file ===
| |
| | |
| Logrotate config files should be named in a way that matches the daemon/software which is generating the logs, which is usually (though not always) the same name as the package. When unsure, use "%{name}.conf". These files must be placed in %{_sysconfdir}/logrotate.d, and should use standard file permissions (0644) and ownership (root:root).
| |
| | |
| Since these are config files, they must be marked as %config(noreplace) in the %files list.
| |
| | |
| ==== Example minimal logrotate config file ====
| |
| | |
| <pre>
| |
| /var/log/example/*log {
| |
| missingok # If the log file is missing, go on to the next one without issuing an error message
| |
| notifempty # Don't do any rotation if the logfile is empty
| |
| compress # Compress older files with gzip
| |
| delaycompress # Don't compress yesterdays files
| |
| }
| |
| </pre>
| |
| | |
| {{Anchor|Timestamps}}
| |
| == Timestamps ==
| |
| When adding file copying commands in the spec file, consider using a command that preserves the files' timestamps, eg. <code>cp -p</code> or <code>install -p</code>.
| |
| | |
| When downloading sources, patches etc, consider using a client that preserves the upstream timestamps. For example <code>wget -N</code> or <code>curl -R</code>. To make the change global for wget, add this to your <code>~/.wgetrc</code>: <code>timestamping = on</code>, and for curl, add to your <code>~/.curlrc</code>: <code>-R</code>.
| |
| | |
| {{Anchor|parallelmake}}
| |
| == Parallel make ==
| |
| Whenever possible, invocations of <code>make</code> should be done as
| |
| <pre>
| |
| %make_build
| |
| </pre>
| |
| This generally speeds up builds and especially on SMP machines.
| |
| | |
| Do make sure, however, that the package builds cleanly this way as some make files do not support parallel building. Therefore you should consider adding
| |
| <pre>
| |
| %_smp_mflags -j3
| |
| </pre>
| |
| to your <code>~/.rpmmacros</code> file -- even on UP machines -- as this will expose most of these errors.
| |
| | |
| == Scriptlets ==
| |
| Great care should be taken when using scriptlets in Fedora packages. If scriptlets are used, those scriptlets must be sane. Some common scriptlets are documented here: [[Packaging:Scriptlets]].
| |
| | |
| === Running scriptlets only in certain situations ===
| |
| When the rpm command executes the scriptlets in a package it indicates if the action preformed is an install, erase, upgrade or reinstall by passing an integer argument to the script in question according to the following:
| |
| <pre>
| |
| install erase upgrade reinstall
| |
| %pre 1 - 2 2
| |
| %post 1 - 2 2
| |
| %preun - 0 1 -
| |
| %postun - 0 1 -
| |
| </pre>
| |
| This means that for example a package that installs an init script with the <code>chkconfig</code> command should uninstall it only on erase and not upgrade with the following snippet:
| |
| <pre>
| |
| %preun
| |
| if [ $1 -eq 0 ] ; then
| |
| /sbin/chkconfig --del %{name}
| |
| fi
| |
| </pre>
| |
| See also <code>/usr/share/doc/rpm-*/triggers</code>, which gives a more formal, generalized definition about the integer value(s) passed to various scripts.
| |
| | |
| {{Anchor|SciptletsWriteDirs}}
| |
| === Scriplets are only allowed to write in certain directories ===
| |
| Build scripts of packages (%prep, %build, %install, %check and %clean) may only alter files (create, modify, delete) under %{buildroot}, %{_builddir} and valid temporary locations like /tmp, /var/tmp (or $TMPDIR or %{_tmppath} as set by the rpmbuild process) according to the following matrix
| |
| | |
| {| border="1"
| |
| |-
| |
| | || /tmp, /var/tmp, $TMPDIR, %{_tmppath} || %{_builddir} || %{buildroot}
| |
| |-
| |
| |%prep || yes || yes || no
| |
| |-
| |
| |%build || yes || yes || no
| |
| |-
| |
| |%install || yes || yes || yes
| |
| |-
| |
| |%check || yes || yes || no
| |
| |-
| |
| |%clean || yes || yes || yes
| |
| |}
| |
| | |
| Further clarification: That should hold true irrespective of the builder's uid.
| |
| | |
| === The %pretrans scriptlet ===
| |
| | |
| Note that the %pretrans scriptlet will, in the particular case of system installation, run before anything at all has been installed. This implies that it cannot have any dependencies at all. For this reason, %pretrans is best avoided, but if you must use it, the script must be written in Lua. See http://rpm.org/user_doc/lua.html for more information.
| |
| | |
| | |
| {{Anchor|SeparateUserAccounts}}
| |
| | |
| == Build packages with separate user accounts ==
| |
| When building software, which you have not conducted a full security-audit on, protect sensitive data, such as your GPG private key, in a separate user account.
| |
| | |
| The same applies to reviewers/testers. Rebuild src.rpms in a separate account which does not have access to any sensitive data.
| |
| | |
| {{Anchor|RelocatablePackages}}
| |
| == Relocatable packages ==
| |
| The use of RPM's facility for generating relocatable packages is strongly discouraged. It is difficult to make work properly, impossible to use from the installer or from yum, and not generally necessary if other packaging guidelines are followed. However, in the unlikely event that you have a good reason to make a package relocatable, you MUST state this intent and reasoning in the request for package review.
| |
| | |
| {{Anchor|FileAndDirectoryOwnership}}
| |
| == File and Directory Ownership ==
| |
| | |
| Your package should own all of the files that are installed as part of the %install process.
| |
| | |
| In most cases, it should not be necessary for multiple packages to contain identical copies of the same file. However, if it is necessary, multiple packages may contain identical copies of the same file, as long as the following requirements are met:
| |
| | |
| * The packages sharing ownership of the identical files are built from a single SRPM.
| |
| | |
| OR
| |
| | |
| * The packages sharing ownership of the identical files are not in a dependency chain (e.g. if package A requires package B, they should not both contain identical files, either A or B must own the common files, but not both.)
| |
| | |
| In addition, identical files are defined as files which are always identical in content, checksum, permissions, and location on the filesystem in each package.
| |
| | |
| Directory ownership is a little more complex than file ownership. Packages must own all directories they put files in, except for:
| |
| * any directories owned by the <code>filesystem</code>, <code>man</code>, or other explicitly created <code>-filesystem</code> packages
| |
| * any directories owned by other packages in your package's natural dependency chain
| |
| | |
| In this context, a package's "natural dependency chain" is defined as the set of packages necessary for that package to function normally. To be specific, you do not need to require a package for the sole fact that it happens to own a directory that your package places files in. If your package already requires that package for other reasons, then your package should not also own that directory.
| |
| | |
| In all cases we are guarding against unowned directories being present on a system. Please see [[Packaging:UnownedDirectories]] for the details.
| |
| | |
| {{admon/important|Note on multiple ownership| Note that when co-owning directories, you <b>must</b> ensure that the ownership and permissions on the directory match in all packages that own it.}}
| |
| | |
| Here are examples that describe how to handle most cases of directory ownership.
| |
| | |
| === The directory is wholly contained in your package, or involves core functionality of your package ===
| |
| | |
| An example:
| |
| <pre>
| |
| gnucash places many files under the /usr/share/gnucash directory
| |
| </pre>
| |
| | |
| Solution: the <code>gnucash</code> package should own the <code>/usr/share/gnucash</code> directory
| |
| | |
| === The directory is also owned by a package implementing required functionality of your package ===
| |
| | |
| An example:
| |
| | |
| <pre>
| |
| pam owns the /etc/pam.d directory
| |
| gdm places files into /etc/pam.d
| |
| gdm depends on pam to function normally, and would Require: pam (either implicitly or explicitly) separate from the directory ownership.
| |
| </pre>
| |
| | |
| Solution: the <code>pam</code> package should own the <code>/etc/pam.d</code> directory, and <code>gdm</code> should <code>Require:</code> the <code>pam</code> package.
| |
| | |
| === The directory is owned by a package which is not required for your package to function ===
| |
| | |
| Some packages create and own directories with the intention of permitting other packages to store appropriate files, but those other packages do not need that original package to be present to function properly.
| |
| | |
| An example:
| |
| | |
| <pre>
| |
| gtk-doc owns the /usr/share/gtk-doc/ directory
| |
| evolution puts files into /usr/share/gtk-doc/
| |
| evolution does not need gtk-doc in order to function properly.
| |
| Nothing in evolution's dependency chain owns /usr/share/gtk-doc/
| |
| </pre>
| |
| | |
| Solution: the <code>evolution</code> package should own the <code>/usr/share/gtk-doc</code> directory. There is no need to add an explicit Requires on gtk-doc solely for the directory ownership.
| |
| | |
| Sometimes, it may be preferable for such directories to be owned by an "artificial filesystem" package, such as <code>mozilla-filesystem</code>. These packages are designed to be explicitly required when other packages store files in their directories, thus, in such situations, these packages should explicitly Require the artificial filesystem package and not multiply own those directories. Packagers should consider the number of affected directories and packages when determining whether to create artificial filesystem packages, and use their own best judgement to determine if this is necessary or not.
| |
| | |
| {{admon/important|Rule of Thumb|When determining whether this exception applies, packagers and reviewers should ask this question: Do the files in this common directory enhance or add functionality to another package, where that other package is not necessary to be present for the primary functionality of this package?}}
| |
| | |
| === The package you depend on to provide a directory may choose to own a different directory in a later version and your package will run unmodified with that later version ===
| |
| | |
| An example involving Perl modules:
| |
| | |
| Assume <code>perl-A-B</code> depends on <code>perl-A</code> and installs files into /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/A/B.
| |
| The base Perl package guarantees that it will own /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi for as long as it remains compatible with version 5.8.8, but a future upgrade of the <code>perl-A</code> package may install into (and thus own) /usr/lib/perl5/vendor_perl/5.9.0/i386-linux-thread-multi/A. So the <code>perl-A-B</code> package needs to own /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/A as well as /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/A/B in order to maintain proper ownership.
| |
| | |
| {{Anchor|DuplicateFiles}}
| |
| === Duplicate Files ===
| |
| | |
| A Fedora package must not list a file more than once in the spec file's %files listings. If you think your package is a valid exception to this, please bring it to the attention of the Packaging Committee so they can improve on this Guideline.
| |
| | |
| One notable exception to this rule is around license texts. There are certain situations where it is required to duplicate the license text across multiple %files section within a package. For more details, please refer to [[Packaging:LicensingGuidelines#Subpackage_Licensing]].
| |
| | |
| {{Anchor|FilePermissions}}
| |
| === File Permissions ===
| |
| | |
| Permissions on files MUST be set properly. Inside of /usr, files should be owned by root:root unless a more specific user or group is needed for security. They MUST be universally readable (and executable if appropriate). Outside of /usr, non-config and non-state files SHOULD be owned by root:root, universally readable (and executable if appropriate) unless circumstances require otherwise.
| |
| | |
| The default file mode is 0644 or 0755. Directories should be mode 0755. Most well behaved build scripts and rpm will use these defaults. If the directory needs to be group writable, it SHOULD also have the setgid bit set so that files written there are owned by that group. These directories SHOULD have mode 2775.
| |
| | |
| The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value, or to reset to the default value after having set a non-default value.
| |
| | |
| == Users and Groups ==
| |
| | |
| Some packages require or benefit from dedicated runtime user and/or group accounts. Guidelines for handling these cases are in a separate [[Packaging:UsersAndGroups]] document.
| |
| | |
| Note that system services packaged for Fedora MUST NOT run as the <code>nobody</code> user, but MUST instead allocate their own system user.
| |
| | |
| == Web Applications ==
| |
| | |
| Web applications packaged in Fedora should put their content into /usr/share/%{name} and NOT into /var/www/. This is done because:
| |
| | |
| * /var is supposed to contain variable data files and logs. /usr/share is much more appropriate for this.
| |
| * Many users already have content in /var/www, and we do not want any Fedora package to step on top of that.
| |
| * /var/www is no longer specified by the Filesystem Hierarchy Standard
| |
| | |
| {{Anchor|Conflicts}}
| |
| == Conflicts ==
| |
| | |
| Whenever possible, Fedora packages should avoid conflicting with each other. Unfortunately, this is not always possible. For full details on Fedora's Conflicts policy, see: [[Packaging:Conflicts]] .
| |
| | |
| Tools such as Alternatives and Environment Modules can also help prevent package conflicts.
| |
| | |
| === Alternatives ===
| |
| | |
| The "alternatives" tool provides a means for parallel installation of packages which provide the same functionality by maintaining sets of symlinks. For full details on how to properly use alternatives, see [[Packaging:Alternatives]].
| |
| | |
| === Environment Modules ===
| |
| | |
| When there are multiple variants that each serve the needs of some user and thus must be available simultaneously by users, the alternatives system simply isn't enough since it is system-wide. In such situations, use of Environment Modules can avoid conflicts. For full details on how to properly use Environment Modules, see [[Packaging:EnvironmentModules]].
| |
| | |
| == Patch Guidelines ==
| |
| | |
| === All patches should have an upstream bug link or comment ===
| |
| | |
| All patches in Fedora spec files '''SHOULD''' have a comment above them about their upstream status. Any time you create a patch, it is best practice to file it in an upstream bug tracker, and include a link to that in the comment above the patch. For example:
| |
| | |
| <pre>
| |
| # http://bugzilla.gnome.org/show_bug.cgi?id=12345
| |
| Patch0: gnome-panel-fix-frobnicator.patch
| |
| </pre>
| |
| | |
| The above is perfectly acceptable; but if you prefer, a brief comment about what the patch does above can be helpful:
| |
| | |
| <pre>
| |
| # Don't crash with frobnicator applet
| |
| # http://bugzilla.gnome.org/show_bug.cgi?id=12345
| |
| Patch0: gnome-panel-fix-frobnicator.patch
| |
| </pre>
| |
| | |
| Sending patches upstream and adding this comment will help ensure that Fedora is acting as a good FLOSS citizen (see [[PackageMaintainers/WhyUpstream| Why Upstream?]] ). It will help others (and even you) down the line in package maintenance by knowing what patches are likely to appear in a new upstream release.
| |
| | |
| ==== If upstream doesn't have a bug tracker ====
| |
| You can indicate that you have sent the patch upstream and any known status:
| |
| | |
| <pre>
| |
| # Sent upstream via email 20080407
| |
| Patch0: foobar-fix-the-bar.patch
| |
| </pre>
| |
| | |
| <pre>
| |
| # Upstream has applied this in SVN trunk
| |
| Patch0: foobar-fix-the-baz.patch
| |
| </pre>
| |
| | |
| ==== Fedora-specific (or rejected upstream) patches ====
| |
| It may be that some patches truly are Fedora-specific; in that case, say so:
| |
| | |
| <pre>
| |
| # This patch is temporary until we land the long term System.loadLibrary fix in OpenJDK
| |
| Patch0: jna-jni-path.patch
| |
| </pre>
| |
| | |
| === Applying patches ===
| |
| | |
| Normally, patches to a package SHOULD be listed in <code>PatchN:</code> tags in the RPM spec file and applied using the %patch or %autosetup macros. The files MUST then be checked into the Fedora Package revision control system (currently the git repos on pkgs.fedoraproject.org and commonly accessed via fedpkg). Storing the files in this way allows people to use standard tools to visualize the changes between revisions of the files and track additions and removals without a layer of indirection (as putting them into lookaside would do).
| |
| | |
| Applying patches directly from RPM_SOURCE_DIR IS NOT ALLOWED. Please see Packaging:RPM_Source_Dir for the complete rationale.
| |
| | |
| The maintainer MAY deviate from this rule when the upstream of the package provides an extremely large patch or a tarball of patches against a base release. In this case the tarball of patches MAY be listed as a <code>SourceN:</code> line and the patches would be applied by untarring the archive and then applying the distributed patch(es) using the regular /usr/bin/patch command. Additional patches to the package (for instance, generated by the Fedora maintainer to fix bugs) MUST still be listed in <code>PatchN:</code> lines and be applied by %patch macros after the patches from the tarball were applied. Maintainers and reviewers should be cautious when exercising this exception as shipping an update as a patchset may be a sign that the patchset is not from the actual upstream or that the patches should be reviewed for correctness rather than simply accepted as the upstream code base.
| |
| | |
| == Use of Epochs ==
| |
| RPM supports a field called "Epoch:", which is a numeric field, that, if set, adds another qualifier for RPM to use in doing package comparisons. Specifically, if set, the Epoch of a package trumps all other comparisons (except for a larger Epoch). If Epoch is not set in a package, RPM treats it the same as if it was set to 0.
| |
| | |
| Example:
| |
| <pre>
| |
| Version: 1.2
| |
| Release: 3%{?dist}
| |
| Epoch: 1
| |
| </pre>
| |
| | |
| A package with those definitions would be considered greater than a package with a higher version or a higher release. Since Epoch is confusing to humans (and can never be removed from a package once used), it should only be used in Fedora '''as a last resort''' to resolve upgrade ordering of a package, and should be avoided wherever possible.
| |
| | |
| Also, Epoch complicates normal packaging guidelines. If a package uses an Epoch, it must be referred to in any place where <code>%{version}-%{release}</code> is used. For example, if a package being depended upon has an Epoch, this must be listed when adding a versioned dependency:
| |
| | |
| <pre>
| |
| Requires: foo = %{epoch}:%{version}-%{release}
| |
| </pre>
| |
| | |
| === Epochs from Third Party Repositories ===
| |
| If a package to be imported is or previously was present in a publicly accessible repository, the packager can optionally include an Epoch tag equal to that of the most recent version of the third-party package.
| |
| | |
| == Symlinks ==
| |
| There are two ways of making a symlink, either as a relative link or an absolute link. In Fedora, neither method is required. Packagers should use their best judgement when deciding which method of symlink creation is appropriate.
| |
| | |
| === Relative Symlinks ===
| |
| A relative symlink is a symlink which points to a file or directory relative to the position of the symlink. For example, this command would create a relative symlink:
| |
| <pre>
| |
| ln -s ../..%{_bindir}/foo %{buildroot}/bin/foo
| |
| </pre>
| |
| | |
| Pros:
| |
| * Relative symlinks will point to the same file inside or outside of a chroot.
| |
| | |
| Cons:
| |
| * Much more complicated to create than absolute symlinks
| |
| * Relative symlinks may break or behave unexpectedly when a part of a filesystem is mounted to a custom location.
| |
| * Relative symlinks may break when bind mounting or symlinking directories.
| |
| * Relative symlinks may make it more difficult to use rpm system macros.
| |
| | |
| === Absolute Symlinks ===
| |
| An absolute symlink is a symlink which points to an absolute file or directory path. For example, this command would create an absolute symlink:
| |
| <pre>
| |
| ln -s %{_bindir}/foo %{buildroot}/bin/foo
| |
| </pre>
| |
| | |
| Pros:
| |
| * Much easier to create than relative symlinks.
| |
| * Absolute symlinks work properly when bind mounting or symlinking directories.
| |
| * Absolute symlinks work well with rpm system macros.
| |
| | |
| Cons:
| |
| * Absolute symlinks may break when used with chroots.
| |
| | |
| == Replacing a symlink to a directory or a directory to any type file ==
| |
| In some cases replacing a symlink to a directory requires special handling. Replacing a directory with any type of file always requires special handling.
| |
| | |
| See [[Packaging:Directory_Replacement]] for information about doing this.
| |
| | |
| == Test Suites ==
| |
| If the source code of the package provides a test suite, it should be executed in the <code>%check</code> section, whenever it is practical to do so.
| |
| | |
| == binfmt.d, sysctl.d and tmpfiles.d ==
| |
| | |
| If you install a sysctl configuration snippet foobar.conf into %{_sysctldir} (/usr/lib/sysctl.d/) you must invoke %sysctl_apply in your %post section:
| |
| | |
| <pre>
| |
| %sysctl_apply fooar.conf
| |
| </pre>
| |
| | |
| If you install a binfmt configuration snippet waldo.conf into %{_binfmtdir} (/usr/lib/binfmt.d/) you must invoke %binfmt_apply in your %post section:
| |
| | |
| <pre>
| |
| %binfmt_apply waldo.conf
| |
| </pre>
| |
| | |
| These have the effect of making the appropriate changes immediately upon package installation instead of requiring a reboot or manual activation.
| |
| | |
| There are specific guidelines for handling tmpfiles.d configurations and directories (in /var/run and /var/lock): [[Packaging:Tmpfiles.d]]
| |
| | |
| == Renaming/Replacing Existing Packages ==
| |
| {{admon/note|FESCo Policy|FESCo has a [[Package_Renaming_Process#Re-review_required| package renaming policy]] that should be followed when renaming an existing package.}}
| |
| In the event that it becomes necessary to rename or replace an existing package, the new package should make the change transparent to end users to the extent applicable.
| |
| | |
| If a package is being renamed without any functional changes, or is a compatible enough replacement to an existing package (where "enough" means that it includes only changes of magnitude that are commonly found in version upgrade changes), provide clean upgrade paths and compatibility with:
| |
| | |
| <pre>
| |
| Provides: oldpackagename = $provEVR
| |
| Obsoletes: oldpackagename < $obsEVR
| |
| </pre>
| |
| | |
| $provEVR refers to an (Epoch-)Version-Release tuple the original unchanged package would have had if it had been version or release bumped. You usually use macros here because the provides EVR should continue to go up as the renamed package advances in version and release. $obsEVR is an (Epoch-)Version-Release tuple arranged so that there is a clean upgrade path but without gratuitously polluting the version space upwards. You usually do not use macros for this as you're simply trying to advance beyond the last known release under the old name.
| |
| | |
| {{admon/warning|Take <code>%{?dist}</code> into account| When deciding what $obsEVR should be, remember that it needs to be higher than the previous <code>Release:</code> with <code>%{?dist}</code> expanded. Example: if the package previously had <code>Release: 4%{?dist}</code> the release in $obsEVR should be at least 5.}}
| |
| | |
| If a package supersedes/replaces an existing package without being a compatible enough replacement as defined in above, use only the Obsoletes from above.
| |
| | |
| If the obsoleted package had an Epoch set, it must be preserved in both the Provides and Obsoletes. It may and should be removed from the actual new package.
| |
| | |
| Example: foo being renamed to bar, bar is compatible with foo, and the last foo package release being foo-1.0-3%{?dist} with Epoch: 2; add to bar (and similarly for all subpackages as applicable):
| |
| | |
| <pre>
| |
| Version: 1.0
| |
| Release: 4%{?dist}
| |
| Provides: foo = 2:%{version}-%{release}
| |
| Obsoletes: foo <= 2:1.0-4 # Important: We set the Obsoletes release to 4 to be higher than the previous Release: 3%{?dist}
| |
| </pre>
| |
| | |
| Explicit Provides: need to be aware of whether the package is supplying things that can be used in an arch-independent or arch-specific fashion. For packages that are not noarch, Provides: should be made arch-specific by applying the %{?_isa} macro to the end of the text string in Provides (e.g. Provides: foo%{?_isa} = 2:%{version}-%{release}). Packages that explicitly Provide: things that can be used in an arch-independent way—i.e., packages whose dependents don't need to be of the same arch—need not apply this macro. In some cases, a package will supply multiple elements, some of which may be consumed only by dependents of an identical arch and some which may be consumed by dependents of any arch. In such cases, both arch-specific and arch-independent Provides: are warranted.
| |
| | |
| Examples of packages that should explicitly provide only arch-specific Provides: include native code libraries or plug-ins and their associated -devel packages. Packages that should explicitly provide only arch-independent Provides: include most stand-alone programs (in addition to all noarch packages). Even though these programs may themselves be arch-specific, clients that run them should not care about their arch in most cases. A package that explicitly provides, for example, both a native code library as well as an interpreted language interface to that library should have both arch-specific (for clients of the native code library) and arch-independent (for clients of the interpreted language interface) Provides:.
| |
| | |
| If there is no standard naming for a package or other long term naming compatibility requirements involved with the rename, the Provides should be assumed to be deprecated and short lived and removed in the distro release after the next one (ie. if introduced in FC-X, keep in all subsequent package revisions for distros FC-X and FC-(X+1), drop in FC-(X+2)), and the distro version where it is planned to be dropped documented in a comment in the specfile. Maintainers of affected packages should be notified and encouraged to switch to use the new name. Forward compatibility Provides: in older distro branches can be considered in order to make it possible for package maintainers to keep same simple specfiles between branches but still switch to the newer name.
| |
| | |
| For packages that are not usually pulled in by using the package name as the dependency such as library only packages (which are pulled in through library soname depenencies), there's usually no need to add the Provides. Note however that the -devel subpackages of lib packages are pulled in as build dependencies using the package name, so adding the Provides is often appropriate there.
| |
| | |
| == Networking Support ==
| |
| If an application contains native and stable support for both IPv4 and IPv6, and support for IPv6 does not negatively affect IPv4 then both MUST be enabled in the Fedora package.
| |
| | |
| == Cron Files ==
| |
| For details on how to package cron files, refer to: [[Packaging:CronFiles]]
| |
| | |
| == Security Updates To Resolve Known CVE Issues ==
| |
| If an update to your package resolves a known security concern (at the time of the update) with a Common Vulnerabilities and Exposures (CVE) number assigned to it, you should mention the CVE number in the RPM changelog entry.
| |
| | |
| == Build time network access ==
| |
| Packages in the Fedora buildsystem are built in a mock chroot with no access to the internet. Packages must not depend or or use any network resources that they don't themselves create (ie, for tests). In no cases should source code be downloaded from any external sources, only from the lookaside cache and/or the Fedora git repository.
| |
| | |
| == Bootstrapping ==
| |
| | |
| If your package introduces build time circular dependencies, you should use this macro to bootstrap your package:
| |
| | |
| <pre>
| |
| # When we are bootstrapping, we drop some dependencies, and/or build time tests.
| |
| # Set this to 0 after we've bootstrapped.
| |
| %{!?_with_bootstrap: %global bootstrap 1}
| |
| | |
| [...]
| |
| | |
| %if ! 0%{?bootstrap}
| |
| # dependencies for %%check
| |
| BuildRequires: foo
| |
| %endif
| |
| | |
| [...]
| |
| | |
| %if ! 0%{?bootstrap}
| |
| %check
| |
| make check
| |
| %endif
| |
| </pre>
| |
| | |
| If your package explicitly <code>Provides:</code> some functionality that is missing when bootstrapped, then that <code>Provides:</code> should look like:
| |
| | |
| <pre>
| |
| %if ! 0%{?bootstrap}
| |
| Provides: bar(some_functionality)
| |
| %endif
| |
| </pre>
| |
| | |
| Please note that usage of pre-built binaries in bootstrap still needs an exception from the Packaging Committee as stated in [[Packaging:Guidelines#Exceptions]]
| |
| | |
| {{Anchor|ApplicationSpecificGuidelines}}
| |
| | |
| == System cryptographic policies ==
| |
| Applications which make use the SSL or TLS cryptographic protocols MUST follow [[Packaging:CryptoPolicies]].
| |
| | |
| == Packaging for EPEL ==
| |
| For the most part, these guidelines and the application-specific guidelines below cover packaging for both Fedora and EPEL. However, there are necessarily some differences. When packaging for EPEL, please also consult [https://fedoraproject.org/wiki/EPEL:Packaging the EPEL packaging guidelines] for additional information.
| |
| | |
| == Domain Specific Guidelines ==
| |
| | |
| Some applications, languages and build systems have specific guidelines written for them, located on their own pages in the Packaging: Namespace.
| |
| | |
| <div style="column-count:4;-moz-column-count:4;-webkit-column-count:4">
| |
| * [[Packaging:Ada|Ada]]
| |
| * [[Packaging:C and C++|C and C++]]
| |
| * [[Packaging:Cmake|Cmake]]
| |
| * [[Packaging:D|D]]
| |
| * [[Packaging:DevAssistant|DevAssistant/DAP]]
| |
| * [[Packaging:Drupal7|Drupal 7]]
| |
| * [[Packaging:EclipsePlugins|Eclipse plugins]]
| |
| * [[Packaging:Emacs|Emacs/XEmacs]]
| |
| * [[Packaging:FontsPolicy|Fonts]]
| |
| * [[Packaging:Fortran|Fortran]]
| |
| * [[Packaging:GAP|GAP]]
| |
| * [[Packaging:Globus|Globus Toolkit]]
| |
| * [[Packaging:Haskell|Haskell]]
| |
| * [[Packaging:Java|Java]]
| |
| * [[Packaging:JavaScript|JavaScript]]
| |
| * [[Packaging:Langpacks|Language packs]]
| |
| * [[Packaging:LibreOfficeExtensions|LibreOffice Extensions]]
| |
| * [[Packaging:Lisp|Lisp]]
| |
| * [[Packaging:Mono|Mono]]
| |
| * [[Packaging:MPI|MPI]]
| |
| * [[Packaging:Node.js|Node.js]]
| |
| * [[Packaging:OCaml|OCaml]]
| |
| * [[Packaging:Octave|Octave]]
| |
| * [[Packaging:Perl|Perl]]
| |
| * [[Packaging:PHP|PHP]]
| |
| * [[Packaging:PreupgradeAssistant|Preupgrade Assistant]]
| |
| * [[Packaging:Python|Python]]
| |
| * [[Packaging:R|R modules]]
| |
| * [[Packaging:Ruby|Ruby]]
| |
| * [[Packaging:SugarActivityGuidelines|Sugar activities]]
| |
| * [[Packaging:Tcl|Tcl/Tk extensions]]
| |
| * [[Packaging:Web Assets|Shared web assets]]
| |
| * [[Packaging:WordPress plugin packaging guidelines|Wordpress extensions]]
| |
| </div>
| |
| | |
| [[Category:Packaging guidelines]]
| |
